aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHåkon Hallingstad <hakon@verizonmedia.com>2019-02-20 18:55:03 +0100
committerHåkon Hallingstad <hakon@verizonmedia.com>2019-02-20 18:55:03 +0100
commit3c640fa2f076d2f580f007db17714fe7cb33f1ef (patch)
tree5683497e877132db0e21c4b1a38ebe64a1549df1
parentd0e39f15aae0f15122e6c2d84c442de2b84fad18 (diff)
Always reset updatePossiblyInProgress on leaving scope
-rw-r--r--service-monitor/src/main/java/com/yahoo/vespa/service/model/ServiceModelCache.java10
1 files changed, 6 insertions, 4 deletions
diff --git a/service-monitor/src/main/java/com/yahoo/vespa/service/model/ServiceModelCache.java b/service-monitor/src/main/java/com/yahoo/vespa/service/model/ServiceModelCache.java
index 7a6f37b2c94..c50f5e6c2d5 100644
--- a/service-monitor/src/main/java/com/yahoo/vespa/service/model/ServiceModelCache.java
+++ b/service-monitor/src/main/java/com/yahoo/vespa/service/model/ServiceModelCache.java
@@ -46,10 +46,12 @@ public class ServiceModelCache implements Supplier<ServiceModel> {
updatePossiblyInProgress = true;
}
- takeSnapshot();
-
- synchronized (updateMonitor) {
- updatePossiblyInProgress = false;
+ try {
+ takeSnapshot();
+ } finally {
+ synchronized (updateMonitor) {
+ updatePossiblyInProgress = false;
+ }
}
}