aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHåkon Hallingstad <hakon@yahooinc.com>2024-02-29 14:42:12 +0100
committerHåkon Hallingstad <hakon@yahooinc.com>2024-02-29 14:42:12 +0100
commit7f1db4955a6cad6d5b2ce07450895885f26d7f94 (patch)
tree7384d0f861de4a8a14702cf5da2f30a9593af5d6
parentcd0c793b26d0787429d4ae55c71b9e5a99bcd195 (diff)
Document private vs public IPs in Azure
-rw-r--r--node-repository/src/main/java/com/yahoo/vespa/hosted/provision/node/Dns.java11
1 files changed, 6 insertions, 5 deletions
diff --git a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/node/Dns.java b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/node/Dns.java
index 9f5aaf4b327..1131529c84e 100644
--- a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/node/Dns.java
+++ b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/node/Dns.java
@@ -38,11 +38,12 @@ public class Dns {
}
if (cloudName == CloudName.AZURE) {
- return ipVersion.is6() ?
- EnumSet.noneOf(RecordType.class) :
- enclave || hostType == confighost ?
- EnumSet.of(RecordType.FORWARD, RecordType.PUBLIC_FORWARD) :
- EnumSet.of(RecordType.FORWARD);
+ return ipVersion.is6() ? EnumSet.noneOf(RecordType.class) :
+ // Each Azure enclave and cfg host and child gets one private 10.* address and one public address.
+ // The private DNS zone resolves to the private, while the public DNS zone resolves to the public,
+ // which is why we return FORWARD and PUBLIC_FORWARD here. The node repo only contains the private addresses.
+ enclave || hostType == confighost ? EnumSet.of(RecordType.FORWARD, RecordType.PUBLIC_FORWARD) :
+ EnumSet.of(RecordType.FORWARD);
}
throw new IllegalArgumentException("Does not manage DNS for cloud " + cloudName);