aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHarald Musum <musum@yahooinc.com>2024-01-03 14:28:49 +0100
committerGitHub <noreply@github.com>2024-01-03 14:28:49 +0100
commit196a1b79bac9727e755b41897faef63a69c9a530 (patch)
treea26e6bcbca16b5de60aa8ef3ae65ec13cc43fe6e
parent629c1c5c1c384efb8988d2054486f1ce5cc8365a (diff)
parenta5376d6b45e9ddc9e68b5061bf1ec03a2c91d527 (diff)
Merge pull request #29786 from vespa-engine/hmusum/cleanup-2
GC unused methods
-rw-r--r--config-model-api/abi-spec.json2
-rw-r--r--config-model-api/src/main/java/com/yahoo/config/model/api/OnnxModelCost.java8
2 files changed, 0 insertions, 10 deletions
diff --git a/config-model-api/abi-spec.json b/config-model-api/abi-spec.json
index 51e8f554ffb..b4bf45d655a 100644
--- a/config-model-api/abi-spec.json
+++ b/config-model-api/abi-spec.json
@@ -1457,9 +1457,7 @@
],
"methods" : [
"public abstract long aggregatedModelCostInBytes()",
- "public void registerModel(com.yahoo.config.application.api.ApplicationFile)",
"public abstract void registerModel(com.yahoo.config.application.api.ApplicationFile, com.yahoo.config.model.api.OnnxModelOptions)",
- "public void registerModel(java.net.URI)",
"public abstract void registerModel(java.net.URI, com.yahoo.config.model.api.OnnxModelOptions)",
"public abstract java.util.Map models()",
"public abstract void setRestartOnDeploy()",
diff --git a/config-model-api/src/main/java/com/yahoo/config/model/api/OnnxModelCost.java b/config-model-api/src/main/java/com/yahoo/config/model/api/OnnxModelCost.java
index 69f2b6b6dce..17a0d64aac9 100644
--- a/config-model-api/src/main/java/com/yahoo/config/model/api/OnnxModelCost.java
+++ b/config-model-api/src/main/java/com/yahoo/config/model/api/OnnxModelCost.java
@@ -18,15 +18,7 @@ public interface OnnxModelCost {
interface Calculator {
long aggregatedModelCostInBytes();
- // TODO: Unused, remove when 8.263.7 is oldest model in use
- default void registerModel(ApplicationFile path) {
- registerModel(path, OnnxModelOptions.empty());
- }
void registerModel(ApplicationFile path, OnnxModelOptions onnxModelOptions);
- // TODO: Unused, remove when 8.263.7 is oldest model in use
- default void registerModel(URI uri) {
- registerModel(uri, OnnxModelOptions.empty());
- }
void registerModel(URI uri, OnnxModelOptions onnxModelOptions);
Map<String, ModelInfo> models();
void setRestartOnDeploy();