diff options
author | Harald Musum <musum@yahooinc.com> | 2022-08-11 09:57:49 +0200 |
---|---|---|
committer | Harald Musum <musum@yahooinc.com> | 2022-08-11 09:57:49 +0200 |
commit | ddf7ff3e38488c417822b24739ce598d07bbee64 (patch) | |
tree | 416033ee346c6b28ee0fa3c6e79281e79f089d7d | |
parent | 8be6039101a0c4006199c2946d8381c86428ec11 (diff) |
Extract method for getting slobrok connection specs
4 files changed, 15 insertions, 18 deletions
diff --git a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/FleetControllerTest.java b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/FleetControllerTest.java index 5e4b62e0462..d8317c5323d 100644 --- a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/FleetControllerTest.java +++ b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/FleetControllerTest.java @@ -151,8 +151,7 @@ public abstract class FleetControllerTest implements Waiter { this.options.zooKeeperServerAddress = zooKeeperServer.getAddress(); log.log(Level.FINE, "Set up new zookeeper server at " + this.options.zooKeeperServerAddress); } - this.options.slobrokConnectionSpecs = new String[1]; - this.options.slobrokConnectionSpecs[0] = "tcp/localhost:" + slobrok.port(); + this.options.slobrokConnectionSpecs = getSlobrokConnectionSpecs(slobrok); this.usingFakeTimer = useFakeTimer; } @@ -239,8 +238,7 @@ public abstract class FleetControllerTest implements Waiter { setUpVdsNodes(useFakeTimer, options, startDisconnected, nodeIndexes); } protected void setUpVdsNodes(boolean useFakeTimer, DummyVdsNodeOptions options, boolean startDisconnected, Set<Integer> nodeIndexes) throws Exception { - String[] connectionSpecs = new String[1]; - connectionSpecs[0] = "tcp/localhost:" + slobrok.port(); + String[] connectionSpecs = getSlobrokConnectionSpecs(slobrok); for (int nodeIndex : nodeIndexes) { nodes.add(new DummyVdsNode(useFakeTimer ? timer : new RealTimer(), options, connectionSpecs, this.options.clusterName, true, nodeIndex)); if ( ! startDisconnected) nodes.get(nodes.size() - 1).connect(); @@ -256,8 +254,7 @@ public abstract class FleetControllerTest implements Waiter { * the returned list is twice as large as configuredNodes. */ protected List<DummyVdsNode> setUpVdsNodes(boolean useFakeTimer, DummyVdsNodeOptions options, boolean startDisconnected, List<ConfiguredNode> configuredNodes) throws Exception { - String[] connectionSpecs = new String[1]; - connectionSpecs[0] = "tcp/localhost:" + slobrok.port(); + String[] connectionSpecs = getSlobrokConnectionSpecs(slobrok); nodes = new ArrayList<>(); final boolean distributor = true; for (ConfiguredNode configuredNode : configuredNodes) { @@ -488,4 +485,10 @@ public abstract class FleetControllerTest implements Waiter { } } + static String[] getSlobrokConnectionSpecs(Slobrok slobrok) { + String[] connectionSpecs = new String[1]; + connectionSpecs[0] = "tcp/localhost:" + slobrok.port(); + return connectionSpecs; + } + } diff --git a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/MasterElectionTest.java b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/MasterElectionTest.java index fb468ee4d5b..5133a98d552 100644 --- a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/MasterElectionTest.java +++ b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/MasterElectionTest.java @@ -48,8 +48,7 @@ public class MasterElectionTest extends FleetControllerTest { this.options = options; this.options.zooKeeperSessionTimeout = defaultZkSessionTimeoutInMillis(); this.options.zooKeeperServerAddress = zooKeeperServer.getAddress(); - this.options.slobrokConnectionSpecs = new String[1]; - this.options.slobrokConnectionSpecs[0] = "tcp/localhost:" + slobrok.port(); + this.options.slobrokConnectionSpecs = getSlobrokConnectionSpecs(slobrok); this.options.fleetControllerCount = count; for (int i=0; i<count; ++i) { FleetControllerOptions nodeOptions = options.clone(); @@ -58,13 +57,11 @@ public class MasterElectionTest extends FleetControllerTest { } } - private FleetControllerOptions adjustConfig(FleetControllerOptions o, - int fleetControllerIndex, int fleetControllerCount) { + private FleetControllerOptions adjustConfig(FleetControllerOptions o, int fleetControllerIndex, int fleetControllerCount) { FleetControllerOptions options = o.clone(); options.zooKeeperSessionTimeout = defaultZkSessionTimeoutInMillis(); options.zooKeeperServerAddress = zooKeeperServer.getAddress(); - options.slobrokConnectionSpecs = new String[1]; - options.slobrokConnectionSpecs[0] = "tcp/localhost:" + slobrok.port(); // Spec.fromLocalHostName(slobrok.port()).toString(); + options.slobrokConnectionSpecs = getSlobrokConnectionSpecs(slobrok); options.fleetControllerIndex = fleetControllerIndex; options.fleetControllerCount = fleetControllerCount; return options; diff --git a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/RpcServerTest.java b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/RpcServerTest.java index 41d7465b602..31730c88276 100644 --- a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/RpcServerTest.java +++ b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/RpcServerTest.java @@ -52,8 +52,7 @@ public class RpcServerTest extends FleetControllerTest { void testRebinding() throws Exception { startingTest("RpcServerTest::testRebinding"); Slobrok slobrok = new Slobrok(); - String[] slobrokConnectionSpecs = new String[1]; - slobrokConnectionSpecs[0] = "tcp/localhost:" + slobrok.port(); + String[] slobrokConnectionSpecs = getSlobrokConnectionSpecs(slobrok); RpcServer server = new RpcServer(timer, new Object(), "mycluster", 0, new BackOff()); server.setSlobrokConnectionSpecs(slobrokConnectionSpecs, 18347); int portUsed = server.getPort(); diff --git a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/StateGatherTest.java b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/StateGatherTest.java index 892aefbb865..86b43f539fb 100644 --- a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/StateGatherTest.java +++ b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/StateGatherTest.java @@ -1,10 +1,9 @@ // Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root. package com.yahoo.vespa.clustercontroller.core; -import java.util.logging.Level; import org.junit.jupiter.api.Test; - import java.util.concurrent.TimeoutException; +import java.util.logging.Level; import java.util.logging.Logger; import static org.junit.jupiter.api.Assertions.assertEquals; @@ -33,8 +32,7 @@ public class StateGatherTest extends FleetControllerTest { options.nodeStateRequestTimeoutEarliestPercentage = 80; options.nodeStateRequestTimeoutLatestPercentage = 80; setUpFleetController(true, options); - String[] connectionSpecs = new String[1]; - connectionSpecs[0] = "tcp/localhost:" + slobrok.port(); + String[] connectionSpecs = getSlobrokConnectionSpecs(slobrok); DummyVdsNodeOptions dummyOptions = new DummyVdsNodeOptions(); DummyVdsNode dnode = new DummyVdsNode(timer, dummyOptions, connectionSpecs, this.options.clusterName, true, 0); DummyVdsNode snode = new DummyVdsNode(timer, dummyOptions, connectionSpecs, this.options.clusterName, false, 0); |