diff options
| author | Morten Tokle <mortent@yahooinc.com> | 2023-10-25 10:24:34 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-10-25 10:24:34 +0200 |
| commit | 2695d14822d91b0e00c4c46ae4fbdcca707a327f (patch) | |
| tree | d1399d1d04abc92f6b605728fe3d0a249fd45725 | |
| parent | 03a32f169d68bdee6f76fffe3bc0eea820cc533b (diff) | |
| parent | a4ee9d62f1de1729317a53aaa9848d1462ca6958 (diff) | |
Merge pull request #29088 from vespa-engine/hakonhall/add-warning-on-changing-serialized-format
Add warning on changing serialized format
| -rw-r--r-- | flags/src/main/java/com/yahoo/vespa/flags/json/DimensionHelper.java | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/flags/src/main/java/com/yahoo/vespa/flags/json/DimensionHelper.java b/flags/src/main/java/com/yahoo/vespa/flags/json/DimensionHelper.java index dea88d1687b..4323af5a4fd 100644 --- a/flags/src/main/java/com/yahoo/vespa/flags/json/DimensionHelper.java +++ b/flags/src/main/java/com/yahoo/vespa/flags/json/DimensionHelper.java @@ -17,6 +17,8 @@ public class DimensionHelper { private static final Map<FetchVector.Dimension, String> serializedDimensions = new HashMap<>(); static { + // WARNING: If you ever change the serialized form of a dimension, ensure the new serialized + // flag data are pushed out everywhere before removing support for old format, see VESPA-27760. serializedDimensions.put(FetchVector.Dimension.APPLICATION_ID, "application"); serializedDimensions.put(FetchVector.Dimension.CLOUD, "cloud"); serializedDimensions.put(FetchVector.Dimension.CLOUD_ACCOUNT, "cloud-account"); |