diff options
| author | Valerij Fredriksen <freva@users.noreply.github.com> | 2023-10-04 09:51:37 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-10-04 09:51:37 +0200 |
| commit | 2b54ecf17164ec8c896cfe67843a78063e68de08 (patch) | |
| tree | 7212fcc51adaab6adc9e5c85a7b65a4031f69189 | |
| parent | 4773f88e3a94056ffbaa2ffeac1729f0254d776d (diff) | |
| parent | ea0a45e958378c062bce40694fa5e60b54e6be8d (diff) | |
Merge pull request #28781 from vespa-engine/jonmv/improve-log-message
Log whether (de)?activation was successful
| -rw-r--r-- | zkfacade/src/main/java/com/yahoo/vespa/curator/SingletonManager.java | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/zkfacade/src/main/java/com/yahoo/vespa/curator/SingletonManager.java b/zkfacade/src/main/java/com/yahoo/vespa/curator/SingletonManager.java index e37d561ca1b..d203f22a474 100644 --- a/zkfacade/src/main/java/com/yahoo/vespa/curator/SingletonManager.java +++ b/zkfacade/src/main/java/com/yahoo/vespa/curator/SingletonManager.java @@ -425,7 +425,8 @@ class SingletonManager { finally { long durationMillis = Duration.between(start, clock.instant()).toMillis(); metric.set(ACTIVATION_MILLIS, durationMillis, context); - logger.log(INFO, "Activation completed in %.3f seconds".formatted(durationMillis * 1e-3)); + logger.log(INFO, "Activation completed " + (failed ? "un" : "") + + "successfully in %.3f seconds".formatted(durationMillis * 1e-3)); if (failed) metric.add(ACTIVATION_FAILURES, 1, context); else isActive = true; ping(); @@ -447,7 +448,8 @@ class SingletonManager { finally { long durationMillis = Duration.between(start, clock.instant()).toMillis(); metric.set(DEACTIVATION_MILLIS, durationMillis, context); - logger.log(INFO, "Deactivation completed in %.3f seconds".formatted(durationMillis * 1e-3)); + logger.log(INFO, "Deactivation completed " + (failed ? "un" : "") + + "successfully in %.3f seconds".formatted(durationMillis * 1e-3)); if (failed) metric.add(DEACTIVATION_FAILURES, 1, context); isActive = false; ping(); |