aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMartin Polden <mpolden@mpolden.no>2023-04-17 16:18:42 +0200
committerMartin Polden <mpolden@mpolden.no>2023-04-18 15:12:02 +0200
commit3d33c28f7e5fdaffbe91db4dcd03d78661820164 (patch)
tree196de73fa97030d21d9301473668ec878116560d
parentb31fc1f1ae7ac6dac7cc09987c814d0c5e0e1b3c (diff)
Remove unnecessary ID string building
-rw-r--r--client/go/internal/vespa/document/document.go22
1 files changed, 4 insertions, 18 deletions
diff --git a/client/go/internal/vespa/document/document.go b/client/go/internal/vespa/document/document.go
index efb60ad8c0a..4ec3eac1cbc 100644
--- a/client/go/internal/vespa/document/document.go
+++ b/client/go/internal/vespa/document/document.go
@@ -21,6 +21,8 @@ const (
// Id represents a Vespa document ID.
type Id struct {
+ id string
+
Type string
Namespace string
Number *int64
@@ -36,24 +38,7 @@ func (d Id) Equal(o Id) bool {
d.UserSpecific == o.UserSpecific
}
-func (d Id) String() string {
- var sb strings.Builder
- sb.WriteString("id:")
- sb.WriteString(d.Namespace)
- sb.WriteString(":")
- sb.WriteString(d.Type)
- sb.WriteString(":")
- if d.Number != nil {
- sb.WriteString("n=")
- sb.WriteString(strconv.FormatInt(*d.Number, 10))
- } else if d.Group != "" {
- sb.WriteString("g=")
- sb.WriteString(d.Group)
- }
- sb.WriteString(":")
- sb.WriteString(d.UserSpecific)
- return sb.String()
-}
+func (d Id) String() string { return d.id }
// ParseId parses a serialized document ID string.
func ParseId(serialized string) (Id, error) {
@@ -95,6 +80,7 @@ func ParseId(serialized string) (Id, error) {
return Id{}, parseError(serialized)
}
return Id{
+ id: serialized,
Namespace: namespace,
Type: docType,
Number: number,