aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArnstein Ressem <aressem@verizonmedia.com>2023-08-21 11:32:22 +0200
committerGitHub <noreply@github.com>2023-08-21 11:32:22 +0200
commite23d2d7953ed8563db47af5bffd8c17293965863 (patch)
treee37bed0634198305f9cb81a9caeff3a3860b3c3e
parent23bc5c505c00e98f0bc1a3a5349b70eaa9e59a81 (diff)
parentce5a544edd6260f19f9c0b791f05dac192cd8a8d (diff)
Merge pull request #28091 from vespa-engine/mpolden/schedule-latest
Schedule latest OS version
-rw-r--r--controller-server/src/main/java/com/yahoo/vespa/hosted/controller/maintenance/OsUpgradeScheduler.java7
-rw-r--r--controller-server/src/test/java/com/yahoo/vespa/hosted/controller/maintenance/OsUpgradeSchedulerTest.java4
2 files changed, 3 insertions, 8 deletions
diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/maintenance/OsUpgradeScheduler.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/maintenance/OsUpgradeScheduler.java
index c751c0a130b..8d48576044b 100644
--- a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/maintenance/OsUpgradeScheduler.java
+++ b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/maintenance/OsUpgradeScheduler.java
@@ -160,17 +160,12 @@ public class OsUpgradeScheduler extends ControllerMaintainer {
@Override
public Change change(Version currentVersion, Instant instant) {
- OsRelease release = artifactRepository.osRelease(currentVersion.getMajor(), tag());
+ OsRelease release = artifactRepository.osRelease(currentVersion.getMajor(), OsRelease.Tag.latest);
Duration cooldown = remainingCooldownOf(cooldown(), release.age(instant));
Instant scheduleAt = schedulingInstant(instant.plus(cooldown), system);
return new Change(new OsVersion(release.version(), cloud), scheduleAt);
}
- /** Returns the release tag tracked by this system */
- private OsRelease.Tag tag() {
- return system.isCd() ? OsRelease.Tag.latest : OsRelease.Tag.stable;
- }
-
/** The cool-down period that must pass before a release can be used */
private Duration cooldown() {
return system.isCd() ? Duration.ofDays(1) : Duration.ZERO;
diff --git a/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/maintenance/OsUpgradeSchedulerTest.java b/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/maintenance/OsUpgradeSchedulerTest.java
index 178e8f18489..8fe2ac914ef 100644
--- a/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/maintenance/OsUpgradeSchedulerTest.java
+++ b/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/maintenance/OsUpgradeSchedulerTest.java
@@ -148,7 +148,7 @@ public class OsUpgradeSchedulerTest {
}
@Test
- void schedule_stable_release() {
+ void schedule_latest_release() {
ControllerTester tester = new ControllerTester();
OsUpgradeScheduler scheduler = new OsUpgradeScheduler(tester.controller(), Duration.ofDays(1));
Instant t0 = Instant.parse("2021-06-22T00:42:12.00Z"); // Outside trigger period
@@ -161,7 +161,7 @@ public class OsUpgradeSchedulerTest {
// Stable release (tagged outside trigger period) is scheduled once trigger period opens
Version version1 = Version.fromString("8.1");
- tester.serviceRegistry().artifactRepository().addRelease(new OsRelease(version1, OsRelease.Tag.stable,
+ tester.serviceRegistry().artifactRepository().addRelease(new OsRelease(version1, OsRelease.Tag.latest,
Instant.parse("2021-06-21T23:59:00.00Z")));
scheduleUpgradeAfter(Duration.ZERO, version0, scheduler, tester);