diff options
author | Henning Baldersheim <balder@yahoo-inc.com> | 2024-02-12 08:32:17 +0000 |
---|---|---|
committer | Henning Baldersheim <balder@yahoo-inc.com> | 2024-02-12 08:32:17 +0000 |
commit | a3dc950653aded192badf5c0ba44bae79e2bf05d (patch) | |
tree | 43207f9709fd34df569b113fc3125f6a06ab0e8d | |
parent | cf51f5aebb0f81ab19062232f875ce1612334d3a (diff) |
Add noexcept, remove virtual and use = default
-rw-r--r-- | searchlib/src/vespa/searchlib/attribute/multinumericattributesaver.cpp | 16 | ||||
-rw-r--r-- | searchlib/src/vespa/searchlib/attribute/multinumericattributesaver.h | 4 |
2 files changed, 7 insertions, 13 deletions
diff --git a/searchlib/src/vespa/searchlib/attribute/multinumericattributesaver.cpp b/searchlib/src/vespa/searchlib/attribute/multinumericattributesaver.cpp index 26ff6a0dcf9..cbb001c6e07 100644 --- a/searchlib/src/vespa/searchlib/attribute/multinumericattributesaver.cpp +++ b/searchlib/src/vespa/searchlib/attribute/multinumericattributesaver.cpp @@ -17,13 +17,11 @@ class DatWriter { std::unique_ptr<search::BufferWriter> _datWriter; public: - DatWriter(IAttributeSaveTarget &saveTarget) + explicit DatWriter(IAttributeSaveTarget &saveTarget) : _datWriter(saveTarget.datWriter().allocBufferWriter()) - { - } + { } - ~DatWriter() - { + ~DatWriter() { _datWriter->flush(); } @@ -53,15 +51,11 @@ MultiValueNumericAttributeSaver(GenerationHandler::Guard &&guard, template <typename MultiValueT> -MultiValueNumericAttributeSaver<MultiValueT>:: -~MultiValueNumericAttributeSaver() -{ -} +MultiValueNumericAttributeSaver<MultiValueT>::~MultiValueNumericAttributeSaver() = default; template <typename MultiValueT> bool -MultiValueNumericAttributeSaver<MultiValueT>:: -onSave(IAttributeSaveTarget &saveTarget) +MultiValueNumericAttributeSaver<MultiValueT>::onSave(IAttributeSaveTarget &saveTarget) { CountWriter countWriter(saveTarget); WeightWriter<multivalue::is_WeightedValue_v<MultiValueType>> weightWriter(saveTarget); diff --git a/searchlib/src/vespa/searchlib/attribute/multinumericattributesaver.h b/searchlib/src/vespa/searchlib/attribute/multinumericattributesaver.h index c0bffca8408..240c75bfc42 100644 --- a/searchlib/src/vespa/searchlib/attribute/multinumericattributesaver.h +++ b/searchlib/src/vespa/searchlib/attribute/multinumericattributesaver.h @@ -26,12 +26,12 @@ class MultiValueNumericAttributeSaver : public MultiValueAttributeSaver const MultiValueMapping &_mvMapping; public: - virtual bool onSave(IAttributeSaveTarget &saveTarget) override; + bool onSave(IAttributeSaveTarget &saveTarget) override; MultiValueNumericAttributeSaver(GenerationHandler::Guard &&guard, const attribute::AttributeHeader &header, const MultiValueMapping &mvMapping); - virtual ~MultiValueNumericAttributeSaver(); + ~MultiValueNumericAttributeSaver() override; }; |