aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHarald Musum <musum@verizonmedia.com>2023-07-20 17:19:19 +0200
committerGitHub <noreply@github.com>2023-07-20 17:19:19 +0200
commit84df2b37f1f5ed9032fb4df4024d87a522f558b8 (patch)
tree0d899a45235da6224a3757f1ce018c5ae9537482
parent2945ada30f63e80504f515c2e08bb341dc29d0d7 (diff)
parenta25e80a1761452e2065ace68ca33aa214cb89ffb (diff)
Merge pull request #27849 from vespa-engine/hmusum/log-more-temporarily
More logging at higher level, need more info
-rw-r--r--clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/NodeStateChangeChecker.java8
1 files changed, 5 insertions, 3 deletions
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/NodeStateChangeChecker.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/NodeStateChangeChecker.java
index 8453fb3450c..212748d6947 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/NodeStateChangeChecker.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/NodeStateChangeChecker.java
@@ -39,6 +39,7 @@ import static com.yahoo.vespa.clustercontroller.core.NodeStateChangeChecker.Resu
import static com.yahoo.vespa.clustercontroller.utils.staterestapi.requests.SetUnitStateRequest.Condition.FORCE;
import static com.yahoo.vespa.clustercontroller.utils.staterestapi.requests.SetUnitStateRequest.Condition.SAFE;
import static java.util.logging.Level.FINE;
+import static java.util.logging.Level.INFO;
/**
* Checks if a node can be upgraded.
@@ -165,6 +166,7 @@ public class NodeStateChangeChecker {
if (anotherNodeInGroupAlreadyAllowed(nodeInfo, newDescription))
return allow();
} else {
+ log.log(INFO, "Checking if we can set " + nodeInfo.getNode() + " to maintenance temporarily");
var optionalResult = checkIfOtherNodesHaveWantedState(nodeInfo, newDescription, clusterState);
if (optionalResult.isPresent())
return optionalResult.get();
@@ -243,13 +245,13 @@ public class NodeStateChangeChecker {
Set<Integer> groupsWithNodesWantedStateNotUp = groupsWithUserWantedStateNotUp();
if (groupsWithNodesWantedStateNotUp.size() == 0) {
- log.log(FINE, "groupsWithNodesWantedStateNotUp=0");
+ log.log(INFO, "groupsWithNodesWantedStateNotUp=0");
return Optional.empty();
}
Set<Integer> groupsWithSameStateAndDescription = groupsWithSameStateAndDescription(MAINTENANCE, newDescription);
if (aGroupContainsNode(groupsWithSameStateAndDescription, node)) {
- log.log(FINE, "Node is in group with same state and description, allow");
+ log.log(INFO, "Node is in group with same state and description, allow");
return Optional.of(allow());
}
// There are groups with nodes not up, but with another description, probably operator set
@@ -271,7 +273,7 @@ public class NodeStateChangeChecker {
return result;
if (numberOfGroupsToConsider < maxNumberOfGroupsAllowedToBeDown) {
- log.log(FINE, "Allow, retiredAndNotUpGroups=" + retiredAndNotUpGroups);
+ log.log(INFO, "Allow, retiredAndNotUpGroups=" + retiredAndNotUpGroups);
return Optional.of(allow());
}