diff options
author | Jon Bratseth <bratseth@gmail.com> | 2022-03-09 11:18:16 +0100 |
---|---|---|
committer | Jon Bratseth <bratseth@gmail.com> | 2022-03-09 11:18:16 +0100 |
commit | e9884be39bf30b8e00aecf439bfe8f3fb7911cf7 (patch) | |
tree | 2f6b78708115280906e9c9b0b1e7b7b82e7d448b | |
parent | b1015bd850fb94157d8c21077578e45628384e02 (diff) |
Cleanup
2 files changed, 4 insertions, 8 deletions
diff --git a/container-search/src/main/java/com/yahoo/search/dispatch/searchcluster/SearchCluster.java b/container-search/src/main/java/com/yahoo/search/dispatch/searchcluster/SearchCluster.java index 36d7e7a85a9..e5b8d799bbf 100644 --- a/container-search/src/main/java/com/yahoo/search/dispatch/searchcluster/SearchCluster.java +++ b/container-search/src/main/java/com/yahoo/search/dispatch/searchcluster/SearchCluster.java @@ -293,19 +293,15 @@ public class SearchCluster implements NodeManager<Node> { // With just one group sufficient coverage may not be the same as full coverage, as the // group will always be marked sufficient for use. updateSufficientCoverage(group, true); - boolean sufficientCoverage = isGroupCoverageSufficient(group.activeDocuments(), - group.activeDocuments()); + boolean sufficientCoverage = isGroupCoverageSufficient(group.activeDocuments(), group.activeDocuments()); trackGroupCoverageChanges(group, sufficientCoverage, group.activeDocuments()); } private void pingIterationCompletedMultipleGroups() { orderedGroups().forEach(Group::aggregateNodeValues); long medianDocuments = medianDocumentsPerGroup(); - boolean anyGroupsSufficientCoverage = false; for (Group group : orderedGroups()) { - boolean sufficientCoverage = isGroupCoverageSufficient(group.activeDocuments(), - medianDocuments); - anyGroupsSufficientCoverage = anyGroupsSufficientCoverage || sufficientCoverage; + boolean sufficientCoverage = isGroupCoverageSufficient(group.activeDocuments(), medianDocuments); updateSufficientCoverage(group, sufficientCoverage); trackGroupCoverageChanges(group, sufficientCoverage, medianDocuments); } diff --git a/model-integration/src/main/java/ai/vespa/rankingexpression/importer/xgboost/XGBoostParser.java b/model-integration/src/main/java/ai/vespa/rankingexpression/importer/xgboost/XGBoostParser.java index c149683d5e6..caa7129ad34 100644 --- a/model-integration/src/main/java/ai/vespa/rankingexpression/importer/xgboost/XGBoostParser.java +++ b/model-integration/src/main/java/ai/vespa/rankingexpression/importer/xgboost/XGBoostParser.java @@ -15,12 +15,12 @@ import com.fasterxml.jackson.databind.ObjectMapper; */ class XGBoostParser { - private List<XGBoostTree> xgboostTrees; + private final List<XGBoostTree> xgboostTrees; /** * Constructor stores parsed JSON trees. * - * @param filePath XGBoost JSON output file. + * @param filePath XGBoost JSON intput file. * @throws JsonProcessingException Fails JSON parsing. * @throws IOException Fails file reading. */ |