diff options
author | Geir Storli <geirst@yahooinc.com> | 2022-03-25 16:09:12 +0000 |
---|---|---|
committer | Geir Storli <geirst@yahooinc.com> | 2022-03-25 16:09:12 +0000 |
commit | 75638909c3181d393ef68a304191e5e17bb0a854 (patch) | |
tree | dc228a967fd3775601985a3ca8302ef5239d545b | |
parent | 37508626ed6a22bbbf053add1d2065ff16d261c3 (diff) |
Remove unused item enum and add note on limitations on number of item types.
-rw-r--r-- | searchlib/src/vespa/searchlib/parsequery/parse.h | 3 | ||||
-rw-r--r-- | searchsummary/src/tests/extractkeywords/simplequerystackitem.cpp | 1 |
2 files changed, 2 insertions, 2 deletions
diff --git a/searchlib/src/vespa/searchlib/parsequery/parse.h b/searchlib/src/vespa/searchlib/parsequery/parse.h index 0d665d1f04d..c3b5fcc81fa 100644 --- a/searchlib/src/vespa/searchlib/parsequery/parse.h +++ b/searchlib/src/vespa/searchlib/parsequery/parse.h @@ -57,8 +57,9 @@ public: ITEM_TRUE = 28, ITEM_FALSE = 29, ITEM_FUZZY = 30, - ITEM_MAX = 31, // Indicates how long tables must be. ITEM_UNDEF = 32, + // NOTE: Only 5 bits are used to encode the item type in the protocol, and 31 is the last available value. + // We might need to use 31 to signal a protocol extension in order to support more item types. }; /** A tag identifying the origin of this query node. diff --git a/searchsummary/src/tests/extractkeywords/simplequerystackitem.cpp b/searchsummary/src/tests/extractkeywords/simplequerystackitem.cpp index 7f9557232b0..65815f86251 100644 --- a/searchsummary/src/tests/extractkeywords/simplequerystackitem.cpp +++ b/searchsummary/src/tests/extractkeywords/simplequerystackitem.cpp @@ -189,7 +189,6 @@ SimpleQueryStackItem::AppendBuffer(RawBuf *buf) const break; case ITEM_MULTI_TERM: // TODO: handle case ITEM_PREDICATE_QUERY: // not handled at all here - case ITEM_MAX: case ITEM_UNDEF: abort(); break; |