summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHarald Musum <musum@verizonmedia.com>2021-10-02 00:34:46 +0200
committerGitHub <noreply@github.com>2021-10-02 00:34:46 +0200
commitcacd694f88f673a0d6e753c52993df8e46721922 (patch)
tree982b45d3cc561343cd515c3b5042f81cfa9efed7
parentfbd42962060a8b4975ae49e6fb64899dc1a23588 (diff)
Revert "Throw instead of setting config if we get bad config [run-systemtest]"
-rw-r--r--config/src/main/java/com/yahoo/config/subscription/impl/JRTConfigSubscription.java11
1 files changed, 8 insertions, 3 deletions
diff --git a/config/src/main/java/com/yahoo/config/subscription/impl/JRTConfigSubscription.java b/config/src/main/java/com/yahoo/config/subscription/impl/JRTConfigSubscription.java
index f50ed694115..e83fc7aefc5 100644
--- a/config/src/main/java/com/yahoo/config/subscription/impl/JRTConfigSubscription.java
+++ b/config/src/main/java/com/yahoo/config/subscription/impl/JRTConfigSubscription.java
@@ -105,11 +105,16 @@ public class JRTConfigSubscription<T extends ConfigInstance> extends ConfigSubsc
}
protected void setNewConfig(JRTClientConfigRequest jrtReq) {
+ Exception badConfigE = null;
+ T configInstance = null;
try {
- T configInstance = toConfigInstance(jrtReq);
- setConfig(jrtReq.getNewGeneration(), jrtReq.responseIsApplyOnRestart(), configInstance, jrtReq.getNewChecksums());
+ configInstance = toConfigInstance(jrtReq);
} catch (IllegalArgumentException e) {
- throw new IllegalArgumentException("Bad config in response", e);
+ badConfigE = e;
+ }
+ setConfig(jrtReq.getNewGeneration(), jrtReq.responseIsApplyOnRestart(), configInstance, jrtReq.getNewChecksums());
+ if (badConfigE != null) {
+ throw new IllegalArgumentException("Bad config from jrt", badConfigE);
}
}