summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGeir Storli <geirst@verizonmedia.com>2021-10-15 13:28:14 +0000
committerGeir Storli <geirst@verizonmedia.com>2021-10-15 13:28:14 +0000
commit9263869a287f52d38b7addcafc59464c4674daee (patch)
tree7d3028fee3a2c663210adf3b1e8cba86b02b8e9b
parent7a1b8e39ce5f6b7ed4d425e7ca879fc7617a21e3 (diff)
Remove explicit syncing of all write executors when handling DeleteBucket operations.
This really hurts the performance of the feed pipeline (e.g. during merging buckets), as all executor queues are drained and then the executors need time to rebuild momentum afterwards. This is also not needed from a data consistency point of view, as the DeleteBucket operation is ack'ed right after it has been written to the TLS.
-rw-r--r--searchcore/src/vespa/searchcore/proton/server/searchable_feed_view.cpp1
1 files changed, 0 insertions, 1 deletions
diff --git a/searchcore/src/vespa/searchcore/proton/server/searchable_feed_view.cpp b/searchcore/src/vespa/searchcore/proton/server/searchable_feed_view.cpp
index 4f1590259cd..829725b92e5 100644
--- a/searchcore/src/vespa/searchcore/proton/server/searchable_feed_view.cpp
+++ b/searchcore/src/vespa/searchcore/proton/server/searchable_feed_view.cpp
@@ -175,7 +175,6 @@ void
SearchableFeedView::internalDeleteBucket(const DeleteBucketOperation &delOp)
{
Parent::internalDeleteBucket(delOp);
- _writeService.sync();
}
void