summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGeir Storli <geirst@yahooinc.com>2021-10-23 14:11:40 +0200
committerGitHub <noreply@github.com>2021-10-23 14:11:40 +0200
commit9159d6e590192e5a66b0e265a8ce4e23359ed4eb (patch)
treeb0662c310f121bc621370638203d924a92c35886
parent9a62da93ddd9017eea713791d92bef8cdaa9633e (diff)
parent5ec683c43ecf668891a9ef782f816ded59739257 (diff)
Merge pull request #19709 from vespa-engine/toregge/fix-merge-status-check-delayed-error
Fix MergeStatus::check_delayed_error: Empty fail message is not an error.
-rw-r--r--storage/src/vespa/storage/persistence/filestorage/mergestatus.cpp4
1 files changed, 3 insertions, 1 deletions
diff --git a/storage/src/vespa/storage/persistence/filestorage/mergestatus.cpp b/storage/src/vespa/storage/persistence/filestorage/mergestatus.cpp
index 1d9e0c6fae6..a75eda5b1a4 100644
--- a/storage/src/vespa/storage/persistence/filestorage/mergestatus.cpp
+++ b/storage/src/vespa/storage/persistence/filestorage/mergestatus.cpp
@@ -138,7 +138,9 @@ MergeStatus::check_delayed_error(api::ReturnCode &return_code)
future_error.wait();
vespalib::string fail_message = future_error.get();
delayed_error.reset();
- return_code = api::ReturnCode(api::ReturnCode::INTERNAL_FAILURE, std::move(fail_message));
+ if (!fail_message.empty()) {
+ return_code = api::ReturnCode(api::ReturnCode::INTERNAL_FAILURE, std::move(fail_message));
+ }
}
}