summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJon Marius Venstad <venstad@gmail.com>2022-01-21 10:19:10 +0100
committerJon Marius Venstad <venstad@gmail.com>2022-01-21 15:48:17 +0100
commit63710c81db5cda491b879d4865a08569b3692674 (patch)
tree877f8a29e96c825d7b31b4c022620feadc2fac50
parent32b04071470f929acf2923560717e574734ed1f6 (diff)
Update test with long pipelines with "separate" revision setting
-rw-r--r--controller-server/src/main/java/com/yahoo/vespa/hosted/controller/Instance.java2
-rw-r--r--controller-server/src/test/java/com/yahoo/vespa/hosted/controller/deployment/DeploymentTriggerTest.java4
2 files changed, 3 insertions, 3 deletions
diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/Instance.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/Instance.java
index 3fe5240ce34..cc68d47666d 100644
--- a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/Instance.java
+++ b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/Instance.java
@@ -188,7 +188,7 @@ public class Instance {
return change;
}
- /** Returns the application version that last completedd roll-out to this instance. */
+ /** Returns the application version that last rolled out to this instance. */
public Optional<ApplicationVersion> latestDeployed() {
return latestDeployed;
}
diff --git a/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/deployment/DeploymentTriggerTest.java b/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/deployment/DeploymentTriggerTest.java
index cded075a7f3..cd1e12312a8 100644
--- a/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/deployment/DeploymentTriggerTest.java
+++ b/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/deployment/DeploymentTriggerTest.java
@@ -860,6 +860,7 @@ public class DeploymentTriggerTest {
DeploymentContext i4 = tester.newDeploymentContext("t", "a", "i4");
ApplicationPackage applicationPackage = ApplicationPackageBuilder
.fromDeploymentXml("<deployment version='1'>\n" +
+ " <upgrade revision='separate' />\n" +
" <parallel>\n" +
" <instance id='i1'>\n" +
" <prod>\n" +
@@ -944,8 +945,7 @@ public class DeploymentTriggerTest {
tester.clock().advance(Duration.ofHours(3));
// v1 is all done in i1 and i2, but does not yet roll out in i3; v2 is not completely rolled out there yet.
- // TODO jonmv: thie belowh new revision policy, but must be faked for now, as v1 would not wait for v0 to complete.
- //tester.outstandingChangeDeployer().run();
+ tester.outstandingChangeDeployer().run();
assertEquals(v0, i3.instance().change().application());
// i3 completes v0, which rolls out to i4; v1 is ready for i3, but v2 is not.