diff options
author | Henning Baldersheim <balder@yahoo-inc.com> | 2022-02-14 17:04:23 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-02-14 17:04:23 +0100 |
commit | 8a20814df703deaf217b1cbc1611a5dcd9991fcb (patch) | |
tree | 75027cddfddadf3323c2165afac82656e738f3c2 | |
parent | 61b5b8fe5841dab352b9d1678ebb9922dab04122 (diff) | |
parent | e0fcc2871cd1d916a0cc8f1b6f8d6b58b3129f27 (diff) |
Merge pull request #21180 from vespa-engine/bjorncs/improve-logging
Log number of bundles uninstalled
-rw-r--r-- | container-disc/src/main/java/com/yahoo/container/jdisc/component/Deconstructor.java | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/container-disc/src/main/java/com/yahoo/container/jdisc/component/Deconstructor.java b/container-disc/src/main/java/com/yahoo/container/jdisc/component/Deconstructor.java index 3dd1c4c89dc..72ba7240361 100644 --- a/container-disc/src/main/java/com/yahoo/container/jdisc/component/Deconstructor.java +++ b/container-disc/src/main/java/com/yahoo/container/jdisc/component/Deconstructor.java @@ -115,8 +115,8 @@ public class Deconstructor implements ComponentDeconstructor { @Override public void run() { long start = System.currentTimeMillis(); - log.info(String.format("Starting deconstruction of %d old components from graph generation %d", - components.size(), generation)); + log.info(String.format("Starting deconstruction of %d components and %d bundles from generation %d", + components.size(), bundles.size(), generation)); for (var component : components) { log.log(FINE, () -> "Starting deconstruction of " + component); try { @@ -138,7 +138,6 @@ public class Deconstructor implements ComponentDeconstructor { log.log(WARNING, "Non-error not exception throwable thrown when deconstructing component " + component, e); } } - log.info(String.format("Completed deconstruction in %.3f seconds", (System.currentTimeMillis() - start) / 1000D)); // It should now be safe to uninstall the old bundles. for (var bundle : bundles) { try { @@ -148,6 +147,7 @@ public class Deconstructor implements ComponentDeconstructor { log.log(SEVERE, "Could not uninstall bundle " + bundle); } } + log.info(String.format("Completed deconstruction in %.3f seconds", (System.currentTimeMillis() - start) / 1000D)); // NOTE: It could be tempting to refresh packages here, but if active bundles were using any of // the removed ones, they would switch wiring in the middle of a generation's lifespan. // This would happen if the dependent active bundle has not been rebuilt with a new version |