summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJon Marius Venstad <venstad@gmail.com>2022-03-31 17:01:39 +0200
committerJon Marius Venstad <venstad@gmail.com>2022-03-31 17:01:39 +0200
commit3fedd2a808b7a143420ec1b4e3f5debf06dbf2af (patch)
treedc03c69f0945503822f08bf6e863467c8953f80b
parentf52ebfd454eb7b3c334e03b5c0ab47d4cb753e1f (diff)
Move verification down
-rw-r--r--configserver/src/main/java/com/yahoo/vespa/config/server/filedistribution/ApplicationFileManager.java13
1 files changed, 5 insertions, 8 deletions
diff --git a/configserver/src/main/java/com/yahoo/vespa/config/server/filedistribution/ApplicationFileManager.java b/configserver/src/main/java/com/yahoo/vespa/config/server/filedistribution/ApplicationFileManager.java
index ad47f2b9e95..eeb3ad2e7ed 100644
--- a/configserver/src/main/java/com/yahoo/vespa/config/server/filedistribution/ApplicationFileManager.java
+++ b/configserver/src/main/java/com/yahoo/vespa/config/server/filedistribution/ApplicationFileManager.java
@@ -32,19 +32,16 @@ public class ApplicationFileManager implements AddFileInterface {
@Override
public FileReference addFile(String relativePath) throws IOException {
- Path path = Path.of(relativePath).normalize();
- if (path.isAbsolute())
- throw new IllegalArgumentException(relativePath + " is not relative");
File file = new File(applicationDir, relativePath);
- Path relative = applicationDir.toPath().relativize(file.toPath()).normalize();
- if (relative.isAbsolute() || relative.startsWith(".."))
- throw new IllegalArgumentException(file + " is not a descendant of " + applicationDir);
-
- return fileDirectory.addFile(file);
+ return addFile(file);
}
@Override
public FileReference addFile(File file) throws IOException {
+ Path relative = applicationDir.toPath().relativize(file.toPath()).normalize();
+ if (relative.isAbsolute() || relative.startsWith(".."))
+ throw new IllegalArgumentException(file + " is not a descendant of " + applicationDir);
+
return fileDirectory.addFile(file);
}