summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlexey Chernyshev <aleksei@spotify.com>2022-04-11 09:54:02 +0200
committerAlexey Chernyshev <aleksei@spotify.com>2022-04-11 09:54:02 +0200
commit2d80bcbe986aac8ba8a2bb075bf6d601b804e19f (patch)
treed1f4008194e352087bc93c2744b7da62dee5956e
parent7e9b33401201db9a9e22971dd419247e268bbfaa (diff)
Addressed PR comments
-rw-r--r--container-search/src/main/java/com/yahoo/prelude/query/FuzzyItem.java4
-rw-r--r--container-search/src/main/java/com/yahoo/search/query/SelectParser.java4
-rw-r--r--container-search/src/main/java/com/yahoo/search/yql/VespaSerializer.java4
-rw-r--r--container-search/src/main/java/com/yahoo/search/yql/YqlParser.java4
-rw-r--r--container-search/src/test/java/com/yahoo/search/yql/YqlParserTestCase.java4
-rw-r--r--searchlib/src/vespa/searchlib/query/streaming/queryterm.h2
6 files changed, 10 insertions, 12 deletions
diff --git a/container-search/src/main/java/com/yahoo/prelude/query/FuzzyItem.java b/container-search/src/main/java/com/yahoo/prelude/query/FuzzyItem.java
index fda96aa6ecc..b26205b74e9 100644
--- a/container-search/src/main/java/com/yahoo/prelude/query/FuzzyItem.java
+++ b/container-search/src/main/java/com/yahoo/prelude/query/FuzzyItem.java
@@ -17,8 +17,8 @@ public class FuzzyItem extends TermItem {
private int maxEditDistance;
private int prefixLength;
- public static int DefaultMaxEditDistance = 2;
- public static int DefaultPrefixLength = 0;
+ public static int DEFAULT_MAX_EDIT_DISTANCE = 2;
+ public static int DEFAULT_PREFIX_LENGTH = 0;
public FuzzyItem(String indexName, boolean isFromQuery, String term, int maxEditDistance, int prefixLength) {
super(indexName, isFromQuery, null);
diff --git a/container-search/src/main/java/com/yahoo/search/query/SelectParser.java b/container-search/src/main/java/com/yahoo/search/query/SelectParser.java
index c1d1cdd566b..ccf24a13f34 100644
--- a/container-search/src/main/java/com/yahoo/search/query/SelectParser.java
+++ b/container-search/src/main/java/com/yahoo/search/query/SelectParser.java
@@ -1169,8 +1169,8 @@ public class SelectParser implements Parser {
String wordData = children.get(0).asString();
- Integer maxEditDistance = getIntegerAnnotation(MAX_EDIT_DISTANCE, annotations, FuzzyItem.DefaultMaxEditDistance);
- Integer prefixLength = getIntegerAnnotation(PREFIX_LENGTH, annotations, FuzzyItem.DefaultPrefixLength);
+ Integer maxEditDistance = getIntegerAnnotation(MAX_EDIT_DISTANCE, annotations, FuzzyItem.DEFAULT_MAX_EDIT_DISTANCE);
+ Integer prefixLength = getIntegerAnnotation(PREFIX_LENGTH, annotations, FuzzyItem.DEFAULT_PREFIX_LENGTH);
FuzzyItem fuzzy = new FuzzyItem(field, true, wordData, maxEditDistance, prefixLength);
diff --git a/container-search/src/main/java/com/yahoo/search/yql/VespaSerializer.java b/container-search/src/main/java/com/yahoo/search/yql/VespaSerializer.java
index 4b511df5e5f..194863e3129 100644
--- a/container-search/src/main/java/com/yahoo/search/yql/VespaSerializer.java
+++ b/container-search/src/main/java/com/yahoo/search/yql/VespaSerializer.java
@@ -548,8 +548,8 @@ public class VespaSerializer {
}
static String fuzzyAnnotations(FuzzyItem fuzzyItem) {
- boolean isMaxEditDistanceSet = fuzzyItem.getMaxEditDistance() != FuzzyItem.DefaultMaxEditDistance;
- boolean isPrefixLengthSet = fuzzyItem.getPrefixLength() != FuzzyItem.DefaultPrefixLength;
+ boolean isMaxEditDistanceSet = fuzzyItem.getMaxEditDistance() != FuzzyItem.DEFAULT_MAX_EDIT_DISTANCE;
+ boolean isPrefixLengthSet = fuzzyItem.getPrefixLength() != FuzzyItem.DEFAULT_PREFIX_LENGTH;
boolean anyAnnotationSet = isMaxEditDistanceSet || isPrefixLengthSet;
StringBuilder builder = new StringBuilder();
diff --git a/container-search/src/main/java/com/yahoo/search/yql/YqlParser.java b/container-search/src/main/java/com/yahoo/search/yql/YqlParser.java
index fcb19dde10d..19d4e6d41ba 100644
--- a/container-search/src/main/java/com/yahoo/search/yql/YqlParser.java
+++ b/container-search/src/main/java/com/yahoo/search/yql/YqlParser.java
@@ -1322,14 +1322,14 @@ public class YqlParser implements Parser {
ast,
MAX_EDIT_DISTANCE,
Integer.class,
- FuzzyItem.DefaultMaxEditDistance,
+ FuzzyItem.DEFAULT_MAX_EDIT_DISTANCE,
MAX_EDIT_DISTANCE_DESCRIPTION);
Integer prefixLength = getAnnotation(
ast,
PREFIX_LENGTH,
Integer.class,
- FuzzyItem.DefaultPrefixLength,
+ FuzzyItem.DEFAULT_PREFIX_LENGTH,
PREFIX_LENGTH_DESCRIPTION);
FuzzyItem fuzzy = new FuzzyItem(field, true, wordData, maxEditDistance, prefixLength);
diff --git a/container-search/src/test/java/com/yahoo/search/yql/YqlParserTestCase.java b/container-search/src/test/java/com/yahoo/search/yql/YqlParserTestCase.java
index 0ee0597689f..3a6641b0d7a 100644
--- a/container-search/src/test/java/com/yahoo/search/yql/YqlParserTestCase.java
+++ b/container-search/src/test/java/com/yahoo/search/yql/YqlParserTestCase.java
@@ -387,8 +387,8 @@ public class YqlParserTestCase {
assertSame(FuzzyItem.class, root.getClass());
assertEquals("baz", ((FuzzyItem) root).getIndexName());
assertEquals("a b", ((FuzzyItem) root).stringValue());
- assertEquals(FuzzyItem.DefaultMaxEditDistance, ((FuzzyItem) root).getMaxEditDistance());
- assertEquals(FuzzyItem.DefaultPrefixLength, ((FuzzyItem) root).getPrefixLength());
+ assertEquals(FuzzyItem.DEFAULT_MAX_EDIT_DISTANCE, ((FuzzyItem) root).getMaxEditDistance());
+ assertEquals(FuzzyItem.DEFAULT_PREFIX_LENGTH, ((FuzzyItem) root).getPrefixLength());
}
@Test
diff --git a/searchlib/src/vespa/searchlib/query/streaming/queryterm.h b/searchlib/src/vespa/searchlib/query/streaming/queryterm.h
index 34b1b87491e..af32458c5da 100644
--- a/searchlib/src/vespa/searchlib/query/streaming/queryterm.h
+++ b/searchlib/src/vespa/searchlib/query/streaming/queryterm.h
@@ -87,8 +87,6 @@ public:
const string & getIndex() const override { return _index; }
void setFuzzyMaxEditDistance(uint32_t fuzzyMaxEditDistance) { _fuzzyMaxEditDistance = fuzzyMaxEditDistance; }
void setFuzzyPrefixLength(uint32_t fuzzyPrefixLength) { _fuzzyPrefixLength = fuzzyPrefixLength; }
- uint32_t fuzzyMaxEditDistance() const { return _fuzzyMaxEditDistance; }
- uint32_t fuzzyPrefixLength() const { return _fuzzyPrefixLength; }
protected:
using QueryNodeResultBaseContainer = std::unique_ptr<QueryNodeResultBase>;
string _index;