summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHarald Musum <musum@verizonmedia.com>2022-04-26 17:09:14 +0200
committerGitHub <noreply@github.com>2022-04-26 17:09:14 +0200
commitf0d08caea0f409966e8e3024427c7a606acce052 (patch)
tree4b4a212dc159e2b5d228ed7db338bf150769721f
parent336734130c0ab058f83731561d416c510beb0720 (diff)
parent15a469346f34be94722cbcb4092f360f642f361c (diff)
Merge pull request #22279 from vespa-engine/hmusum/use-failDeploymentWithInvalidJvmOptions-for-hosted-only
Use failDeploymentWithInvalidJvmOptions only for hosted
-rw-r--r--config-model/src/main/java/com/yahoo/vespa/model/container/xml/ContainerModelBuilder.java4
1 files changed, 2 insertions, 2 deletions
diff --git a/config-model/src/main/java/com/yahoo/vespa/model/container/xml/ContainerModelBuilder.java b/config-model/src/main/java/com/yahoo/vespa/model/container/xml/ContainerModelBuilder.java
index 47519853ed0..ff1a4b6cc5f 100644
--- a/config-model/src/main/java/com/yahoo/vespa/model/container/xml/ContainerModelBuilder.java
+++ b/config-model/src/main/java/com/yahoo/vespa/model/container/xml/ContainerModelBuilder.java
@@ -1184,7 +1184,7 @@ public class ContainerModelBuilder extends ConfigModelBuilder<ContainerModel> {
String message = "Invalid or misplaced JVM options in services.xml: " +
String.join(",", invalidOptions) + "." +
" See https://docs.vespa.ai/en/reference/services-container.html#jvm";
- if (failDeploymentWithInvalidJvmOptions)
+ if (failDeploymentWithInvalidJvmOptions && isHosted)
throw new IllegalArgumentException(message);
else
logger.logApplicationPackage(WARNING, message);
@@ -1250,7 +1250,7 @@ public class ContainerModelBuilder extends ConfigModelBuilder<ContainerModel> {
String message = "Invalid or misplaced JVM GC options in services.xml: " +
String.join(",", options) + "." +
" See https://docs.vespa.ai/en/reference/services-container.html#jvm";
- if (failDeploymentWithInvalidJvmOptions)
+ if (failDeploymentWithInvalidJvmOptions && isHosted)
throw new IllegalArgumentException(message);
else
logger.logApplicationPackage(WARNING, message);