summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2022-12-21 18:37:54 +0100
committerGitHub <noreply@github.com>2022-12-21 18:37:54 +0100
commita736bb0912f680bbb39396934ca9bbd0b921fde8 (patch)
tree6427f2edafc9ea2501cc0636e067115f5dc9aff4
parent541a88143878c25d771a6878376ef66416d54102 (diff)
parenta30a19e95b7e37e5f8ed4ecbdb4067411b06548b (diff)
Merge pull request #25323 from vespa-engine/balder/move-close-prior-to-join
Move close() call up between interrupt() and join().
-rw-r--r--storage/src/vespa/storage/persistence/filestorage/filestormanager.cpp5
1 files changed, 3 insertions, 2 deletions
diff --git a/storage/src/vespa/storage/persistence/filestorage/filestormanager.cpp b/storage/src/vespa/storage/persistence/filestorage/filestormanager.cpp
index 49b3b02e240..b67e4851473 100644
--- a/storage/src/vespa/storage/persistence/filestorage/filestormanager.cpp
+++ b/storage/src/vespa/storage/persistence/filestorage/filestormanager.cpp
@@ -105,13 +105,14 @@ FileStorManager::~FileStorManager()
thread->getThread().interrupt();
}
}
+ LOG(debug, "Closing all filestor queues, answering queued messages. New messages will be refused.");
+ _filestorHandler->close();
for (const auto & thread : _threads) {
if (thread) {
thread->getThread().join();
}
}
- LOG(debug, "Closing all filestor queues, answering queued messages. New messages will be refused.");
- _filestorHandler->close();
+
LOG(debug, "Deleting filestor threads. Waiting for their current operation "
"to finish. Stop their threads and delete objects.");
_threads.clear();