diff options
author | HÃ¥vard Pettersen <3535158+havardpe@users.noreply.github.com> | 2021-10-11 10:48:36 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-10-11 10:48:36 +0200 |
commit | 0df7964c882d9b22ab99cfa8645afb8ca5b96ba0 (patch) | |
tree | 85b838ed1fe40f0b376125bef05e53b4ebd831e8 | |
parent | b96801ba355506890fbd16d7b1270d09746911ef (diff) | |
parent | a16c551ff5ba407cdd8c4d7136f0a15ef0f3d078 (diff) |
Merge pull request #19500 from vespa-engine/arnej/reapply-actual-reporting
Revert "wait with actual reporting until we want errors"
-rw-r--r-- | searchcore/src/vespa/searchcore/grouping/groupingmanager.cpp | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/searchcore/src/vespa/searchcore/grouping/groupingmanager.cpp b/searchcore/src/vespa/searchcore/grouping/groupingmanager.cpp index 863511da5ee..42c5d16162e 100644 --- a/searchcore/src/vespa/searchcore/grouping/groupingmanager.cpp +++ b/searchcore/src/vespa/searchcore/grouping/groupingmanager.cpp @@ -61,12 +61,7 @@ GroupingManager::init(const IAttributeContext &attrCtx) list.push_back(groupingList[i]); } catch (const std::exception & e) { auto msg = fmt("Could not locate attribute for grouping number %ld : %s. Ignoring grouping '%s'", i, e.what(), grouping.asString().c_str()); - // - // NOTE: if this issue is reported as an error in the - // search reply, the grouping searcher will discard all - // grouping results, which may or may not be what we want. - // - // Issue::report(msg); + Issue::report(msg); LOG(error, "%s", msg.c_str()); } } |