diff options
author | Henning Baldersheim <balder@yahoo-inc.com> | 2023-03-22 17:05:49 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-03-22 17:05:49 +0100 |
commit | 75f3408bf3cae9b2e11bfcafbdfd65f8066695f4 (patch) | |
tree | 18eb90e394dd4a14c043ae344e793ef1ddfd4b39 | |
parent | 03191bd6acb12a645b6e387e8e667d148d4a1fa3 (diff) | |
parent | 62ea7837b3b15894198e55e10c646b647cef6fbb (diff) |
Merge pull request #26539 from vespa-engine/balder/one-doc-is-also-ok
It is enough to have a single document to verify that the corpus is OK.
-rw-r--r-- | container-search/src/main/java/com/yahoo/search/result/Coverage.java | 3 | ||||
-rw-r--r-- | container-search/src/test/java/com/yahoo/search/result/CoverageTestCase.java | 12 |
2 files changed, 14 insertions, 1 deletions
diff --git a/container-search/src/main/java/com/yahoo/search/result/Coverage.java b/container-search/src/main/java/com/yahoo/search/result/Coverage.java index 390c6ec4435..cd0e5acc96a 100644 --- a/container-search/src/main/java/com/yahoo/search/result/Coverage.java +++ b/container-search/src/main/java/com/yahoo/search/result/Coverage.java @@ -10,7 +10,8 @@ package com.yahoo.search.result; public class Coverage extends com.yahoo.container.handler.Coverage { public Coverage(long docs, long active) { - this(docs, active, docs > 1 ? 1 : 0, docs > 1 ? 1: 0); + // TODO Wonder about this special handling..... + this(docs, active, (docs > 0) ? 1 : 0, (docs > 0) ? 1: 0); } public Coverage(long docs, long active, int nodes) { diff --git a/container-search/src/test/java/com/yahoo/search/result/CoverageTestCase.java b/container-search/src/test/java/com/yahoo/search/result/CoverageTestCase.java index 4d521e3e8b4..1bbca461216 100644 --- a/container-search/src/test/java/com/yahoo/search/result/CoverageTestCase.java +++ b/container-search/src/test/java/com/yahoo/search/result/CoverageTestCase.java @@ -90,4 +90,16 @@ public class CoverageTestCase { verifyCoverageConversion(new Coverage(6, 10).setDegradedReason(7).setTargetActive(12)); } + @Test + void testCoverageWorksForCorpusAboveZero() { + Coverage zero = new Coverage(0, 0); + assertEquals(0, zero.getNodes()); // TODO Wonder about this special handling..... + assertEquals(0, zero.getFullResultSets()); + for (int i =1; i < 10; i++) { + Coverage coverage = new Coverage(i, i); + assertEquals(1, coverage.getNodes()); + verifyCoverageConversion(coverage); + } + } + } |