summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMartin Polden <mpolden@mpolden.no>2018-09-19 09:04:49 +0200
committerGitHub <noreply@github.com>2018-09-19 09:04:49 +0200
commit4d6acff9649baf0f7ed8468624b181fcbf3ffeb7 (patch)
treec7a9f4455cf2c5748cc2eb6bdfa28fad113bceeb
parent8160a58083d1d2dbb2dd40b7c9579e761a1bfd40 (diff)
parent13ecac15646d53760a9267b3a98bc3fc12dab74f (diff)
Merge pull request #7000 from vespa-engine/hmusum/check-config-generation-in-parallel
Check service config generations in parallel
-rw-r--r--configserver/src/main/java/com/yahoo/vespa/config/server/ApplicationRepository.java4
-rw-r--r--configserver/src/main/java/com/yahoo/vespa/config/server/application/ConfigConvergenceChecker.java6
2 files changed, 5 insertions, 5 deletions
diff --git a/configserver/src/main/java/com/yahoo/vespa/config/server/ApplicationRepository.java b/configserver/src/main/java/com/yahoo/vespa/config/server/ApplicationRepository.java
index 6c67f730f60..3e11637b801 100644
--- a/configserver/src/main/java/com/yahoo/vespa/config/server/ApplicationRepository.java
+++ b/configserver/src/main/java/com/yahoo/vespa/config/server/ApplicationRepository.java
@@ -477,8 +477,8 @@ public class ApplicationRepository implements com.yahoo.config.provision.Deploye
return convergeChecker.checkService(getApplication(applicationId), hostAndPort, uri, timeout);
}
- public HttpResponse servicesToCheckForConfigConvergence(ApplicationId applicationId, URI uri, Duration timeout) {
- return convergeChecker.servicesToCheck(getApplication(applicationId), uri, timeout);
+ public HttpResponse servicesToCheckForConfigConvergence(ApplicationId applicationId, URI uri, Duration timeoutPerService) {
+ return convergeChecker.servicesToCheck(getApplication(applicationId), uri, timeoutPerService);
}
// ---------------- Logs ----------------------------------------------------------------
diff --git a/configserver/src/main/java/com/yahoo/vespa/config/server/application/ConfigConvergenceChecker.java b/configserver/src/main/java/com/yahoo/vespa/config/server/application/ConfigConvergenceChecker.java
index 0f507624188..113b57328a3 100644
--- a/configserver/src/main/java/com/yahoo/vespa/config/server/application/ConfigConvergenceChecker.java
+++ b/configserver/src/main/java/com/yahoo/vespa/config/server/application/ConfigConvergenceChecker.java
@@ -60,7 +60,7 @@ public class ConfigConvergenceChecker extends AbstractComponent {
this.stateApiFactory = stateApiFactory;
}
- /** Check all services in given application */
+ /** Check all services in given application. Returns the minimum current generation of all services */
public ServiceListResponse servicesToCheck(Application application, URI requestUrl, Duration timeoutPerService) {
List<ServiceInfo> servicesToCheck = new ArrayList<>();
application.getModel().getHosts()
@@ -102,9 +102,9 @@ public class ConfigConvergenceChecker extends AbstractComponent {
StateApi createStateApi(Client client, URI serviceUri);
}
- /** Get service generation for a list of services. Returns the minimum generation of all services */
+ /** Gets service generation for a list of services (in parallel). */
private Map<ServiceInfo, Long> getServiceGenerations(List<ServiceInfo> services, Duration timeout) {
- return services.stream()
+ return services.parallelStream()
.collect(Collectors.toMap(service -> service,
service -> {
try {