summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2022-11-29 16:45:12 +0100
committerHenning Baldersheim <balder@yahoo-inc.com>2022-11-29 16:45:12 +0100
commitdeaac2672dbf627a319b7ebaba808e7918bd0186 (patch)
treea019ca1c748cb00c3b77d2569a92915363e27e22
parent7fbfecba694f1665d5c00bd504086a49898f8bb2 (diff)
Reduce exposure of com.yahoo.jdisc.http.HttpRequest.
-rw-r--r--container-core/src/main/java/com/yahoo/container/jdisc/HttpRequest.java6
-rw-r--r--container-core/src/main/java/com/yahoo/container/jdisc/ThreadedHttpRequestHandler.java5
-rw-r--r--container-search/src/main/java/com/yahoo/search/Query.java2
-rw-r--r--vespaclient-core/src/main/java/com/yahoo/feedhandler/InputStreamRequest.java4
4 files changed, 10 insertions, 7 deletions
diff --git a/container-core/src/main/java/com/yahoo/container/jdisc/HttpRequest.java b/container-core/src/main/java/com/yahoo/container/jdisc/HttpRequest.java
index d5ac3a9a124..39f55cedff5 100644
--- a/container-core/src/main/java/com/yahoo/container/jdisc/HttpRequest.java
+++ b/container-core/src/main/java/com/yahoo/container/jdisc/HttpRequest.java
@@ -23,6 +23,7 @@ import java.util.List;
import java.util.Map;
import java.util.Objects;
import java.util.Optional;
+import java.util.concurrent.TimeUnit;
import static com.yahoo.jdisc.http.HttpRequest.Method;
@@ -454,6 +455,11 @@ public class HttpRequest {
return parentRequest;
}
+ /** Returns the time at which this Request was created. */
+ public long creationTime(TimeUnit unit) {
+ return parentRequest.creationTime(unit);
+ }
+
/**
* Returns the value of a request property/parameter.
* Multi-value properties are not supported.
diff --git a/container-core/src/main/java/com/yahoo/container/jdisc/ThreadedHttpRequestHandler.java b/container-core/src/main/java/com/yahoo/container/jdisc/ThreadedHttpRequestHandler.java
index fb7ba1ab39e..06d372c967c 100644
--- a/container-core/src/main/java/com/yahoo/container/jdisc/ThreadedHttpRequestHandler.java
+++ b/container-core/src/main/java/com/yahoo/container/jdisc/ThreadedHttpRequestHandler.java
@@ -79,14 +79,13 @@ public abstract class ThreadedHttpRequestHandler extends ThreadedRequestHandler
@Override
public final void handleRequest(Request request, BufferedContentChannel requestContent, ResponseHandler responseHandler) {
log.log(Level.FINE, () -> "In " + this.getClass() + ".handleRequest()");
- com.yahoo.jdisc.http.HttpRequest jdiscRequest = asHttpRequest(request);
- HttpRequest httpRequest = new HttpRequest(jdiscRequest, new UnsafeContentInputStream(requestContent.toReadable()));
+ HttpRequest httpRequest = new HttpRequest(asHttpRequest(request), new UnsafeContentInputStream(requestContent.toReadable()));
LazyContentChannel channel = null;
try {
channel = new LazyContentChannel(httpRequest, responseHandler, metric, log);
HttpResponse httpResponse = handle(httpRequest, channel);
channel.setHttpResponse(httpResponse); // may or may not have already been done
- render(httpRequest, httpResponse, channel, jdiscRequest.creationTime(TimeUnit.MILLISECONDS));
+ render(httpRequest, httpResponse, channel, httpRequest.creationTime(TimeUnit.MILLISECONDS));
} catch (Exception e) {
metric.add(UNHANDLED_EXCEPTIONS_METRIC, 1L, contextFor(request, Map.of("exception", e.getClass().getSimpleName())));
metric.add(RENDERING_ERRORS, 1, null);
diff --git a/container-search/src/main/java/com/yahoo/search/Query.java b/container-search/src/main/java/com/yahoo/search/Query.java
index dc9609f2d0d..f38e4d4d1cd 100644
--- a/container-search/src/main/java/com/yahoo/search/Query.java
+++ b/container-search/src/main/java/com/yahoo/search/Query.java
@@ -362,7 +362,7 @@ public class Query extends com.yahoo.processing.Request implements Cloneable {
Map<String, Embedder> embedders,
ZoneInfo zoneInfo,
SchemaInfo schemaInfo) {
- startTime = httpRequest.getJDiscRequest().creationTime(TimeUnit.MILLISECONDS);
+ startTime = httpRequest.creationTime(TimeUnit.MILLISECONDS);
if (queryProfile != null) {
// Move all request parameters to the query profile
Properties queryProfileProperties = new QueryProfileProperties(queryProfile, embedders, zoneInfo);
diff --git a/vespaclient-core/src/main/java/com/yahoo/feedhandler/InputStreamRequest.java b/vespaclient-core/src/main/java/com/yahoo/feedhandler/InputStreamRequest.java
index a62ecbd55ec..c29d6582ea7 100644
--- a/vespaclient-core/src/main/java/com/yahoo/feedhandler/InputStreamRequest.java
+++ b/vespaclient-core/src/main/java/com/yahoo/feedhandler/InputStreamRequest.java
@@ -6,9 +6,7 @@ import java.util.HashMap;
import java.util.Map;
/**
- * This is needed because whoever wrote this library moronically decided to pass in-process communication through
- * the HTTP layer. As the feeded is being phased out in favor of the standalone HTTP client we don't bother to clean
- * it up properly.
+ * Simple wrapper of a stream and some properties.
*
* @author bratseth
*/