summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2023-06-26 13:03:59 +0200
committerGitHub <noreply@github.com>2023-06-26 13:03:59 +0200
commit0c341f8ed39b3edcd1938d964cbdf9ce7c179411 (patch)
tree583b92e8a1fe44f03e5c00a9077f7815d7af600c
parentff5a90c08f10d4d02dc5eb9a04efbaf14e0d59d5 (diff)
parent9d5b0b219936970665867c09a5e4601ac7fd27c3 (diff)
Merge pull request #27543 from vespa-engine/balder/expose-niceness-tuning
Expose tuning of niceness.
-rw-r--r--config-model/src/main/java/com/yahoo/vespa/model/builder/xml/dom/DomSearchTuningBuilder.java2
-rw-r--r--config-model/src/main/java/com/yahoo/vespa/model/search/Tuning.java4
-rw-r--r--config-model/src/main/resources/schema/content.rnc3
-rw-r--r--config-model/src/test/java/com/yahoo/vespa/model/builder/xml/dom/DomSchemaTuningBuilderTest.java6
4 files changed, 13 insertions, 2 deletions
diff --git a/config-model/src/main/java/com/yahoo/vespa/model/builder/xml/dom/DomSearchTuningBuilder.java b/config-model/src/main/java/com/yahoo/vespa/model/builder/xml/dom/DomSearchTuningBuilder.java
index 64592e75c41..a0a4151daf5 100644
--- a/config-model/src/main/java/com/yahoo/vespa/model/builder/xml/dom/DomSearchTuningBuilder.java
+++ b/config-model/src/main/java/com/yahoo/vespa/model/builder/xml/dom/DomSearchTuningBuilder.java
@@ -298,6 +298,8 @@ public class DomSearchTuningBuilder extends VespaDomBuilder.DomConfigProducerBui
for (Element e : XML.getChildren(spec)) {
if (equals("concurrency", e)) {
sn.feeding.concurrency = asDouble(e);
+ } else if (equals("niceness", e)) {
+ sn.feeding.niceness = asDouble(e);
}
}
}
diff --git a/config-model/src/main/java/com/yahoo/vespa/model/search/Tuning.java b/config-model/src/main/java/com/yahoo/vespa/model/search/Tuning.java
index 93e3a6e7a19..83eccc8697c 100644
--- a/config-model/src/main/java/com/yahoo/vespa/model/search/Tuning.java
+++ b/config-model/src/main/java/com/yahoo/vespa/model/search/Tuning.java
@@ -371,12 +371,16 @@ public class Tuning extends AnyConfigProducer implements ProtonConfig.Producer {
public static class Feeding implements ProtonConfig.Producer {
public Double concurrency = null;
+ public Double niceness = null;
@Override
public void getConfig(ProtonConfig.Builder builder) {
if (concurrency != null) {
builder.feeding.concurrency(concurrency);
}
+ if (niceness != null) {
+ builder.feeding.niceness(niceness);
+ }
}
}
diff --git a/config-model/src/main/resources/schema/content.rnc b/config-model/src/main/resources/schema/content.rnc
index 5833b575a74..a73236454c6 100644
--- a/config-model/src/main/resources/schema/content.rnc
+++ b/config-model/src/main/resources/schema/content.rnc
@@ -370,7 +370,8 @@ Tuning = element tuning {
element threads { xsd:nonNegativeInteger }?
}? &
element feeding {
- element concurrency { xsd:double { minInclusive = "0.0" maxInclusive = "1.0" } }?
+ element concurrency { xsd:double { minInclusive = "0.0" maxInclusive = "1.0" } }? &
+ element niceness { xsd:double { minInclusive = "0.0" maxInclusive = "1.0" } }?
}? &
element removed-db {
element prune {
diff --git a/config-model/src/test/java/com/yahoo/vespa/model/builder/xml/dom/DomSchemaTuningBuilderTest.java b/config-model/src/test/java/com/yahoo/vespa/model/builder/xml/dom/DomSchemaTuningBuilderTest.java
index e3e9fc1a232..db15d7e0a78 100644
--- a/config-model/src/test/java/com/yahoo/vespa/model/builder/xml/dom/DomSchemaTuningBuilderTest.java
+++ b/config-model/src/test/java/com/yahoo/vespa/model/builder/xml/dom/DomSchemaTuningBuilderTest.java
@@ -285,9 +285,13 @@ public class DomSchemaTuningBuilderTest extends DomBuilderTest {
void requireThatWeCanParseFeedingTag() {
Tuning t = createTuning(parseXml("<feeding>",
"<concurrency>0.7</concurrency>",
+ "<niceness>0.3</niceness>",
"</feeding>"));
assertEquals(0.7, t.searchNode.feeding.concurrency, DELTA);
- assertEquals(getProtonCfg(t).feeding().concurrency(), 0.7, DELTA);
+ assertEquals(0.3, t.searchNode.feeding.niceness, DELTA);
+ var cfg = getProtonCfg(t);
+ assertEquals(cfg.feeding().concurrency(), 0.7, DELTA);
+ assertEquals(cfg.feeding().niceness(), 0.3, DELTA);
}
}