summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2023-06-23 17:55:32 +0000
committerHenning Baldersheim <balder@yahoo-inc.com>2023-06-26 13:55:54 +0000
commitfe9d7ea9bcb152e0522e35a4281a759351f03b2c (patch)
tree60bd9a98ddf17650f6e6f14277a42fc5c1f37a3d
parent0252aee2a195a8462a0e12d505b682acc019db81 (diff)
Avoid double negation to improve readability.
-rw-r--r--searchcore/src/vespa/searchcore/proton/matching/matcher.cpp8
1 files changed, 4 insertions, 4 deletions
diff --git a/searchcore/src/vespa/searchcore/proton/matching/matcher.cpp b/searchcore/src/vespa/searchcore/proton/matching/matcher.cpp
index 28da6013edb..800d0d0aed8 100644
--- a/searchcore/src/vespa/searchcore/proton/matching/matcher.cpp
+++ b/searchcore/src/vespa/searchcore/proton/matching/matcher.cpp
@@ -86,9 +86,9 @@ private:
};
bool
-willNotNeedRanking(const SearchRequest & request, const GroupingContext & groupingContext) {
- return (!groupingContext.needRanking() && (request.maxhits == 0))
- || (!request.sortSpec.empty() && (request.sortSpec.find("[rank]") == vespalib::string::npos));
+willNeedRanking(const SearchRequest & request, const GroupingContext & groupingContext) {
+ return (groupingContext.needRanking() || (request.maxhits != 0))
+ && (request.sortSpec.empty() || (request.sortSpec.find("[rank]") != vespalib::string::npos));
}
SearchReply::UP
@@ -244,7 +244,7 @@ Matcher::match(const SearchRequest &request, vespalib::ThreadBundle &threadBundl
MatchParams params(searchContext.getDocIdLimit(), heapSize, arraySize, rank_score_drop_limit,
request.offset, request.maxhits, !_rankSetup->getSecondPhaseRank().empty(),
- !willNotNeedRanking(request, groupingContext));
+ willNeedRanking(request, groupingContext));
ResultProcessor rp(attrContext, metaStore, sessionMgr, groupingContext, sessionId,
request.sortSpec, params.offset, params.hits);