summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHarald Musum <musum@verizonmedia.com>2021-01-12 07:31:45 +0100
committerGitHub <noreply@github.com>2021-01-12 07:31:45 +0100
commitfd2f34e195784c33efd3256dc8260665457ec2c7 (patch)
treea67473028c3dd97151689027c8456297b6c31023
parent6d5b7bb9cff88d5030a606082b703a2c706e0747 (diff)
parent50f8720f85172080d188f086d9b57074fd6d7a1b (diff)
Merge pull request #15995 from vespa-engine/revert-15992-revert-15988-bjorncs/connection-access-log-preps
Revert "Revert "Merge container-accesslogging into jdisc_http_service"" [run-systemtest]
-rw-r--r--CMakeLists.txt2
-rw-r--r--cloud-tenant-base-dependencies-enforcer/pom.xml2
-rw-r--r--container-accesslogging/CMakeLists.txt2
-rw-r--r--container-accesslogging/OWNERS1
-rw-r--r--container-accesslogging/README.md4
-rw-r--r--container-accesslogging/pom.xml97
-rw-r--r--container-core-config/CMakeLists.txt2
-rw-r--r--container-core-config/OWNERS1
-rw-r--r--container-core-config/README.md7
-rw-r--r--container-core-config/pom.xml48
-rw-r--r--container-core-config/src/main/java/com/yahoo/container/core/package-info.java5
-rw-r--r--container-core-config/src/main/resources/configdefinitions/container.core.access-log.def (renamed from container-accesslogging/src/main/resources/configdefinitions/container.core.access-log.def)2
-rw-r--r--container-core/pom.xml11
-rw-r--r--container-search/pom.xml6
-rw-r--r--jdisc_http_service/pom.xml18
-rw-r--r--jdisc_http_service/src/main/java/com/yahoo/container/logging/AccessLog.java (renamed from container-accesslogging/src/main/java/com/yahoo/container/logging/AccessLog.java)0
-rw-r--r--jdisc_http_service/src/main/java/com/yahoo/container/logging/AccessLogEntry.java (renamed from container-accesslogging/src/main/java/com/yahoo/container/logging/AccessLogEntry.java)0
-rw-r--r--jdisc_http_service/src/main/java/com/yahoo/container/logging/AccessLogHandler.java (renamed from container-accesslogging/src/main/java/com/yahoo/container/logging/AccessLogHandler.java)0
-rw-r--r--jdisc_http_service/src/main/java/com/yahoo/container/logging/AccessLogInterface.java (renamed from container-accesslogging/src/main/java/com/yahoo/container/logging/AccessLogInterface.java)0
-rw-r--r--jdisc_http_service/src/main/java/com/yahoo/container/logging/AccessLogSampler.java (renamed from container-accesslogging/src/main/java/com/yahoo/container/logging/AccessLogSampler.java)0
-rw-r--r--jdisc_http_service/src/main/java/com/yahoo/container/logging/CircularArrayAccessLogKeeper.java (renamed from container-accesslogging/src/main/java/com/yahoo/container/logging/CircularArrayAccessLogKeeper.java)0
-rw-r--r--jdisc_http_service/src/main/java/com/yahoo/container/logging/Coverage.java (renamed from container-accesslogging/src/main/java/com/yahoo/container/logging/Coverage.java)0
-rw-r--r--jdisc_http_service/src/main/java/com/yahoo/container/logging/HitCounts.java (renamed from container-accesslogging/src/main/java/com/yahoo/container/logging/HitCounts.java)0
-rw-r--r--jdisc_http_service/src/main/java/com/yahoo/container/logging/JSONAccessLog.java (renamed from container-accesslogging/src/main/java/com/yahoo/container/logging/JSONAccessLog.java)0
-rw-r--r--jdisc_http_service/src/main/java/com/yahoo/container/logging/JSONFormatter.java (renamed from container-accesslogging/src/main/java/com/yahoo/container/logging/JSONFormatter.java)0
-rw-r--r--jdisc_http_service/src/main/java/com/yahoo/container/logging/LogFileHandler.java (renamed from container-accesslogging/src/main/java/com/yahoo/container/logging/LogFileHandler.java)0
-rw-r--r--jdisc_http_service/src/main/java/com/yahoo/container/logging/LogFormatter.java (renamed from container-accesslogging/src/main/java/com/yahoo/container/logging/LogFormatter.java)0
-rw-r--r--jdisc_http_service/src/main/java/com/yahoo/container/logging/TraceRenderer.java (renamed from container-accesslogging/src/main/java/com/yahoo/container/logging/TraceRenderer.java)0
-rw-r--r--jdisc_http_service/src/main/java/com/yahoo/container/logging/VespaAccessLog.java (renamed from container-accesslogging/src/main/java/com/yahoo/container/logging/VespaAccessLog.java)0
-rw-r--r--jdisc_http_service/src/main/java/com/yahoo/container/logging/package-info.java (renamed from container-accesslogging/src/main/java/com/yahoo/container/logging/package-info.java)0
-rw-r--r--jdisc_http_service/src/test/java/com/yahoo/container/logging/AccessLogSamplerTest.java (renamed from container-accesslogging/src/test/java/com/yahoo/container/logging/AccessLogSamplerTest.java)1
-rw-r--r--jdisc_http_service/src/test/java/com/yahoo/container/logging/CircularArrayAccessLogKeeperTest.java (renamed from container-accesslogging/src/test/java/com/yahoo/container/logging/CircularArrayAccessLogKeeperTest.java)0
-rw-r--r--jdisc_http_service/src/test/java/com/yahoo/container/logging/CompressWhileDrop.java (renamed from container-accesslogging/src/test/java/com/yahoo/container/logging/CompressWhileDrop.java)0
-rw-r--r--jdisc_http_service/src/test/java/com/yahoo/container/logging/JSONLogTestCase.java (renamed from container-accesslogging/src/test/java/com/yahoo/container/logging/JSONLogTestCase.java)0
-rw-r--r--jdisc_http_service/src/test/java/com/yahoo/container/logging/LogFileHandlerTestCase.java (renamed from container-accesslogging/src/test/java/com/yahoo/container/logging/LogFileHandlerTestCase.java)0
-rw-r--r--jdisc_http_service/src/test/java/com/yahoo/container/logging/test/LogFormatterTestCase.java (renamed from container-accesslogging/src/test/java/com/yahoo/container/logging/test/LogFormatterTestCase.java)4
-rw-r--r--pom.xml2
37 files changed, 90 insertions, 125 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt
index aadd31ec2b9..d3621de617a 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -60,8 +60,8 @@ add_subdirectory(configgen)
add_subdirectory(configserver)
add_subdirectory(configserver-flags)
add_subdirectory(configutil)
-add_subdirectory(container-accesslogging)
add_subdirectory(container-core)
+add_subdirectory(container-core-config)
add_subdirectory(container-di)
add_subdirectory(container-disc)
add_subdirectory(container-jersey2)
diff --git a/cloud-tenant-base-dependencies-enforcer/pom.xml b/cloud-tenant-base-dependencies-enforcer/pom.xml
index 414039ac492..a8655a82860 100644
--- a/cloud-tenant-base-dependencies-enforcer/pom.xml
+++ b/cloud-tenant-base-dependencies-enforcer/pom.xml
@@ -145,8 +145,8 @@
<include>com.yahoo.vespa:config:*:jar:provided</include>
<include>com.yahoo.vespa:configdefinitions:*:jar:provided</include>
<include>com.yahoo.vespa:configgen:*:jar:provided</include>
- <include>com.yahoo.vespa:container-accesslogging:*:jar:provided</include>
<include>com.yahoo.vespa:container-core:*:jar:provided</include>
+ <include>com.yahoo.vespa:container-core-config:*:jar:provided</include>
<include>com.yahoo.vespa:container-dev:*:jar:provided</include>
<include>com.yahoo.vespa:container-di:*:jar:provided</include>
<include>com.yahoo.vespa:container-disc:*:jar:provided</include>
diff --git a/container-accesslogging/CMakeLists.txt b/container-accesslogging/CMakeLists.txt
deleted file mode 100644
index 7bb25e6a420..00000000000
--- a/container-accesslogging/CMakeLists.txt
+++ /dev/null
@@ -1,2 +0,0 @@
-# Copyright 2017 Yahoo Holdings. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
-install_config_definitions()
diff --git a/container-accesslogging/OWNERS b/container-accesslogging/OWNERS
deleted file mode 100644
index 569bf1cc3a1..00000000000
--- a/container-accesslogging/OWNERS
+++ /dev/null
@@ -1 +0,0 @@
-bjorncs
diff --git a/container-accesslogging/README.md b/container-accesslogging/README.md
deleted file mode 100644
index 1d5b7d140e9..00000000000
--- a/container-accesslogging/README.md
+++ /dev/null
@@ -1,4 +0,0 @@
-<!-- Copyright 2017 Yahoo Holdings. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root. -->
-# Access logging for JDisc
-
-Contains various access log implementations for JDisc.
diff --git a/container-accesslogging/pom.xml b/container-accesslogging/pom.xml
deleted file mode 100644
index ba544e04fc8..00000000000
--- a/container-accesslogging/pom.xml
+++ /dev/null
@@ -1,97 +0,0 @@
-<?xml version="1.0"?>
-<!-- Copyright 2017 Yahoo Holdings. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root. -->
-<project xmlns="http://maven.apache.org/POM/4.0.0"
- xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
- http://maven.apache.org/xsd/maven-4.0.0.xsd">
- <modelVersion>4.0.0</modelVersion>
- <parent>
- <groupId>com.yahoo.vespa</groupId>
- <artifactId>parent</artifactId>
- <version>7-SNAPSHOT</version>
- <relativePath>../parent/pom.xml</relativePath>
- </parent>
- <artifactId>container-accesslogging</artifactId>
- <version>7-SNAPSHOT</version>
- <packaging>container-plugin</packaging>
- <dependencies>
- <dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <scope>test</scope>
- </dependency>
- <dependency>
- <groupId>com.google.inject</groupId>
- <artifactId>guice</artifactId>
- <scope>provided</scope>
- <classifier>no_aop</classifier>
- </dependency>
- <dependency>
- <groupId>com.yahoo.vespa</groupId>
- <artifactId>component</artifactId>
- <version>${project.version}</version>
- <scope>provided</scope>
- </dependency>
- <dependency>
- <groupId>com.yahoo.vespa</groupId>
- <artifactId>config-bundle</artifactId>
- <version>${project.version}</version>
- <scope>provided</scope>
- </dependency>
- <dependency>
- <groupId>com.yahoo.vespa</groupId>
- <artifactId>config-lib</artifactId>
- <version>${project.version}</version>
- <scope>provided</scope>
- </dependency>
- <dependency>
- <groupId>com.yahoo.vespa</groupId>
- <artifactId>vespajlib</artifactId>
- <version>${project.version}</version>
- <scope>provided</scope>
- </dependency>
- <dependency>
- <groupId>com.yahoo.vespa</groupId>
- <artifactId>vespalog</artifactId>
- <version>${project.version}</version>
- <scope>provided</scope>
- </dependency>
- <dependency>
- <groupId>org.hamcrest</groupId>
- <artifactId>hamcrest-all</artifactId>
- <scope>test</scope>
- </dependency>
- <dependency>
- <groupId>com.fasterxml.jackson.core</groupId>
- <artifactId>jackson-core</artifactId>
- <scope>provided</scope>
- </dependency>
- <dependency>
- <groupId>com.fasterxml.jackson.core</groupId>
- <artifactId>jackson-databind</artifactId>
- <scope>provided</scope>
- </dependency>
- <dependency>
- <groupId>org.assertj</groupId>
- <artifactId>assertj-core</artifactId>
- <scope>test</scope>
- </dependency>
- </dependencies>
- <build>
- <plugins>
- <plugin>
- <groupId>com.yahoo.vespa</groupId>
- <artifactId>bundle-plugin</artifactId>
- <extensions>true</extensions>
- </plugin>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-compiler-plugin</artifactId>
- </plugin>
- </plugins>
- <outputDirectory>${buildOutputDirectory}</outputDirectory>
- </build>
- <properties>
- <buildOutputDirectory>${project.build.directory}/classes/</buildOutputDirectory>
- </properties>
-</project>
diff --git a/container-core-config/CMakeLists.txt b/container-core-config/CMakeLists.txt
new file mode 100644
index 00000000000..307bb103e9f
--- /dev/null
+++ b/container-core-config/CMakeLists.txt
@@ -0,0 +1,2 @@
+# Copyright Verizon Media. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
+install_config_definitions()
diff --git a/container-core-config/OWNERS b/container-core-config/OWNERS
new file mode 100644
index 00000000000..fb71c67318d
--- /dev/null
+++ b/container-core-config/OWNERS
@@ -0,0 +1 @@
+bjorncs \ No newline at end of file
diff --git a/container-core-config/README.md b/container-core-config/README.md
new file mode 100644
index 00000000000..5bb4c3860e1
--- /dev/null
+++ b/container-core-config/README.md
@@ -0,0 +1,7 @@
+# container-core-config
+
+Contains config definitions with package `com.yahoo.container.core` that are used by other modules.
+
+This artifact is embedded inside container-core jar, but built as bundle to allow other modules to depend on container-core config definitions without depending on container-core.
+The generated config classes cannot be moved to container-core as it would introduce a cycles in Maven dependency graph.
+This works at correctly runtime as OSGi allows cycling dependencies between bundles.
diff --git a/container-core-config/pom.xml b/container-core-config/pom.xml
new file mode 100644
index 00000000000..fb4aea4071e
--- /dev/null
+++ b/container-core-config/pom.xml
@@ -0,0 +1,48 @@
+<?xml version="1.0"?>
+<!-- Copyright Verizon Media. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root. -->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
+ http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>com.yahoo.vespa</groupId>
+ <artifactId>parent</artifactId>
+ <version>7-SNAPSHOT</version>
+ <relativePath>../parent/pom.xml</relativePath>
+ </parent>
+ <artifactId>container-core-config</artifactId>
+ <version>7-SNAPSHOT</version>
+ <packaging>container-plugin</packaging> <!-- See README.md for why it's not packaged as 'jar' -->
+ <dependencies>
+ <dependency>
+ <groupId>com.yahoo.vespa</groupId>
+ <artifactId>annotations</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>com.yahoo.vespa</groupId>
+ <artifactId>config-lib</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ </dependencies>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>com.yahoo.vespa</groupId>
+ <artifactId>bundle-plugin</artifactId>
+ <extensions>true</extensions>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-compiler-plugin</artifactId>
+ </plugin>
+ </plugins>
+ <outputDirectory>${buildOutputDirectory}</outputDirectory>
+ </build>
+ <properties>
+ <buildOutputDirectory>${project.build.directory}/classes/</buildOutputDirectory>
+ </properties>
+</project> \ No newline at end of file
diff --git a/container-core-config/src/main/java/com/yahoo/container/core/package-info.java b/container-core-config/src/main/java/com/yahoo/container/core/package-info.java
new file mode 100644
index 00000000000..c9c683bd68a
--- /dev/null
+++ b/container-core-config/src/main/java/com/yahoo/container/core/package-info.java
@@ -0,0 +1,5 @@
+// Copyright Verizon Media. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
+@ExportPackage
+package com.yahoo.container.core;
+
+import com.yahoo.osgi.annotation.ExportPackage; \ No newline at end of file
diff --git a/container-accesslogging/src/main/resources/configdefinitions/container.core.access-log.def b/container-core-config/src/main/resources/configdefinitions/container.core.access-log.def
index 788fadcdf90..08ea6ec4884 100644
--- a/container-accesslogging/src/main/resources/configdefinitions/container.core.access-log.def
+++ b/container-core-config/src/main/resources/configdefinitions/container.core.access-log.def
@@ -1,4 +1,4 @@
-# Copyright 2017 Yahoo Holdings. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
+# Copyright Verizon Media. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
namespace=container.core
# File name patterns supporting the expected time variables, e.g. ".%Y%m%d%H%M%S"
diff --git a/container-core/pom.xml b/container-core/pom.xml
index 0fbb590a1de..7c98b524c73 100644
--- a/container-core/pom.xml
+++ b/container-core/pom.xml
@@ -24,6 +24,12 @@
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
</dependency>
+ <dependency>
+ <groupId>com.yahoo.vespa</groupId>
+ <artifactId>container-core-config</artifactId>
+ <version>${project.version}</version>
+ <scope>compile</scope>
+ </dependency>
<dependency>
<groupId>com.google.guava</groupId>
@@ -41,11 +47,6 @@
</dependency>
<dependency>
<groupId>com.yahoo.vespa</groupId>
- <artifactId>container-accesslogging</artifactId>
- <version>${project.version}</version>
- </dependency>
- <dependency>
- <groupId>com.yahoo.vespa</groupId>
<artifactId>defaults</artifactId>
<version>${project.version}</version>
<scope>provided</scope>
diff --git a/container-search/pom.xml b/container-search/pom.xml
index 6fa32947869..074f5827122 100644
--- a/container-search/pom.xml
+++ b/container-search/pom.xml
@@ -67,12 +67,6 @@
</dependency>
<dependency>
<groupId>com.yahoo.vespa</groupId>
- <artifactId>container-accesslogging</artifactId>
- <version>${project.version}</version>
- <scope>provided</scope>
- </dependency>
- <dependency>
- <groupId>com.yahoo.vespa</groupId>
<artifactId>container-core</artifactId>
<version>${project.version}</version>
<scope>provided</scope>
diff --git a/jdisc_http_service/pom.xml b/jdisc_http_service/pom.xml
index 094ca7baa25..662cef983dd 100644
--- a/jdisc_http_service/pom.xml
+++ b/jdisc_http_service/pom.xml
@@ -68,22 +68,29 @@
</dependency>
<dependency>
<groupId>com.yahoo.vespa</groupId>
- <artifactId>container-accesslogging</artifactId>
+ <artifactId>security-utils</artifactId>
<version>${project.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>com.yahoo.vespa</groupId>
- <artifactId>security-utils</artifactId>
+ <artifactId>yolean</artifactId>
<version>${project.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>com.yahoo.vespa</groupId>
- <artifactId>yolean</artifactId>
+ <artifactId>vespalog</artifactId>
<version>${project.version}</version>
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>com.yahoo.vespa</groupId>
+ <artifactId>container-core-config</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
+ </dependency>
+
<!-- TEST SCOPE -->
<dependency>
@@ -127,6 +134,11 @@
<artifactId>bcpkix-jdk15on</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.assertj</groupId>
+ <artifactId>assertj-core</artifactId>
+ <scope>test</scope>
+ </dependency>
</dependencies>
<build>
<plugins>
diff --git a/container-accesslogging/src/main/java/com/yahoo/container/logging/AccessLog.java b/jdisc_http_service/src/main/java/com/yahoo/container/logging/AccessLog.java
index 5c1a549070c..5c1a549070c 100644
--- a/container-accesslogging/src/main/java/com/yahoo/container/logging/AccessLog.java
+++ b/jdisc_http_service/src/main/java/com/yahoo/container/logging/AccessLog.java
diff --git a/container-accesslogging/src/main/java/com/yahoo/container/logging/AccessLogEntry.java b/jdisc_http_service/src/main/java/com/yahoo/container/logging/AccessLogEntry.java
index d8085cc808b..d8085cc808b 100644
--- a/container-accesslogging/src/main/java/com/yahoo/container/logging/AccessLogEntry.java
+++ b/jdisc_http_service/src/main/java/com/yahoo/container/logging/AccessLogEntry.java
diff --git a/container-accesslogging/src/main/java/com/yahoo/container/logging/AccessLogHandler.java b/jdisc_http_service/src/main/java/com/yahoo/container/logging/AccessLogHandler.java
index 488a6137cc2..488a6137cc2 100644
--- a/container-accesslogging/src/main/java/com/yahoo/container/logging/AccessLogHandler.java
+++ b/jdisc_http_service/src/main/java/com/yahoo/container/logging/AccessLogHandler.java
diff --git a/container-accesslogging/src/main/java/com/yahoo/container/logging/AccessLogInterface.java b/jdisc_http_service/src/main/java/com/yahoo/container/logging/AccessLogInterface.java
index 2523174abef..2523174abef 100644
--- a/container-accesslogging/src/main/java/com/yahoo/container/logging/AccessLogInterface.java
+++ b/jdisc_http_service/src/main/java/com/yahoo/container/logging/AccessLogInterface.java
diff --git a/container-accesslogging/src/main/java/com/yahoo/container/logging/AccessLogSampler.java b/jdisc_http_service/src/main/java/com/yahoo/container/logging/AccessLogSampler.java
index 12d29c2f333..12d29c2f333 100644
--- a/container-accesslogging/src/main/java/com/yahoo/container/logging/AccessLogSampler.java
+++ b/jdisc_http_service/src/main/java/com/yahoo/container/logging/AccessLogSampler.java
diff --git a/container-accesslogging/src/main/java/com/yahoo/container/logging/CircularArrayAccessLogKeeper.java b/jdisc_http_service/src/main/java/com/yahoo/container/logging/CircularArrayAccessLogKeeper.java
index dc749c71613..dc749c71613 100644
--- a/container-accesslogging/src/main/java/com/yahoo/container/logging/CircularArrayAccessLogKeeper.java
+++ b/jdisc_http_service/src/main/java/com/yahoo/container/logging/CircularArrayAccessLogKeeper.java
diff --git a/container-accesslogging/src/main/java/com/yahoo/container/logging/Coverage.java b/jdisc_http_service/src/main/java/com/yahoo/container/logging/Coverage.java
index 9d122b90641..9d122b90641 100644
--- a/container-accesslogging/src/main/java/com/yahoo/container/logging/Coverage.java
+++ b/jdisc_http_service/src/main/java/com/yahoo/container/logging/Coverage.java
diff --git a/container-accesslogging/src/main/java/com/yahoo/container/logging/HitCounts.java b/jdisc_http_service/src/main/java/com/yahoo/container/logging/HitCounts.java
index fed12281962..fed12281962 100644
--- a/container-accesslogging/src/main/java/com/yahoo/container/logging/HitCounts.java
+++ b/jdisc_http_service/src/main/java/com/yahoo/container/logging/HitCounts.java
diff --git a/container-accesslogging/src/main/java/com/yahoo/container/logging/JSONAccessLog.java b/jdisc_http_service/src/main/java/com/yahoo/container/logging/JSONAccessLog.java
index a84903467b6..a84903467b6 100644
--- a/container-accesslogging/src/main/java/com/yahoo/container/logging/JSONAccessLog.java
+++ b/jdisc_http_service/src/main/java/com/yahoo/container/logging/JSONAccessLog.java
diff --git a/container-accesslogging/src/main/java/com/yahoo/container/logging/JSONFormatter.java b/jdisc_http_service/src/main/java/com/yahoo/container/logging/JSONFormatter.java
index ae794e5b60a..ae794e5b60a 100644
--- a/container-accesslogging/src/main/java/com/yahoo/container/logging/JSONFormatter.java
+++ b/jdisc_http_service/src/main/java/com/yahoo/container/logging/JSONFormatter.java
diff --git a/container-accesslogging/src/main/java/com/yahoo/container/logging/LogFileHandler.java b/jdisc_http_service/src/main/java/com/yahoo/container/logging/LogFileHandler.java
index 75e9febc192..75e9febc192 100644
--- a/container-accesslogging/src/main/java/com/yahoo/container/logging/LogFileHandler.java
+++ b/jdisc_http_service/src/main/java/com/yahoo/container/logging/LogFileHandler.java
diff --git a/container-accesslogging/src/main/java/com/yahoo/container/logging/LogFormatter.java b/jdisc_http_service/src/main/java/com/yahoo/container/logging/LogFormatter.java
index cc1dcb579aa..cc1dcb579aa 100644
--- a/container-accesslogging/src/main/java/com/yahoo/container/logging/LogFormatter.java
+++ b/jdisc_http_service/src/main/java/com/yahoo/container/logging/LogFormatter.java
diff --git a/container-accesslogging/src/main/java/com/yahoo/container/logging/TraceRenderer.java b/jdisc_http_service/src/main/java/com/yahoo/container/logging/TraceRenderer.java
index 295786aa15d..295786aa15d 100644
--- a/container-accesslogging/src/main/java/com/yahoo/container/logging/TraceRenderer.java
+++ b/jdisc_http_service/src/main/java/com/yahoo/container/logging/TraceRenderer.java
diff --git a/container-accesslogging/src/main/java/com/yahoo/container/logging/VespaAccessLog.java b/jdisc_http_service/src/main/java/com/yahoo/container/logging/VespaAccessLog.java
index 054fc0fcbf7..054fc0fcbf7 100644
--- a/container-accesslogging/src/main/java/com/yahoo/container/logging/VespaAccessLog.java
+++ b/jdisc_http_service/src/main/java/com/yahoo/container/logging/VespaAccessLog.java
diff --git a/container-accesslogging/src/main/java/com/yahoo/container/logging/package-info.java b/jdisc_http_service/src/main/java/com/yahoo/container/logging/package-info.java
index fc2abb7b609..fc2abb7b609 100644
--- a/container-accesslogging/src/main/java/com/yahoo/container/logging/package-info.java
+++ b/jdisc_http_service/src/main/java/com/yahoo/container/logging/package-info.java
diff --git a/container-accesslogging/src/test/java/com/yahoo/container/logging/AccessLogSamplerTest.java b/jdisc_http_service/src/test/java/com/yahoo/container/logging/AccessLogSamplerTest.java
index 35664049560..32a55b4bb72 100644
--- a/container-accesslogging/src/test/java/com/yahoo/container/logging/AccessLogSamplerTest.java
+++ b/jdisc_http_service/src/test/java/com/yahoo/container/logging/AccessLogSamplerTest.java
@@ -3,7 +3,6 @@ package com.yahoo.container.logging;
import org.junit.Test;
-import java.net.URI;
import java.util.ArrayList;
import java.util.List;
diff --git a/container-accesslogging/src/test/java/com/yahoo/container/logging/CircularArrayAccessLogKeeperTest.java b/jdisc_http_service/src/test/java/com/yahoo/container/logging/CircularArrayAccessLogKeeperTest.java
index 5d9509eb045..5d9509eb045 100644
--- a/container-accesslogging/src/test/java/com/yahoo/container/logging/CircularArrayAccessLogKeeperTest.java
+++ b/jdisc_http_service/src/test/java/com/yahoo/container/logging/CircularArrayAccessLogKeeperTest.java
diff --git a/container-accesslogging/src/test/java/com/yahoo/container/logging/CompressWhileDrop.java b/jdisc_http_service/src/test/java/com/yahoo/container/logging/CompressWhileDrop.java
index 2099037203f..2099037203f 100644
--- a/container-accesslogging/src/test/java/com/yahoo/container/logging/CompressWhileDrop.java
+++ b/jdisc_http_service/src/test/java/com/yahoo/container/logging/CompressWhileDrop.java
diff --git a/container-accesslogging/src/test/java/com/yahoo/container/logging/JSONLogTestCase.java b/jdisc_http_service/src/test/java/com/yahoo/container/logging/JSONLogTestCase.java
index 6c7878f99ed..6c7878f99ed 100644
--- a/container-accesslogging/src/test/java/com/yahoo/container/logging/JSONLogTestCase.java
+++ b/jdisc_http_service/src/test/java/com/yahoo/container/logging/JSONLogTestCase.java
diff --git a/container-accesslogging/src/test/java/com/yahoo/container/logging/LogFileHandlerTestCase.java b/jdisc_http_service/src/test/java/com/yahoo/container/logging/LogFileHandlerTestCase.java
index bc7257b1ca9..bc7257b1ca9 100644
--- a/container-accesslogging/src/test/java/com/yahoo/container/logging/LogFileHandlerTestCase.java
+++ b/jdisc_http_service/src/test/java/com/yahoo/container/logging/LogFileHandlerTestCase.java
diff --git a/container-accesslogging/src/test/java/com/yahoo/container/logging/test/LogFormatterTestCase.java b/jdisc_http_service/src/test/java/com/yahoo/container/logging/test/LogFormatterTestCase.java
index cb34818c35c..ecacf95d100 100644
--- a/container-accesslogging/src/test/java/com/yahoo/container/logging/test/LogFormatterTestCase.java
+++ b/jdisc_http_service/src/test/java/com/yahoo/container/logging/test/LogFormatterTestCase.java
@@ -1,11 +1,11 @@
// Copyright 2017 Yahoo Holdings. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.container.logging.test;
-import java.util.Date;
-
import com.yahoo.container.logging.LogFormatter;
import org.junit.Test;
+import java.util.Date;
+
import static org.junit.Assert.assertEquals;
/**
diff --git a/pom.xml b/pom.xml
index 762e1829d97..91286d35c4d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -54,7 +54,7 @@
<module>config_test</module>
<module>container</module>
<module>container-core</module>
- <module>container-accesslogging</module>
+ <module>container-core-config</module>
<module>container-dependencies-enforcer</module>
<module>container-dependency-versions</module>
<module>container-dev</module>