summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2023-01-12 13:21:50 +0100
committerHenning Baldersheim <balder@yahoo-inc.com>2023-01-12 13:34:20 +0100
commit34d5038ebc00c964868818b0d3038e4297b8919e (patch)
treebc67dc8b333dae3e34d2a53f651ce760e19e3412
parent9667e51302674c198421a010e66efb8de8990f35 (diff)
Two phase GC is now default
-rw-r--r--config-model-api/src/main/java/com/yahoo/config/model/api/ModelContext.java2
-rw-r--r--config-model/src/main/java/com/yahoo/config/model/deploy/TestProperties.java2
-rw-r--r--config-model/src/test/java/com/yahoo/vespa/model/content/ContentClusterTest.java4
-rw-r--r--flags/src/main/java/com/yahoo/vespa/flags/Flags.java2
4 files changed, 5 insertions, 5 deletions
diff --git a/config-model-api/src/main/java/com/yahoo/config/model/api/ModelContext.java b/config-model-api/src/main/java/com/yahoo/config/model/api/ModelContext.java
index a82290523d8..02f0780f79f 100644
--- a/config-model-api/src/main/java/com/yahoo/config/model/api/ModelContext.java
+++ b/config-model-api/src/main/java/com/yahoo/config/model/api/ModelContext.java
@@ -108,7 +108,7 @@ public interface ModelContext {
@ModelFeatureFlag(owners = {"hmusum"}) default Architecture adminClusterArchitecture() { return Architecture.getDefault(); }
@ModelFeatureFlag(owners = {"tokle"}) default boolean enableProxyProtocolMixedMode() { return true; }
@ModelFeatureFlag(owners = {"arnej"}) default String logFileCompressionAlgorithm(String defVal) { return defVal; }
- @ModelFeatureFlag(owners = {"vekterli"}) default boolean useTwoPhaseDocumentGc() { return false; }
+ @ModelFeatureFlag(owners = {"vekterli"}) default boolean useTwoPhaseDocumentGc() { return true; }
@ModelFeatureFlag(owners = {"tokle"}) default boolean useRestrictedDataPlaneBindings() { return false; }
@ModelFeatureFlag(owners = {"arnej","baldersheim"}) default boolean useOldJdiscContainerStartup() { return true; }
@ModelFeatureFlag(owners = {"tokle, bjorncs"}, removeAfter = "8.108") default boolean enableDataPlaneFilter() { return true; }
diff --git a/config-model/src/main/java/com/yahoo/config/model/deploy/TestProperties.java b/config-model/src/main/java/com/yahoo/config/model/deploy/TestProperties.java
index fba2f711111..25ca654fc63 100644
--- a/config-model/src/main/java/com/yahoo/config/model/deploy/TestProperties.java
+++ b/config-model/src/main/java/com/yahoo/config/model/deploy/TestProperties.java
@@ -70,7 +70,7 @@ public class TestProperties implements ModelContext.Properties, ModelContext.Fea
private List<String> environmentVariables = List.of();
private boolean loadCodeAsHugePages = false;
private boolean sharedStringRepoNoReclaim = false;
- private boolean useTwoPhaseDocumentGc = false;
+ private boolean useTwoPhaseDocumentGc = true;
private int mbus_java_num_targets = 1;
private int mbus_java_events_before_wakeup = 1;
private int mbus_cpp_num_targets = 1;
diff --git a/config-model/src/test/java/com/yahoo/vespa/model/content/ContentClusterTest.java b/config-model/src/test/java/com/yahoo/vespa/model/content/ContentClusterTest.java
index c41840eaefa..96f5f9b9409 100644
--- a/config-model/src/test/java/com/yahoo/vespa/model/content/ContentClusterTest.java
+++ b/config-model/src/test/java/com/yahoo/vespa/model/content/ContentClusterTest.java
@@ -1154,8 +1154,8 @@ public class ContentClusterTest extends ContentBaseTest {
// TODO change once gradual rollout complete
@Test
- public void two_phase_garbage_collection_config_is_disabled_by_default() {
- assertFalse(resolveTwoPhaseGcConfigWithFeatureFlag(null));
+ public void two_phase_garbage_collection_config_is_enabled_by_default() {
+ assertTrue(resolveTwoPhaseGcConfigWithFeatureFlag(null));
}
@Test
diff --git a/flags/src/main/java/com/yahoo/vespa/flags/Flags.java b/flags/src/main/java/com/yahoo/vespa/flags/Flags.java
index 77291b4d0e7..b789522e763 100644
--- a/flags/src/main/java/com/yahoo/vespa/flags/Flags.java
+++ b/flags/src/main/java/com/yahoo/vespa/flags/Flags.java
@@ -338,7 +338,7 @@ public class Flags {
);
public static final UnboundBooleanFlag USE_TWO_PHASE_DOCUMENT_GC = defineFeatureFlag(
- "use-two-phase-document-gc", false,
+ "use-two-phase-document-gc", true,
List.of("vekterli"), "2022-08-24", "2023-02-01",
"Use two-phase document GC in content clusters",
"Takes effect at redeployment",