summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2021-04-25 21:46:53 +0200
committerHenning Baldersheim <balder@yahoo-inc.com>2021-04-25 21:46:53 +0200
commit4bad6997d0ee13c46a15c6404402ddc2a797db17 (patch)
tree6b6b7585a3f2469157f8c7fff4aac2776390ab5e
parenta9ac18e9ff6ca6691076b8dcf00e7c00012a2d1e (diff)
Also test restart aspect when changing casing of dictionary
-rw-r--r--config-model/src/test/java/com/yahoo/vespa/model/application/validation/change/search/AttributeChangeValidatorTest.java8
1 files changed, 3 insertions, 5 deletions
diff --git a/config-model/src/test/java/com/yahoo/vespa/model/application/validation/change/search/AttributeChangeValidatorTest.java b/config-model/src/test/java/com/yahoo/vespa/model/application/validation/change/search/AttributeChangeValidatorTest.java
index cd8afa404da..2cf8069c988 100644
--- a/config-model/src/test/java/com/yahoo/vespa/model/application/validation/change/search/AttributeChangeValidatorTest.java
+++ b/config-model/src/test/java/com/yahoo/vespa/model/application/validation/change/search/AttributeChangeValidatorTest.java
@@ -3,7 +3,6 @@ package com.yahoo.vespa.model.application.validation.change.search;
import com.yahoo.config.provision.ClusterSpec;
import com.yahoo.vespa.model.application.validation.change.VespaConfigChangeAction;
-import org.junit.Ignore;
import org.junit.Test;
import java.util.List;
@@ -93,11 +92,10 @@ public class AttributeChangeValidatorTest {
"Field 'f1' changed: remove attribute 'fast-access'"));
}
- // TODO Not testable until one dictionary type supports both cased/uncased
- @Ignore
+ @Test
public void changing_uncased2cased_require_restart() throws Exception {
- new Fixture("field f1 type string { indexing: attribute\n attribute: fast-search\n dictionary { hash\ncased}\nmatch:cased}",
- "field f1 type string { indexing: attribute\n attribute: fast-search\n dictionary{ btree} }").
+ new Fixture("field f1 type string { indexing: attribute\n attribute: fast-search\n dictionary { btree\ncased}\nmatch:cased}",
+ "field f1 type string { indexing: attribute\n attribute: fast-search\n dictionary{ btree\nuncased}\nmatch:uncased }").
assertValidation(newRestartAction(ClusterSpec.Id.from("test"),
"Field 'f1' changed: change property 'dictionary: cased/uncased' from 'CASED' to 'UNCASED'"));
}