diff options
author | Henning Baldersheim <balder@yahoo-inc.com> | 2022-06-02 18:17:29 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-06-02 18:17:29 +0200 |
commit | a1c55ec23830a4f980cac6577e6ae645b4851212 (patch) | |
tree | eef0a12be310de643092fdfd295745763dfd816e | |
parent | 591b8456080740787b8aa2c09008a259b49a5e76 (diff) | |
parent | 32e99bece3ef25c8fa1ed60461395c34a28b7c2e (diff) |
Merge pull request #22869 from vespa-engine/balder/dynamic_cast-2-static_cast
Use static_cast instead of dynamic_cast
-rw-r--r-- | eval/src/vespa/eval/eval/typed_cells.h | 1 | ||||
-rw-r--r-- | eval/src/vespa/eval/eval/value.h | 7 |
2 files changed, 1 insertions, 7 deletions
diff --git a/eval/src/vespa/eval/eval/typed_cells.h b/eval/src/vespa/eval/eval/typed_cells.h index b8640698d13..f49672b8891 100644 --- a/eval/src/vespa/eval/eval/typed_cells.h +++ b/eval/src/vespa/eval/eval/typed_cells.h @@ -2,7 +2,6 @@ #pragma once -#include <assert.h> #include <vespa/vespalib/util/arrayref.h> #include <vespa/eval/eval/cell_type.h> diff --git a/eval/src/vespa/eval/eval/value.h b/eval/src/vespa/eval/eval/value.h index ed6d63e3b8d..7cf2659c3fb 100644 --- a/eval/src/vespa/eval/eval/value.h +++ b/eval/src/vespa/eval/eval/value.h @@ -6,10 +6,6 @@ #include "value_type.h" #include "typed_cells.h" #include <vespa/vespalib/util/string_id.h> -#include <vespa/vespalib/stllike/string.h> -#include <vespa/vespalib/util/traits.h> -#include <vector> -#include <memory> namespace vespalib::eval { @@ -193,8 +189,7 @@ private: { assert(check_cell_type<T>(type.cell_type())); auto base = create_value_builder_base(type, transient, num_mapped_dims_in, subspace_size_in, expected_subspaces); - ValueBuilder<T> *builder = dynamic_cast<ValueBuilder<T>*>(base.get()); - assert(builder); + ValueBuilder<T> *builder = static_cast<ValueBuilder<T>*>(base.get()); base.release(); return std::unique_ptr<ValueBuilder<T>>(builder); } |