Merge pull request #22504 from vespa-engine/vekterli/move-shared_ptr-in-ctor

Move shared_ptr in BucketMoveJob::StartMove constructor

1 files changed, 4 insertions, 4 deletions

diff --git a/searchcore/src/vespa/searchcore/proton/server/bucketmovejob.cpp b/searchcore/src/vespa/searchcore/proton/server/bucketmovejob.cpp
index 5ade2e263c6..e010240f5f8 100644
--- a/searchcore/src/vespa/searchcore/proton/server/bucketmovejob.cpp
+++ b/searchcore/src/vespa/searchcore/proton/server/bucketmovejob.cpp
@@ -180,7 +180,7 @@ class BucketMoveJob::StartMove : public storage::spi::BucketTask {
 public:
     using IDestructorCallbackSP = std::shared_ptr<vespalib::IDestructorCallback>;
     StartMove(std::shared_ptr<BucketMoveJob> job, BucketMover::MoveKeys keys, IDestructorCallbackSP opsTracker)
-        : _job(job),
+        : _job(std::move(job)),
           _keys(std::move(keys)),
           _opsTracker(std::move(opsTracker))
     {}
@@ -197,9 +197,9 @@ public:
     }
 
 private:
-    std::shared_ptr<BucketMoveJob>  _job;
-    BucketMover::MoveKeys             _keys;
-    IDestructorCallbackSP             _opsTracker;
+    std::shared_ptr<BucketMoveJob> _job;
+    BucketMover::MoveKeys          _keys;
+    IDestructorCallbackSP          _opsTracker;
 };
 
 void