summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHÃ¥kon Hallingstad <hakon@verizonmedia.com>2020-05-06 20:09:35 +0200
committerGitHub <noreply@github.com>2020-05-06 20:09:35 +0200
commit1fdbeaba57862dd81e91d3794a5fdbf48a359075 (patch)
tree38cec30614dab42779b1b7b7bd37190d4b0c01aa
parentae67c69c65819db973088ef952c713a5e9e4e56c (diff)
parent51ab9a3b41eb7b70a8edc6977f9cd67a9b0815e0 (diff)
Merge pull request #13172 from vespa-engine/revert-13170-musum/reduce-time-to-keep-expired-sessions
Revert "Reduce the time we keep expired remotes sessions and fix comment"
-rw-r--r--configserver/src/main/java/com/yahoo/vespa/config/server/maintenance/SessionsMaintainer.java7
1 files changed, 4 insertions, 3 deletions
diff --git a/configserver/src/main/java/com/yahoo/vespa/config/server/maintenance/SessionsMaintainer.java b/configserver/src/main/java/com/yahoo/vespa/config/server/maintenance/SessionsMaintainer.java
index c0211fb6e91..c4f0c5fdd5d 100644
--- a/configserver/src/main/java/com/yahoo/vespa/config/server/maintenance/SessionsMaintainer.java
+++ b/configserver/src/main/java/com/yahoo/vespa/config/server/maintenance/SessionsMaintainer.java
@@ -27,10 +27,11 @@ public class SessionsMaintainer extends ConfigServerMaintainer {
protected void maintain() {
applicationRepository.deleteExpiredLocalSessions();
- // Expired remote sessions are sessions that belong to an application that have external deployments that
- // are no longer active
+ // Expired remote sessions are not expected to exist, they should have been deleted when
+ // a deployment happened or when the application was deleted. We still see them from time to time,
+ // probably due to some race or another bug
if (hostedVespa) {
- Duration expiryTime = Duration.ofDays(7);
+ Duration expiryTime = Duration.ofDays(30);
applicationRepository.deleteExpiredRemoteSessions(expiryTime);
}
}