summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGeir Storli <geirst@vespa.ai>2024-03-11 10:51:41 +0100
committerGitHub <noreply@github.com>2024-03-11 10:51:41 +0100
commit81302c75e44e511e472acd1eaf3812fcdda60fa7 (patch)
tree617ebff1200be245ef34593cc24be1c53c8c2f54
parent44728d8c6680114ca1664fbd8cc8404573fe8d94 (diff)
parent0da60628023056c1b7bcab9660bbebd0d3d61d9e (diff)
Merge pull request #30550 from vespa-engine/toregge/early-exit-on-fatal-failure-in-sharded-hash-map-unit-test
Early exit on fatal failure in sharded hash map unit test.
-rw-r--r--vespalib/src/tests/datastore/sharded_hash_map/sharded_hash_map_test.cpp6
1 files changed, 3 insertions, 3 deletions
diff --git a/vespalib/src/tests/datastore/sharded_hash_map/sharded_hash_map_test.cpp b/vespalib/src/tests/datastore/sharded_hash_map/sharded_hash_map_test.cpp
index 08b9b96e202..6b4aa51a481 100644
--- a/vespalib/src/tests/datastore/sharded_hash_map/sharded_hash_map_test.cpp
+++ b/vespalib/src/tests/datastore/sharded_hash_map/sharded_hash_map_test.cpp
@@ -306,7 +306,7 @@ void
DataStoreShardedHashTest::test_normalize_values(bool use_filter, bool one_filter)
{
populate_sample_data(large_population);
- populate_sample_values(large_population);
+ ASSERT_NO_FATAL_FAILURE(populate_sample_values(large_population));
if (use_filter) {
auto filter = make_entry_ref_filter<RefT>(one_filter);
EXPECT_TRUE(_hash_map.normalize_values([](std::vector<EntryRef> &refs) noexcept { for (auto &ref : refs) { RefT iref(ref); ref = RefT(iref.offset() + 300, iref.bufferId()); } }, filter));
@@ -332,7 +332,7 @@ void
DataStoreShardedHashTest::test_foreach_value(bool one_filter)
{
populate_sample_data(large_population);
- populate_sample_values(large_population);
+ ASSERT_NO_FATAL_FAILURE(populate_sample_values(large_population));
auto filter = make_entry_ref_filter<RefT>(one_filter);
std::vector<EntryRef> exp_refs;
@@ -340,7 +340,7 @@ DataStoreShardedHashTest::test_foreach_value(bool one_filter)
std::vector<EntryRef> act_refs;
_hash_map.foreach_value([&act_refs](const std::vector<EntryRef> &refs) { act_refs.insert(act_refs.end(), refs.begin(), refs.end()); }, filter);
EXPECT_EQ(exp_refs, act_refs);
- clear_sample_values(large_population);
+ ASSERT_NO_FATAL_FAILURE(clear_sample_values(large_population));
}
TEST_F(DataStoreShardedHashTest, single_threaded_reader_without_updates)