Merge pull request #19820 from vespa-engine/bratseth/weightedset-equals

Correct equals

1 files changed, 2 insertions, 1 deletions

diff --git a/container-search/src/main/java/com/yahoo/prelude/query/WeightedSetItem.java b/container-search/src/main/java/com/yahoo/prelude/query/WeightedSetItem.java
index 84a176c2f7d..d5ca15f10b9 100644
--- a/container-search/src/main/java/com/yahoo/prelude/query/WeightedSetItem.java
+++ b/container-search/src/main/java/com/yahoo/prelude/query/WeightedSetItem.java
@@ -182,11 +182,12 @@ public class WeightedSetItem extends SimpleTaggableItem {
 
     @Override
     public boolean equals(Object o) {
+        if (o == this) return true;
         if ( ! super.equals(o)) return false;
         var other = (WeightedSetItem)o;
         if ( ! Objects.equals(this.indexName, other.indexName)) return false;
         if ( ! Objects.equals(this.set, other.set)) return false;
-        return false;
+        return true;
     }
 
     @Override