diff options
author | Valerij Fredriksen <freva@users.noreply.github.com> | 2022-06-09 16:59:17 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-06-09 16:59:17 +0200 |
commit | 0fd0ba6d04f642095e35ff828e6d7ee334a4bdb8 (patch) | |
tree | 27293412ddae487644f1ee3344aef2cf401975a7 | |
parent | 85a65a266c6e4706984af1a6525873c36ca2b5eb (diff) | |
parent | 2179df71b8bc0e4416dc72fa66e8c96f80a8e098 (diff) |
Merge pull request #23035 from vespa-engine/hakonhall/refer-to-correct-secret-version-from-signed-doc
Refer to correct secret version from signed doc
3 files changed, 3 insertions, 4 deletions
diff --git a/athenz-identity-provider-service/src/main/java/com/yahoo/vespa/hosted/athenz/instanceproviderservice/IdentityDocumentGenerator.java b/athenz-identity-provider-service/src/main/java/com/yahoo/vespa/hosted/athenz/instanceproviderservice/IdentityDocumentGenerator.java index c33974abf7a..5b1a909e109 100644 --- a/athenz-identity-provider-service/src/main/java/com/yahoo/vespa/hosted/athenz/instanceproviderservice/IdentityDocumentGenerator.java +++ b/athenz-identity-provider-service/src/main/java/com/yahoo/vespa/hosted/athenz/instanceproviderservice/IdentityDocumentGenerator.java @@ -71,7 +71,7 @@ public class IdentityDocumentGenerator { return new SignedIdentityDocument( signature, - SignedIdentityDocument.DEFAULT_KEY_VERSION, + athenzProviderServiceConfig.secretVersion(), providerUniqueId, providerService, SignedIdentityDocument.DEFAULT_DOCUMENT_VERSION, diff --git a/vespa-athenz/src/main/java/com/yahoo/vespa/athenz/identityprovider/api/SignedIdentityDocument.java b/vespa-athenz/src/main/java/com/yahoo/vespa/athenz/identityprovider/api/SignedIdentityDocument.java index 06227237d2e..81c298efb74 100644 --- a/vespa-athenz/src/main/java/com/yahoo/vespa/athenz/identityprovider/api/SignedIdentityDocument.java +++ b/vespa-athenz/src/main/java/com/yahoo/vespa/athenz/identityprovider/api/SignedIdentityDocument.java @@ -13,7 +13,6 @@ import java.util.Set; * @author bjorncs */ public class SignedIdentityDocument { - public static final int DEFAULT_KEY_VERSION = 0; public static final int DEFAULT_DOCUMENT_VERSION = 1; private final String signature; diff --git a/vespa-athenz/src/test/java/com/yahoo/vespa/athenz/identityprovider/client/IdentityDocumentSignerTest.java b/vespa-athenz/src/test/java/com/yahoo/vespa/athenz/identityprovider/client/IdentityDocumentSignerTest.java index 246a49a88c3..5a3099aff76 100644 --- a/vespa-athenz/src/test/java/com/yahoo/vespa/athenz/identityprovider/client/IdentityDocumentSignerTest.java +++ b/vespa-athenz/src/test/java/com/yahoo/vespa/athenz/identityprovider/client/IdentityDocumentSignerTest.java @@ -16,13 +16,13 @@ import java.util.HashSet; import static com.yahoo.vespa.athenz.identityprovider.api.IdentityType.TENANT; import static com.yahoo.vespa.athenz.identityprovider.api.SignedIdentityDocument.DEFAULT_DOCUMENT_VERSION; -import static com.yahoo.vespa.athenz.identityprovider.api.SignedIdentityDocument.DEFAULT_KEY_VERSION; import static org.junit.Assert.assertTrue; /** * @author bjorncs */ public class IdentityDocumentSignerTest { + public static final int KEY_VERSION = 0; @Test public void generates_and_validates_signature() { @@ -40,7 +40,7 @@ public class IdentityDocumentSignerTest { signer.generateSignature(id, providerService, configserverHostname, instanceHostname, createdAt, ipAddresses, identityType, keyPair.getPrivate()); SignedIdentityDocument signedIdentityDocument = new SignedIdentityDocument( - signature, DEFAULT_KEY_VERSION, id, providerService, + signature, KEY_VERSION, id, providerService, DEFAULT_DOCUMENT_VERSION, configserverHostname, instanceHostname, createdAt, ipAddresses, identityType); assertTrue(signer.hasValidSignature(signedIdentityDocument, keyPair.getPublic())); |