summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJon Marius Venstad <jonmv@users.noreply.github.com>2021-06-15 16:30:26 +0200
committerGitHub <noreply@github.com>2021-06-15 16:30:26 +0200
commit5fc6e1efa88c6c86d7b0f697eeb238e593aa782f (patch)
tree94cb6df942df2830fd38a2dcb2a780ea46f3deee
parentf986f75c5bb3f587bb39b290b78f335e24641e03 (diff)
parente33c4ec399ddcfa7bcea65dcab53733a4e27aaf0 (diff)
Merge pull request #18277 from vespa-engine/mpolden/improve-message
Improve failure reason for suspension timeout
-rw-r--r--controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/InternalStepRunner.java5
1 files changed, 4 insertions, 1 deletions
diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/InternalStepRunner.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/InternalStepRunner.java
index c7270b6c426..10f96ff13cd 100644
--- a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/InternalStepRunner.java
+++ b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/InternalStepRunner.java
@@ -340,7 +340,10 @@ public class InternalStepRunner implements StepRunner {
.map(since -> since.isBefore(controller.clock().instant().minus(timeouts.noNodesDown())))
.orElse(false)) {
if (summary.needPlatformUpgrade() > 0 || summary.needReboot() > 0 || summary.needRestart() > 0)
- failureReason = "No nodes allowed to suspend to progress installation for " + timeouts.noNodesDown().toMinutes() + " minutes.";
+ failureReason = "Timed out after waiting " + timeouts.noNodesDown().toMinutes() + " minutes for " +
+ "nodes to suspend. This is normal if the cluster is excessively busy. " +
+ "Nodes will continue to attempt suspension to progress installation independently of " +
+ "this run.";
else
failureReason = "Nodes not able to start with new application package.";
}