diff options
author | Harald Musum <musum@yahooinc.com> | 2024-02-08 09:34:30 +0100 |
---|---|---|
committer | Harald Musum <musum@yahooinc.com> | 2024-02-08 09:34:30 +0100 |
commit | af5e035c954be4cbaf102fb2db0a3cc8d23979f5 (patch) | |
tree | dc6ad730db3733b62db75b2e71b1d714c0b62793 | |
parent | 9cfd07a31b5bbf005412fb25b462e097e23118e9 (diff) |
GC dead code
4 files changed, 1 insertions, 13 deletions
diff --git a/config-model-api/abi-spec.json b/config-model-api/abi-spec.json index f5f9215d29d..8ebe0069a29 100644 --- a/config-model-api/abi-spec.json +++ b/config-model-api/abi-spec.json @@ -1284,11 +1284,8 @@ "public java.lang.String logFileCompressionAlgorithm(java.lang.String)", "public java.lang.String summaryDecodePolicy()", "public int contentLayerMetadataFeatureLevel()", - "public boolean dynamicHeapSize()", "public java.lang.String unknownConfigDefinition()", "public int searchHandlerThreadpool()", - "public long mergingMaxMemoryUsagePerNode()", - "public boolean usePerDocumentThrottledDeleteBucket()", "public boolean alwaysMarkPhraseExpensive()", "public boolean restartOnDeployWhenOnnxModelChanges()", "public boolean sortBlueprintsByCost()" @@ -1371,7 +1368,6 @@ "public abstract com.yahoo.config.application.api.FileRegistry getFileRegistry()", "public abstract java.util.concurrent.ExecutorService getExecutor()", "public java.util.Optional reindexing()", - "public java.util.Set restartingClusters()", "public abstract com.yahoo.config.model.api.ModelContext$Properties properties()", "public java.util.Optional appDir()", "public abstract com.yahoo.config.model.api.OnnxModelCost onnxModelCost()", diff --git a/config-model-api/src/main/java/com/yahoo/config/model/api/ModelContext.java b/config-model-api/src/main/java/com/yahoo/config/model/api/ModelContext.java index d44babdd10b..39a0fec4920 100644 --- a/config-model-api/src/main/java/com/yahoo/config/model/api/ModelContext.java +++ b/config-model-api/src/main/java/com/yahoo/config/model/api/ModelContext.java @@ -43,7 +43,6 @@ public interface ModelContext { FileRegistry getFileRegistry(); ExecutorService getExecutor(); default Optional<? extends Reindexing> reindexing() { return Optional.empty(); } - default Set<ClusterSpec.Id> restartingClusters() { return Set.of(); } // TODO: Remove after 8.290 is gone. Properties properties(); default Optional<File> appDir() { return Optional.empty(); } OnnxModelCost onnxModelCost(); @@ -109,11 +108,8 @@ public interface ModelContext { @ModelFeatureFlag(owners = {"arnej"}) default String logFileCompressionAlgorithm(String defVal) { return defVal; } @ModelFeatureFlag(owners = {"baldersheim"}, comment = "Select summary decode type") default String summaryDecodePolicy() { return "eager"; } @ModelFeatureFlag(owners = {"vekterli"}) default int contentLayerMetadataFeatureLevel() { return 0; } - @ModelFeatureFlag(owners = {"bjorncs"}, removeAfter = "8.289") default boolean dynamicHeapSize() { return true; } @ModelFeatureFlag(owners = {"hmusum"}) default String unknownConfigDefinition() { return "warn"; } @ModelFeatureFlag(owners = {"hmusum"}) default int searchHandlerThreadpool() { return 2; } - @ModelFeatureFlag(owners = {"vekterli"}, removeAfter = "8.292.x") default long mergingMaxMemoryUsagePerNode() { return 0; } - @ModelFeatureFlag(owners = {"vekterli"}, removeAfter = "8.292.x") default boolean usePerDocumentThrottledDeleteBucket() { return true; } @ModelFeatureFlag(owners = {"baldersheim"}) default boolean alwaysMarkPhraseExpensive() { return false; } @ModelFeatureFlag(owners = {"hmusum"}, removeAfter = "8.300.x") default boolean restartOnDeployWhenOnnxModelChanges() { return true; } @ModelFeatureFlag(owners = {"baldersheim"}) default boolean sortBlueprintsByCost() { return false; } diff --git a/config-model/src/main/java/com/yahoo/config/model/deploy/TestProperties.java b/config-model/src/main/java/com/yahoo/config/model/deploy/TestProperties.java index a6429c43d0e..11d3a48ee51 100644 --- a/config-model/src/main/java/com/yahoo/config/model/deploy/TestProperties.java +++ b/config-model/src/main/java/com/yahoo/config/model/deploy/TestProperties.java @@ -83,7 +83,6 @@ public class TestProperties implements ModelContext.Properties, ModelContext.Fea private boolean allowUserFilters = true; private List<DataplaneToken> dataplaneTokens; private int contentLayerMetadataFeatureLevel = 0; - private boolean dynamicHeapSize = false; @Override public ModelContext.FeatureFlags featureFlags() { return this; } @Override public boolean multitenant() { return multitenant; } @@ -140,7 +139,6 @@ public class TestProperties implements ModelContext.Properties, ModelContext.Fea @Override public boolean allowUserFilters() { return allowUserFilters; } @Override public List<DataplaneToken> dataplaneTokens() { return dataplaneTokens; } @Override public int contentLayerMetadataFeatureLevel() { return contentLayerMetadataFeatureLevel; } - @Override public boolean dynamicHeapSize() { return dynamicHeapSize; } public TestProperties sharedStringRepoNoReclaim(boolean sharedStringRepoNoReclaim) { this.sharedStringRepoNoReclaim = sharedStringRepoNoReclaim; @@ -371,8 +369,6 @@ public class TestProperties implements ModelContext.Properties, ModelContext.Fea return this; } - public TestProperties setDynamicHeapSize(boolean b) { this.dynamicHeapSize = b; return this; } - public static class Spec implements ConfigServerSpec { private final String hostName; diff --git a/config-model/src/test/java/com/yahoo/vespa/model/application/validation/JvmHeapSizeValidatorTest.java b/config-model/src/test/java/com/yahoo/vespa/model/application/validation/JvmHeapSizeValidatorTest.java index 52d861ac902..45125c8eb68 100644 --- a/config-model/src/test/java/com/yahoo/vespa/model/application/validation/JvmHeapSizeValidatorTest.java +++ b/config-model/src/test/java/com/yahoo/vespa/model/application/validation/JvmHeapSizeValidatorTest.java @@ -88,7 +88,7 @@ class JvmHeapSizeValidatorTest { .build()) .modelHostProvisioner(new InMemoryProvisioner(5, new NodeResources(4, nodeGb, 125, 0.3), true)) .endpoints(Set.of(new ContainerEndpoint("container", ApplicationClusterEndpoint.Scope.zone, List.of("c.example.com")))) - .properties(new TestProperties().setHostedVespa(true).setDynamicHeapSize(true)) + .properties(new TestProperties().setHostedVespa(true)) .onnxModelCost(new ModelCostDummy(modelCostBytes)) .build(); } |