diff options
author | Arne Juul <arnej@yahoo-inc.com> | 2019-05-23 07:23:16 +0000 |
---|---|---|
committer | Arne Juul <arnej@yahoo-inc.com> | 2019-05-23 07:23:16 +0000 |
commit | 2644ef477eff81c3f9d5aa69bfc83a1f2982a30d (patch) | |
tree | 8504edd639b1975c92c60d04e13abbc7e4208fb0 | |
parent | 763c6ce62dc2c1265fc33a25c095432b8c0b8bba (diff) |
use try-with-resources to ensure streams are closed
-rw-r--r-- | container-accesslogging/src/main/java/com/yahoo/container/logging/LogFileHandler.java | 8 | ||||
-rw-r--r-- | logserver/src/main/java/com/yahoo/logserver/handlers/archive/FilesArchived.java | 8 |
2 files changed, 6 insertions, 10 deletions
diff --git a/container-accesslogging/src/main/java/com/yahoo/container/logging/LogFileHandler.java b/container-accesslogging/src/main/java/com/yahoo/container/logging/LogFileHandler.java index 3912a3be853..fb21626cc41 100644 --- a/container-accesslogging/src/main/java/com/yahoo/container/logging/LogFileHandler.java +++ b/container-accesslogging/src/main/java/com/yahoo/container/logging/LogFileHandler.java @@ -261,18 +261,16 @@ public class LogFileHandler extends StreamHandler { private void runCompression(File oldFile) { File gzippedFile = new File(oldFile.getPath() + ".gz"); - try { - GZIPOutputStream compressor = new GZIPOutputStream(new FileOutputStream(gzippedFile), 0x100000); - FileInputStream inputStream = new FileInputStream(oldFile); + try (GZIPOutputStream compressor = new GZIPOutputStream(new FileOutputStream(gzippedFile), 0x100000); + FileInputStream inputStream = new FileInputStream(oldFile)) + { byte [] buffer = new byte[0x100000]; for (int read = inputStream.read(buffer); read > 0; read = inputStream.read(buffer)) { compressor.write(buffer, 0, read); } - inputStream.close(); compressor.finish(); compressor.flush(); - compressor.close(); NativeIO nativeIO = new NativeIO(); nativeIO.dropFileFromCache(oldFile); // Drop from cache in case somebody else has a reference to it preventing from dying quickly. diff --git a/logserver/src/main/java/com/yahoo/logserver/handlers/archive/FilesArchived.java b/logserver/src/main/java/com/yahoo/logserver/handlers/archive/FilesArchived.java index fa716921be5..ff082f7efba 100644 --- a/logserver/src/main/java/com/yahoo/logserver/handlers/archive/FilesArchived.java +++ b/logserver/src/main/java/com/yahoo/logserver/handlers/archive/FilesArchived.java @@ -113,19 +113,17 @@ public class FilesArchived { private void compress(File oldFile) { File gzippedFile = new File(oldFile.getPath() + ".gz"); - try { + try (GZIPOutputStream compressor = new GZIPOutputStream(new FileOutputStream(gzippedFile), 0x100000); + FileInputStream inputStream = new FileInputStream(oldFile)) + { long mtime = oldFile.lastModified(); - GZIPOutputStream compressor = new GZIPOutputStream(new FileOutputStream(gzippedFile), 0x100000); - FileInputStream inputStream = new FileInputStream(oldFile); byte [] buffer = new byte[0x100000]; for (int read = inputStream.read(buffer); read > 0; read = inputStream.read(buffer)) { compressor.write(buffer, 0, read); } - inputStream.close(); compressor.finish(); compressor.flush(); - compressor.close(); oldFile.delete(); gzippedFile.setLastModified(mtime); log.info("Compressed: "+gzippedFile); |