add illegal arg exception for languages not registered

2 files changed, 8 insertions, 1 deletions

diff --git a/linguistics/src/main/java/com/yahoo/language/significance/impl/DefaultSignificanceModelRegistry.java b/linguistics/src/main/java/com/yahoo/language/significance/impl/DefaultSignificanceModelRegistry.java
index 56bab17c958..d44eab39cdf 100644
--- a/linguistics/src/main/java/com/yahoo/language/significance/impl/DefaultSignificanceModelRegistry.java
+++ b/linguistics/src/main/java/com/yahoo/language/significance/impl/DefaultSignificanceModelRegistry.java
@@ -43,7 +43,11 @@ public class DefaultSignificanceModelRegistry implements SignificanceModelRegist
 
 
     @Override
-    public SignificanceModel getModel(Language language) {
+    public SignificanceModel getModel(Language language) throws IllegalArgumentException {
+        if (!models.containsKey(language))
+        {
+            throw new IllegalArgumentException("No model for language " + language);
+        }
         return models.get(language);
     }
 
diff --git a/linguistics/src/test/java/com/yahoo/language/significance/DefaultSignificanceModelRegistryTest.java b/linguistics/src/test/java/com/yahoo/language/significance/DefaultSignificanceModelRegistryTest.java
index 0ff2eacfd37..d1de63a994d 100644
--- a/linguistics/src/test/java/com/yahoo/language/significance/DefaultSignificanceModelRegistryTest.java
+++ b/linguistics/src/test/java/com/yahoo/language/significance/DefaultSignificanceModelRegistryTest.java
@@ -8,6 +8,7 @@ import org.junit.Test;
 import java.nio.file.Path;
 import java.util.HashMap;
 
+import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 
@@ -29,6 +30,8 @@ public class DefaultSignificanceModelRegistryTest {
         var englishModel = defaultSignificanceModelRegistry.getModel(Language.ENGLISH);
         var norwegianModel = defaultSignificanceModelRegistry.getModel(Language.NORWEGIAN_BOKMAL);
 
+        assertThrows(IllegalArgumentException.class, () -> defaultSignificanceModelRegistry.getModel(Language.FRENCH));
+
         assertNotNull(englishModel);
         assertNotNull(norwegianModel);