summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYngve Aasheim <yngveaasheim@users.noreply.github.com>2024-05-10 12:48:27 +0200
committerGitHub <noreply@github.com>2024-05-10 12:48:27 +0200
commit655141f5b319073fb6377dac856500bff5d6ed55 (patch)
treeeba66e90cd1e6954dc0e88d58d1c913bdb301307
parent158a28a6df1fe14b805a650c4652f8a0a1dfe52e (diff)
parentb1541623f53c83f8d3b5704ceea379f0b33b4349 (diff)
Merge pull request #31167 from vespa-engine/yngveaasheim/add-embedder-metrics
Add embedder metrics to vespa9 metricset
-rw-r--r--metrics/src/main/java/ai/vespa/metrics/set/Vespa9VespaMetricSet.java4
-rw-r--r--metrics/src/main/java/ai/vespa/metrics/set/VespaMetricSet.java8
2 files changed, 8 insertions, 4 deletions
diff --git a/metrics/src/main/java/ai/vespa/metrics/set/Vespa9VespaMetricSet.java b/metrics/src/main/java/ai/vespa/metrics/set/Vespa9VespaMetricSet.java
index 5b5126b23f0..957eaf8304f 100644
--- a/metrics/src/main/java/ai/vespa/metrics/set/Vespa9VespaMetricSet.java
+++ b/metrics/src/main/java/ai/vespa/metrics/set/Vespa9VespaMetricSet.java
@@ -211,6 +211,10 @@ public class Vespa9VespaMetricSet {
addMetric(metrics, ContainerMetrics.JDISC_TLS_CAPABILITY_CHECKS_SUCCEEDED.rate());
addMetric(metrics, ContainerMetrics.JDISC_TLS_CAPABILITY_CHECKS_FAILED.rate());
+ // Embedders
+ addMetric(metrics, ContainerMetrics.EMBEDDER_LATENCY, EnumSet.of(max, sum, count));
+ addMetric(metrics, ContainerMetrics.EMBEDDER_SEQUENCE_LENGTH, EnumSet.of(max, sum, count));
+
return metrics;
}
diff --git a/metrics/src/main/java/ai/vespa/metrics/set/VespaMetricSet.java b/metrics/src/main/java/ai/vespa/metrics/set/VespaMetricSet.java
index e703011ef5f..778d6963e19 100644
--- a/metrics/src/main/java/ai/vespa/metrics/set/VespaMetricSet.java
+++ b/metrics/src/main/java/ai/vespa/metrics/set/VespaMetricSet.java
@@ -116,10 +116,6 @@ public class VespaMetricSet {
// Routing layer metrics
addMetric(metrics, RoutingLayerMetrics.WORKER_CONNECTIONS.max()); // Hosted Vespa only (routing layer)
- // Embedders
- addMetric(metrics, ContainerMetrics.EMBEDDER_LATENCY, EnumSet.of(max, sum, count));
- addMetric(metrics, ContainerMetrics.EMBEDDER_SEQUENCE_LENGTH, EnumSet.of(max, sum, count));
-
return metrics;
}
@@ -237,6 +233,10 @@ public class VespaMetricSet {
addMetric(metrics, ContainerMetrics.FEED_LATENCY, EnumSet.of(sum, count, max));
addMetric(metrics, ContainerMetrics.FEED_HTTP_REQUESTS, EnumSet.of(count, rate));
+ // Embedders
+ addMetric(metrics, ContainerMetrics.EMBEDDER_LATENCY, EnumSet.of(max, sum, count));
+ addMetric(metrics, ContainerMetrics.EMBEDDER_SEQUENCE_LENGTH, EnumSet.of(max, sum, count));
+
// Deprecated metrics. TODO: Remove on Vespa 9.
addMetric(metrics, ContainerMetrics.SERVER_REJECTED_REQUESTS, EnumSet.of(rate, count));
addMetric(metrics, ContainerMetrics.SERVER_THREAD_POOL_SIZE, EnumSet.of(max, last));