summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2020-11-24 05:45:54 +0000
committerHenning Baldersheim <balder@yahoo-inc.com>2020-11-24 13:05:21 +0000
commit1545c0208a32e96db1bf17237b465757e7eab617 (patch)
tree5104d2d02273eabf8e8a6d6615daa0f127b393db
parent6534a31a780aec69a208c11ac50d43a3621773a0 (diff)
Remove load type from Context
-rw-r--r--persistence/src/vespa/persistence/conformancetest/conformancetest.cpp108
-rw-r--r--persistence/src/vespa/persistence/spi/context.cpp5
-rw-r--r--persistence/src/vespa/persistence/spi/context.h14
-rw-r--r--searchcore/src/apps/vespa-feed-bm/spi_bm_feed_handler.cpp6
-rw-r--r--searchcore/src/tests/proton/persistenceengine/persistenceengine_test.cpp54
-rw-r--r--searchcore/src/vespa/searchcore/proton/persistenceengine/persistenceengine.cpp4
-rw-r--r--storage/src/tests/persistence/common/filestortestfixture.cpp7
-rw-r--r--storage/src/tests/persistence/common/filestortestfixture.h2
-rw-r--r--storage/src/tests/persistence/filestorage/filestormanagertest.cpp14
-rw-r--r--storage/src/tests/persistence/filestorage/operationabortingtest.cpp2
-rw-r--r--storage/src/tests/persistence/mergehandlertest.cpp2
-rw-r--r--storage/src/tests/persistence/persistencetestutils.cpp49
-rw-r--r--storage/src/tests/persistence/persistencethread_splittest.cpp6
-rw-r--r--storage/src/tests/persistence/splitbitdetectortest.cpp7
-rw-r--r--storage/src/tests/persistence/testandsettest.cpp2
-rw-r--r--storage/src/vespa/storage/distributor/operations/idealstate/idealstateoperation.cpp1
-rw-r--r--storage/src/vespa/storage/distributor/operations/operation.cpp6
-rw-r--r--storage/src/vespa/storage/persistence/filestorage/filestormanager.cpp2
-rw-r--r--storage/src/vespa/storage/persistence/filestorage/mergestatus.cpp4
-rw-r--r--storage/src/vespa/storage/persistence/persistenceutil.cpp2
20 files changed, 122 insertions, 175 deletions
diff --git a/persistence/src/vespa/persistence/conformancetest/conformancetest.cpp b/persistence/src/vespa/persistence/conformancetest/conformancetest.cpp
index 6ad74b660c1..96c55d0d9f2 100644
--- a/persistence/src/vespa/persistence/conformancetest/conformancetest.cpp
+++ b/persistence/src/vespa/persistence/conformancetest/conformancetest.cpp
@@ -31,8 +31,6 @@ using PersistenceProviderUP = std::unique_ptr<PersistenceProvider>;
namespace {
-LoadType defaultLoadType(0, "default");
-
std::unique_ptr<PersistenceProvider> getSpi(ConformanceTest::PersistenceFactory &factory,
const document::TestDocMan &testDocMan) {
PersistenceProviderUP result(factory.getPersistenceImplementation(
@@ -61,7 +59,7 @@ createIterator(PersistenceProvider& spi,
fieldSet = std::make_shared<document::DocIdOnly>();
}
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
return spi.createIterator(b, std::move(fieldSet), sel, versions, context);
}
@@ -152,7 +150,7 @@ doIterate(PersistenceProvider& spi,
std::vector<Chunk> chunks;
while (true) {
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
IterateResult result(spi.iterate(id, maxByteSize, context));
EXPECT_EQ(Result::ErrorType::NONE, result.getErrorCode());
@@ -204,7 +202,7 @@ iterateBucket(PersistenceProvider& spi,
DocumentSelection docSel("");
Selection sel(docSel);
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
CreateIteratorResult iter = spi.createIterator(
bucket,
std::make_shared<document::AllFields>(),
@@ -286,7 +284,7 @@ feedDocs(PersistenceProvider& spi,
uint32_t maxSize = 110)
{
std::vector<DocAndTimestamp> docs;
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
for (uint32_t i = 0; i < numDocs; ++i) {
Document::SP doc(
testDocMan.createRandomDocumentAtLocation(
@@ -333,7 +331,7 @@ TEST_F(ConformanceTest, testBasics)
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket bucket(makeSpiBucket(BucketId(8, 0x01)));
Document::SP doc1 = testDocMan.createRandomDocumentAtLocation(0x01, 1);
Document::SP doc2 = testDocMan.createRandomDocumentAtLocation(0x01, 2);
@@ -428,7 +426,7 @@ TEST_F(ConformanceTest, testListBuckets)
Document::SP doc1 = testDocMan.createRandomDocumentAtLocation(0x01, 1);
Document::SP doc2 = testDocMan.createRandomDocumentAtLocation(0x02, 2);
Document::SP doc3 = testDocMan.createRandomDocumentAtLocation(0x03, 3);
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
spi->createBucket(bucket1, context);
spi->createBucket(bucket2, context);
spi->createBucket(bucket3, context);
@@ -461,7 +459,7 @@ TEST_F(ConformanceTest, testBucketInfo)
Document::SP doc1 = testDocMan.createRandomDocumentAtLocation(0x01, 1);
Document::SP doc2 = testDocMan.createRandomDocumentAtLocation(0x01, 2);
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
spi->createBucket(bucket, context);
spi->put(bucket, Timestamp(2), doc2, context);
@@ -518,7 +516,7 @@ TEST_F(ConformanceTest, testOrderIndependentBucketInfo)
Document::SP doc1 = testDocMan.createRandomDocumentAtLocation(0x01, 1);
Document::SP doc2 = testDocMan.createRandomDocumentAtLocation(0x01, 2);
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
spi->createBucket(bucket, context);
BucketChecksum checksumOrdered(0);
@@ -557,7 +555,7 @@ TEST_F(ConformanceTest, testPut)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket bucket(makeSpiBucket(BucketId(8, 0x01)));
Document::SP doc1 = testDocMan.createRandomDocumentAtLocation(0x01, 1);
@@ -582,7 +580,7 @@ TEST_F(ConformanceTest, testPutNewDocumentVersion)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket bucket(makeSpiBucket(BucketId(8, 0x01)));
Document::SP doc1 = testDocMan.createRandomDocumentAtLocation(0x01, 1);
@@ -633,7 +631,7 @@ TEST_F(ConformanceTest, testPutOlderDocumentVersion)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket bucket(makeSpiBucket(BucketId(8, 0x01)));
Document::SP doc1 = testDocMan.createRandomDocumentAtLocation(0x01, 1);
@@ -677,7 +675,7 @@ TEST_F(ConformanceTest, testPutDuplicate)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket bucket(makeSpiBucket(BucketId(8, 0x01)));
Document::SP doc1 = testDocMan.createRandomDocumentAtLocation(0x01, 1);
@@ -709,7 +707,7 @@ TEST_F(ConformanceTest, testRemove)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket bucket(makeSpiBucket(BucketId(8, 0x01)));
Document::SP doc1 = testDocMan.createRandomDocumentAtLocation(0x01, 1);
@@ -802,7 +800,7 @@ TEST_F(ConformanceTest, testRemoveMerge)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket bucket(makeSpiBucket(BucketId(8, 0x01)));
Document::SP doc1 = testDocMan.createRandomDocumentAtLocation(0x01, 1);
@@ -897,7 +895,7 @@ TEST_F(ConformanceTest, testUpdate)
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
Document::SP doc1 = testDocMan.createRandomDocumentAtLocation(0x01, 1);
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket bucket(makeSpiBucket(BucketId(8, 0x01)));
spi->createBucket(bucket, context);
@@ -996,7 +994,7 @@ TEST_F(ConformanceTest, testGet)
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
Document::SP doc1 = testDocMan.createRandomDocumentAtLocation(0x01, 1);
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket bucket(makeSpiBucket(BucketId(8, 0x01)));
spi->createBucket(bucket, context);
@@ -1038,7 +1036,7 @@ TEST_F(ConformanceTest, testIterateCreateIterator)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket b(makeSpiBucket(BucketId(8, 0x1)));
spi->createBucket(b, context);
@@ -1057,7 +1055,7 @@ TEST_F(ConformanceTest, testIterateWithUnknownId)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket b(makeSpiBucket(BucketId(8, 0x1)));
spi->createBucket(b, context);
@@ -1071,7 +1069,7 @@ TEST_F(ConformanceTest, testIterateDestroyIterator)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket b(makeSpiBucket(BucketId(8, 0x1)));
spi->createBucket(b, context);
@@ -1103,7 +1101,7 @@ TEST_F(ConformanceTest, testIterateAllDocs)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket b(makeSpiBucket(BucketId(8, 0x1)));
spi->createBucket(b, context);
@@ -1121,7 +1119,7 @@ TEST_F(ConformanceTest, testIterateAllDocsNewestVersionOnly)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket b(makeSpiBucket(BucketId(8, 0x1)));
spi->createBucket(b, context);
@@ -1149,7 +1147,7 @@ TEST_F(ConformanceTest, testIterateChunked)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket b(makeSpiBucket(BucketId(8, 0x1)));
spi->createBucket(b, context);
@@ -1169,7 +1167,7 @@ TEST_F(ConformanceTest, testMaxByteSize)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket b(makeSpiBucket(BucketId(8, 0x1)));
spi->createBucket(b, context);
@@ -1195,7 +1193,7 @@ TEST_F(ConformanceTest, testIterateMatchTimestampRange)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket b(makeSpiBucket(BucketId(8, 0x1)));
spi->createBucket(b, context);
@@ -1233,7 +1231,7 @@ TEST_F(ConformanceTest, testIterateExplicitTimestampSubset)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket b(makeSpiBucket(BucketId(8, 0x1)));
spi->createBucket(b, context);
@@ -1282,7 +1280,7 @@ TEST_F(ConformanceTest, testIterateRemoves)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket b(makeSpiBucket(BucketId(8, 0x1)));
spi->createBucket(b, context);
@@ -1332,7 +1330,7 @@ TEST_F(ConformanceTest, testIterateMatchSelection)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket b(makeSpiBucket(BucketId(8, 0x1)));
spi->createBucket(b, context);
@@ -1362,7 +1360,7 @@ TEST_F(ConformanceTest, testIterationRequiringDocumentIdOnlyMatching)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket b(makeSpiBucket(BucketId(8, 0x1)));
spi->createBucket(b, context);
@@ -1392,7 +1390,7 @@ TEST_F(ConformanceTest, testIterateBadDocumentSelection)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket b(makeSpiBucket(BucketId(8, 0x1)));
spi->createBucket(b, context);
{
@@ -1426,7 +1424,7 @@ TEST_F(ConformanceTest, testIterateAlreadyCompleted)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket b(makeSpiBucket(BucketId(8, 0x1)));
spi->createBucket(b, context);
@@ -1450,7 +1448,7 @@ TEST_F(ConformanceTest, testIterateEmptyBucket)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket b(makeSpiBucket(BucketId(8, 0x1)));
spi->createBucket(b, context);
Selection sel(createSelection(""));
@@ -1470,7 +1468,7 @@ TEST_F(ConformanceTest, testDeleteBucket)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Document::SP doc1 = testDocMan.createRandomDocumentAtLocation(0x01, 1);
Bucket bucket(makeSpiBucket(BucketId(8, 0x01)));
@@ -1495,7 +1493,7 @@ testDeleteBucketPostCondition(const PersistenceProvider &spi,
const Bucket &bucket,
const Document &doc1)
{
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
{
GetResult result = spi.get(bucket,
document::AllFields(),
@@ -1513,7 +1511,7 @@ TEST_F(ConformanceTest, testSplitNormalCase)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket bucketA(makeSpiBucket(BucketId(3, 0x02)));
Bucket bucketB(makeSpiBucket(BucketId(3, 0x06)));
@@ -1555,7 +1553,7 @@ testSplitNormalCasePostCondition(const PersistenceProvider &spi,
EXPECT_EQ(10, (int)spi.getBucketInfo(bucketB).getBucketInfo().getDocumentCount());
document::AllFields fs;
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
for (uint32_t i = 0; i < 10; ++i) {
Document::UP doc1 = testDocMan.createRandomDocumentAtLocation(0x02, i);
EXPECT_TRUE(spi.get(bucketA, fs, doc1->getId(), context).hasDocument());
@@ -1576,7 +1574,7 @@ TEST_F(ConformanceTest, testSplitTargetExists)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket bucketA(makeSpiBucket(BucketId(3, 0x02)));
Bucket bucketB(makeSpiBucket(BucketId(3, 0x06)));
@@ -1633,7 +1631,7 @@ testSplitTargetExistsPostCondition(const PersistenceProvider &spi,
getDocumentCount());
document::AllFields fs;
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
for (uint32_t i = 0; i < 10; ++i) {
Document::UP doc1 = testDocMan.createRandomDocumentAtLocation(0x02, i);
EXPECT_TRUE(
@@ -1660,7 +1658,7 @@ TEST_F(ConformanceTest, testSplitSingleDocumentInSource)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket target1(makeSpiBucket(BucketId(3, 0x02)));
Bucket target2(makeSpiBucket(BucketId(3, 0x06)));
@@ -1696,7 +1694,7 @@ ConformanceTest::testSplitSingleDocumentInSourcePostCondition(
EXPECT_EQ(uint32_t(1), spi.getBucketInfo(target2).getBucketInfo().getDocumentCount());
document::AllFields fs;
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Document::UP doc = testDocMan.createRandomDocumentAtLocation(0x06, 0);
EXPECT_TRUE(spi.get(target2, fs, doc->getId(), context).hasDocument());
EXPECT_TRUE(!spi.get(target1, fs, doc->getId(), context).hasDocument());
@@ -1710,7 +1708,7 @@ ConformanceTest::createAndPopulateJoinSourceBuckets(
const Bucket& source2,
document::TestDocMan& testDocMan)
{
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
spi.createBucket(source1, context);
spi.createBucket(source2, context);
@@ -1741,7 +1739,7 @@ ConformanceTest::doTestJoinNormalCase(const Bucket& source1,
createAndPopulateJoinSourceBuckets(*spi, source1, source2, testDocMan);
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
spi->join(source1, source2, target, context);
testJoinNormalCasePostCondition(*spi, source1, source2, target, testDocMan);
@@ -1780,7 +1778,7 @@ testJoinNormalCasePostCondition(const PersistenceProvider &spi,
EXPECT_EQ(20, (int)spi.getBucketInfo(bucketC).getBucketInfo().getDocumentCount());
document::AllFields fs;
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
for (uint32_t i = 0; i < 10; ++i) {
Document::UP doc(
testDocMan.createRandomDocumentAtLocation(
@@ -1802,7 +1800,7 @@ TEST_F(ConformanceTest, testJoinTargetExists)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket bucketA(makeSpiBucket(BucketId(3, 0x02)));
spi->createBucket(bucketA, context);
@@ -1851,7 +1849,7 @@ testJoinTargetExistsPostCondition(const PersistenceProvider &spi,
EXPECT_EQ(30, (int)spi.getBucketInfo(bucketC).getBucketInfo().getDocumentCount());
document::AllFields fs;
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
for (uint32_t i = 0; i < 10; ++i) {
Document::UP doc1 = testDocMan.createRandomDocumentAtLocation(0x02, i);
EXPECT_TRUE(spi.get(bucketC, fs, doc1->getId(), context).hasDocument());
@@ -1891,7 +1889,7 @@ TEST_F(ConformanceTest, testJoinOneBucket)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket bucketA(makeSpiBucket(BucketId(3, 0x02)));
spi->createBucket(bucketA, context);
@@ -1921,7 +1919,7 @@ testJoinOneBucketPostCondition(const PersistenceProvider &spi,
EXPECT_EQ(10, (int)spi.getBucketInfo(bucketC).getBucketInfo().getDocumentCount());
document::AllFields fs;
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
for (uint32_t i = 0; i < 10; ++i) {
Document::UP doc1 = testDocMan.createRandomDocumentAtLocation(0x02, i);
EXPECT_TRUE(spi.get(bucketC, fs, doc1->getId(), context).hasDocument());
@@ -1947,7 +1945,7 @@ ConformanceTest::doTestJoinSameSourceBuckets(const Bucket& source, const Bucket&
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
spi->createBucket(source, context);
populateBucket(source, *spi, context, 0, 10, testDocMan);
@@ -1986,7 +1984,7 @@ ConformanceTest::testJoinSameSourceBucketsTargetExistsPostCondition(
EXPECT_EQ(20, (int)spi.getBucketInfo(target).getBucketInfo().getDocumentCount());
document::AllFields fs;
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
for (uint32_t i = 0; i < 20; ++i) {
Document::UP doc1 = testDocMan.createRandomDocumentAtLocation(0x02, i);
EXPECT_TRUE(spi.get(target, fs, doc1->getId(), context).hasDocument());
@@ -1999,7 +1997,7 @@ TEST_F(ConformanceTest, testJoinSameSourceBucketsTargetExists)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket source(makeSpiBucket(BucketId(3, 0x02)));
spi->createBucket(source, context);
@@ -2038,7 +2036,7 @@ TEST_F(ConformanceTest, testBucketActivation)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket bucket(makeSpiBucket(BucketId(8, 0x01)));
spi->setClusterState(makeBucketSpace(), createClusterState());
@@ -2081,7 +2079,7 @@ TEST_F(SingleDocTypeConformanceTest, testBucketActivationSplitAndJoin)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket bucketA(makeSpiBucket(BucketId(3, 0x02)));
Bucket bucketB(makeSpiBucket(BucketId(3, 0x06)));
@@ -2159,7 +2157,7 @@ TEST_F(ConformanceTest, testRemoveEntry)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
Bucket bucket(makeSpiBucket(BucketId(8, 0x01)));
Document::SP doc1 = testDocMan.createRandomDocumentAtLocation(0x01, 1);
@@ -2227,7 +2225,7 @@ TEST_F(ConformanceTest, testBucketSpaces)
document::TestDocMan testDocMan;
_factory->clear();
PersistenceProviderUP spi(getSpi(*_factory, testDocMan));
- Context context(defaultLoadType, Priority(0), Trace::TraceLevel(0));
+ Context context(Priority(0), Trace::TraceLevel(0));
BucketSpace bucketSpace0(makeBucketSpace("testdoctype1"));
BucketSpace bucketSpace1(makeBucketSpace("testdoctype2"));
BucketSpace bucketSpace2(makeBucketSpace("no"));
diff --git a/persistence/src/vespa/persistence/spi/context.cpp b/persistence/src/vespa/persistence/spi/context.cpp
index 429e2fb9d4e..80f5f05c59b 100644
--- a/persistence/src/vespa/persistence/spi/context.cpp
+++ b/persistence/src/vespa/persistence/spi/context.cpp
@@ -4,9 +4,8 @@
namespace storage::spi {
-Context::Context(const LoadType& loadType, Priority pri, int maxTraceLevel)
- : _loadType(&loadType),
- _priority(pri),
+Context::Context(Priority pri, int maxTraceLevel)
+ : _priority(pri),
_trace(maxTraceLevel),
_readConsistency(ReadConsistency::STRONG)
{ }
diff --git a/persistence/src/vespa/persistence/spi/context.h b/persistence/src/vespa/persistence/spi/context.h
index a1cb9e68f31..1fd7805b471 100644
--- a/persistence/src/vespa/persistence/spi/context.h
+++ b/persistence/src/vespa/persistence/spi/context.h
@@ -32,12 +32,8 @@
#include "read_consistency.h"
#include <vespa/vespalib/trace/trace.h>
-namespace metrics { class LoadType; }
-
namespace storage::spi {
-using LoadType = metrics::LoadType;
-
typedef uint16_t Priority; // 0 - max pri, 255 - min pri
// Define this type just because a ton of tests currently use it.
@@ -46,18 +42,15 @@ struct Trace {
};
class Context {
- const LoadType* _loadType;
Priority _priority;
vespalib::Trace _trace;
ReadConsistency _readConsistency;
-
public:
Context(Context &&) = default;
Context & operator = (Context &&) = default;
- Context(const LoadType& loadType, Priority pri, int maxTraceLevel);
+ Context(Priority pri, int maxTraceLevel);
~Context();
- const LoadType& getLoadType() const { return *_loadType; }
Priority getPriority() const { return _priority; }
/**
@@ -81,8 +74,9 @@ public:
const vespalib::Trace& getTrace() const { return _trace; }
bool shouldTrace(int level) { return _trace.shouldTrace(level); }
- void trace(int level, vespalib::stringref msg, bool addTime = true)
- { _trace.trace(level, msg, addTime); }
+ void trace(int level, vespalib::stringref msg, bool addTime = true) {
+ _trace.trace(level, msg, addTime);
+ }
};
}
diff --git a/searchcore/src/apps/vespa-feed-bm/spi_bm_feed_handler.cpp b/searchcore/src/apps/vespa-feed-bm/spi_bm_feed_handler.cpp
index 24439a10925..daebc8a7a47 100644
--- a/searchcore/src/apps/vespa-feed-bm/spi_bm_feed_handler.cpp
+++ b/searchcore/src/apps/vespa-feed-bm/spi_bm_feed_handler.cpp
@@ -6,7 +6,6 @@
#include <vespa/document/fieldset/fieldsetrepo.h>
#include <vespa/document/fieldvalue/document.h>
#include <vespa/document/update/documentupdate.h>
-#include <vespa/metrics/loadtype.h>
#include <vespa/persistence/spi/persistenceprovider.h>
using document::Document;
@@ -20,8 +19,7 @@ namespace feedbm {
namespace {
-storage::spi::LoadType default_load_type(0, "default");
-storage::spi::Context context(default_load_type, storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
+storage::spi::Context context(storage::spi::Priority(0), 0);
void get_bucket_info_loop(PendingTracker &tracker)
{
@@ -38,7 +36,7 @@ class MyOperationComplete : public storage::spi::OperationComplete
PendingTracker& _tracker;
public:
MyOperationComplete(std::atomic<uint32_t> &errors, const Bucket& bucket, PendingTracker& tracker);
- ~MyOperationComplete();
+ ~MyOperationComplete() override;
void onComplete(std::unique_ptr<storage::spi::Result> result) override;
void addResultHandler(const storage::spi::ResultHandler* resultHandler) override;
};
diff --git a/searchcore/src/tests/proton/persistenceengine/persistenceengine_test.cpp b/searchcore/src/tests/proton/persistenceengine/persistenceengine_test.cpp
index 2b7bacfaec0..95a41a255ce 100644
--- a/searchcore/src/tests/proton/persistenceengine/persistenceengine_test.cpp
+++ b/searchcore/src/tests/proton/persistenceengine/persistenceengine_test.cpp
@@ -453,8 +453,7 @@ TEST_F("require that getPartitionStates() prepares all handlers", SimpleFixture)
TEST_F("require that puts are routed to handler", SimpleFixture)
{
- storage::spi::LoadType loadType(0, "default");
- Context context(loadType, storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
+ Context context(storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
f.engine.put(bucket1, tstamp1, doc1, context);
TEST_DO(assertHandler(bucket1, tstamp1, docId1, f.hset.handler1));
TEST_DO(assertHandler(bucket0, tstamp0, docId0, f.hset.handler2));
@@ -473,8 +472,7 @@ TEST_F("require that put is rejected if resource limit is reached", SimpleFixtur
f._writeFilter._acceptWriteOperation = false;
f._writeFilter._message = "Disk is full";
- storage::spi::LoadType loadType(0, "default");
- Context context(loadType, storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
+ Context context(storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
EXPECT_EQUAL(
Result(Result::ErrorType::RESOURCE_EXHAUSTED,
"Put operation rejected for document 'id:type3:type3::1': 'Disk is full'"),
@@ -484,8 +482,7 @@ TEST_F("require that put is rejected if resource limit is reached", SimpleFixtur
TEST_F("require that updates are routed to handler", SimpleFixture)
{
- storage::spi::LoadType loadType(0, "default");
- Context context(loadType, storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
+ Context context(storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
f.hset.handler1.setExistingTimestamp(tstamp2);
UpdateResult ur = f.engine.update(bucket1, tstamp1, upd1, context);
TEST_DO(assertHandler(bucket1, tstamp1, docId1, f.hset.handler1));
@@ -504,8 +501,7 @@ TEST_F("require that updates are routed to handler", SimpleFixture)
TEST_F("require that updates with bad ids are rejected", SimpleFixture)
{
- storage::spi::LoadType loadType(0, "default");
- Context context(loadType, storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
+ Context context(storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
EXPECT_EQUAL(UpdateResult(Result::ErrorType::PERMANENT_ERROR, "Update operation rejected due to bad id (id:type2:type2::1, type1)"),
f.engine.update(bucket1, tstamp1, bad_id_upd, context));
@@ -516,8 +512,7 @@ TEST_F("require that update is rejected if resource limit is reached", SimpleFix
f._writeFilter._acceptWriteOperation = false;
f._writeFilter._message = "Disk is full";
- storage::spi::LoadType loadType(0, "default");
- Context context(loadType, storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
+ Context context(storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
EXPECT_EQUAL(
Result(Result::ErrorType::RESOURCE_EXHAUSTED,
@@ -528,8 +523,7 @@ TEST_F("require that update is rejected if resource limit is reached", SimpleFix
TEST_F("require that removes are routed to handlers", SimpleFixture)
{
- storage::spi::LoadType loadType(0, "default");
- Context context(loadType, storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
+ Context context(storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
RemoveResult rr = f.engine.remove(bucket1, tstamp1, docId3, context);
TEST_DO(assertHandler(bucket0, tstamp0, docId0, f.hset.handler1));
TEST_DO(assertHandler(bucket0, tstamp0, docId0, f.hset.handler2));
@@ -565,8 +559,7 @@ TEST_F("require that remove is NOT rejected if resource limit is reached", Simpl
f._writeFilter._acceptWriteOperation = false;
f._writeFilter._message = "Disk is full";
- storage::spi::LoadType loadType(0, "default");
- Context context(loadType, storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
+ Context context(storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
EXPECT_EQUAL(RemoveResult(false), f.engine.remove(bucket1, tstamp1, docId1, context));
}
@@ -618,8 +611,7 @@ TEST_F("require that getBucketInfo() is routed to handlers and merged", SimpleFi
TEST_F("require that createBucket() is routed to handlers and merged", SimpleFixture)
{
- storage::spi::LoadType loadType(0, "default");
- Context context(loadType, storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
+ Context context(storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
f.hset.handler1._createBucketResult = Result(Result::ErrorType::TRANSIENT_ERROR, "err1a");
f.hset.handler2._createBucketResult = Result(Result::ErrorType::PERMANENT_ERROR, "err2a");
@@ -631,8 +623,7 @@ TEST_F("require that createBucket() is routed to handlers and merged", SimpleFix
TEST_F("require that deleteBucket() is routed to handlers and merged", SimpleFixture)
{
- storage::spi::LoadType loadType(0, "default");
- Context context(loadType, storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
+ Context context(storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
f.hset.handler1.deleteBucketResult = Result(Result::ErrorType::TRANSIENT_ERROR, "err1");
f.hset.handler2.deleteBucketResult = Result(Result::ErrorType::PERMANENT_ERROR, "err2");
@@ -650,8 +641,7 @@ TEST_F("require that getModifiedBuckets() is routed to handlers and merged", Sim
TEST_F("require that get is sent to all handlers", SimpleFixture) {
- storage::spi::LoadType loadType(0, "default");
- Context context(loadType, storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
+ Context context(storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
GetResult result = f.engine.get(bucket1, document::AllFields(), docId1, context);
EXPECT_EQUAL(docId1, f.hset.handler1.lastDocId);
@@ -661,8 +651,7 @@ TEST_F("require that get is sent to all handlers", SimpleFixture) {
TEST_F("require that get freezes the bucket", SimpleFixture) {
EXPECT_FALSE(f.hset.handler1.wasFrozen(bucket1));
EXPECT_FALSE(f.hset.handler2.wasFrozen(bucket1));
- storage::spi::LoadType loadType(0, "default");
- Context context(loadType, storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
+ Context context(storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
f.engine.get(bucket1, document::AllFields(), docId1, context);
EXPECT_TRUE(f.hset.handler1.wasFrozen(bucket1));
EXPECT_TRUE(f.hset.handler2.wasFrozen(bucket1));
@@ -673,8 +662,7 @@ TEST_F("require that get freezes the bucket", SimpleFixture) {
TEST_F("require that get returns the first document found", SimpleFixture) {
f.hset.handler1.setDocument(*doc1, tstamp1);
f.hset.handler2.setDocument(*doc2, tstamp2);
- storage::spi::LoadType loadType(0, "default");
- Context context(loadType, storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
+ Context context(storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
GetResult result = f.engine.get(bucket1, document::AllFields(), docId1, context);
EXPECT_EQUAL(docId1, f.hset.handler1.lastDocId);
@@ -687,8 +675,7 @@ TEST_F("require that get returns the first document found", SimpleFixture) {
}
TEST_F("require that createIterator does", SimpleFixture) {
- storage::spi::LoadType loadType(0, "default");
- Context context(loadType, storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
+ Context context(storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
CreateIteratorResult result =
f.engine.createIterator(bucket1, std::make_shared<document::AllFields>(), selection,
storage::spi::NEWEST_DOCUMENT_ONLY, context);
@@ -701,8 +688,7 @@ TEST_F("require that createIterator does", SimpleFixture) {
}
TEST_F("require that iterator ids are unique", SimpleFixture) {
- storage::spi::LoadType loadType(0, "default");
- Context context(loadType, storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
+ Context context(storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
CreateIteratorResult result =
f.engine.createIterator(bucket1, std::make_shared<document::AllFields>(), selection,
storage::spi::NEWEST_DOCUMENT_ONLY, context);
@@ -716,8 +702,7 @@ TEST_F("require that iterator ids are unique", SimpleFixture) {
TEST_F("require that iterate requires valid iterator", SimpleFixture) {
uint64_t max_size = 1024;
- storage::spi::LoadType loadType(0, "default");
- Context context(loadType, storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
+ Context context(storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
IterateResult it_result = f.engine.iterate(IteratorId(1), max_size, context);
EXPECT_TRUE(it_result.hasError());
EXPECT_EQUAL(Result::ErrorType::PERMANENT_ERROR, it_result.getErrorCode());
@@ -736,8 +721,7 @@ TEST_F("require that iterate returns documents", SimpleFixture) {
f.hset.handler1.setDocument(*doc1, tstamp1);
f.hset.handler2.setDocument(*doc2, tstamp2);
- storage::spi::LoadType loadType(0, "default");
- Context context(loadType, storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
+ Context context(storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
uint64_t max_size = 1024;
CreateIteratorResult result =
f.engine.createIterator(bucket1, std::make_shared<document::AllFields>(), selection,
@@ -752,8 +736,7 @@ TEST_F("require that iterate returns documents", SimpleFixture) {
TEST_F("require that destroyIterator prevents iteration", SimpleFixture) {
f.hset.handler1.setDocument(*doc1, tstamp1);
- storage::spi::LoadType loadType(0, "default");
- Context context(loadType, storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
+ Context context(storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
CreateIteratorResult create_result =
f.engine.createIterator(bucket1, std::make_shared<document::AllFields>(), selection,
storage::spi::NEWEST_DOCUMENT_ONLY, context);
@@ -773,8 +756,7 @@ TEST_F("require that destroyIterator prevents iteration", SimpleFixture) {
TEST_F("require that buckets are frozen during iterator life", SimpleFixture) {
EXPECT_FALSE(f.hset.handler1.isFrozen(bucket1));
EXPECT_FALSE(f.hset.handler2.isFrozen(bucket1));
- storage::spi::LoadType loadType(0, "default");
- Context context(loadType, storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
+ Context context(storage::spi::Priority(0), storage::spi::Trace::TraceLevel(0));
CreateIteratorResult create_result =
f.engine.createIterator(bucket1, std::make_shared<document::AllFields>(), selection,
storage::spi::NEWEST_DOCUMENT_ONLY, context);
diff --git a/searchcore/src/vespa/searchcore/proton/persistenceengine/persistenceengine.cpp b/searchcore/src/vespa/searchcore/proton/persistenceengine/persistenceengine.cpp
index 0eec650cfdb..02efd1ef11f 100644
--- a/searchcore/src/vespa/searchcore/proton/persistenceengine/persistenceengine.cpp
+++ b/searchcore/src/vespa/searchcore/proton/persistenceengine/persistenceengine.cpp
@@ -611,9 +611,7 @@ PersistenceEngine::join(const Bucket& source1, const Bucket& source2, const Buck
void
PersistenceEngine::destroyIterators()
{
- Context context(storage::spi::LoadType(0, "default"),
- storage::spi::Priority(0x80),
- storage::spi::Trace::TraceLevel(0));
+ Context context(storage::spi::Priority(0x80), 0);
for (;;) {
IteratorId id;
{
diff --git a/storage/src/tests/persistence/common/filestortestfixture.cpp b/storage/src/tests/persistence/common/filestortestfixture.cpp
index c6a0bdbb540..646e9df7258 100644
--- a/storage/src/tests/persistence/common/filestortestfixture.cpp
+++ b/storage/src/tests/persistence/common/filestortestfixture.cpp
@@ -15,7 +15,6 @@ using document::test::makeDocumentBucket;
namespace storage {
-spi::LoadType FileStorTestFixture::defaultLoadType = spi::LoadType(0, "default");
const uint32_t FileStorTestFixture::MSG_WAIT_TIME;
void
@@ -51,10 +50,8 @@ FileStorTestFixture::TearDown()
void
FileStorTestFixture::createBucket(const document::BucketId& bid)
{
- spi::Context context(defaultLoadType, spi::Priority(0),
- spi::Trace::TraceLevel(0));
- _node->getPersistenceProvider().createBucket(
- makeSpiBucket(bid), context);
+ spi::Context context(spi::Priority(0), spi::Trace::TraceLevel(0));
+ _node->getPersistenceProvider().createBucket(makeSpiBucket(bid), context);
StorBucketDatabase::WrappedEntry entry(
_node->getStorageBucketDatabase().get(bid, "foo",
diff --git a/storage/src/tests/persistence/common/filestortestfixture.h b/storage/src/tests/persistence/common/filestortestfixture.h
index dcfeb42b4fd..69866f7bbf2 100644
--- a/storage/src/tests/persistence/common/filestortestfixture.h
+++ b/storage/src/tests/persistence/common/filestortestfixture.h
@@ -15,8 +15,6 @@ namespace storage {
class FileStorTestFixture : public ::testing::Test
{
public:
- static spi::LoadType defaultLoadType;
-
std::unique_ptr<TestServiceLayerApp> _node;
std::unique_ptr<vdstestlib::DirConfig> _config;
const document::DocumentType* _testdoctype1;
diff --git a/storage/src/tests/persistence/filestorage/filestormanagertest.cpp b/storage/src/tests/persistence/filestorage/filestormanagertest.cpp
index 7cfe7ea3761..3cac188cb17 100644
--- a/storage/src/tests/persistence/filestorage/filestormanagertest.cpp
+++ b/storage/src/tests/persistence/filestorage/filestormanagertest.cpp
@@ -56,7 +56,7 @@ namespace storage {
namespace {
-spi::LoadType defaultLoadType(0, "default");
+metrics::LoadType defaultLoadType(0, "default");
struct TestFileStorComponents;
@@ -86,7 +86,7 @@ struct FileStorTestBase : Test {
void TearDown() override;
void createBucket(document::BucketId bid) {
- spi::Context context(defaultLoadType, spi::Priority(0), spi::Trace::TraceLevel(0));
+ spi::Context context(spi::Priority(0), spi::Trace::TraceLevel(0));
_node->getPersistenceProvider().createBucket(makeSpiBucket(bid), context);
StorBucketDatabase::WrappedEntry entry(
@@ -728,7 +728,7 @@ TEST_F(FileStorManagerTest, priority) {
for (uint32_t i=0; i<documents.size(); ++i) {
document::BucketId bucket(16, factory.getBucketId(documents[i]->getId()).getRawId());
- spi::Context context(defaultLoadType, spi::Priority(0), spi::Trace::TraceLevel(0));
+ spi::Context context(spi::Priority(0), spi::Trace::TraceLevel(0));
_node->getPersistenceProvider().createBucket(makeSpiBucket(bucket), context);
}
@@ -790,8 +790,7 @@ TEST_F(FileStorManagerTest, split1) {
documents.push_back(doc);
}
document::BucketIdFactory factory;
- spi::Context context(defaultLoadType, spi::Priority(0),
- spi::Trace::TraceLevel(0));
+ spi::Context context(spi::Priority(0), spi::Trace::TraceLevel(0));
{
// Populate bucket with the given data
for (uint32_t i=0; i<documents.size(); ++i) {
@@ -905,7 +904,7 @@ TEST_F(FileStorManagerTest, split_single_group) {
auto& top = c.top;
setClusterState("storage:2 distributor:1");
- spi::Context context(defaultLoadType, spi::Priority(0), spi::Trace::TraceLevel(0));
+ spi::Context context(spi::Priority(0), spi::Trace::TraceLevel(0));
for (uint32_t j=0; j<1; ++j) {
// Test this twice, once where all the data ends up in file with
// splitbit set, and once where all the data ends up in file with
@@ -984,8 +983,7 @@ FileStorTestBase::putDoc(DummyStorageLink& top,
uint32_t docNum)
{
api::StorageMessageAddress address("storage", lib::NodeType::STORAGE, 3);
- spi::Context context(defaultLoadType, spi::Priority(0),
- spi::Trace::TraceLevel(0));
+ spi::Context context(spi::Priority(0), spi::Trace::TraceLevel(0));
document::BucketIdFactory factory;
document::DocumentId docId(vespalib::make_string("id:ns:testdoctype1:n=%" PRIu64 ":%d", target.getId(), docNum));
document::BucketId bucket(16, factory.getBucketId(docId).getRawId());
diff --git a/storage/src/tests/persistence/filestorage/operationabortingtest.cpp b/storage/src/tests/persistence/filestorage/operationabortingtest.cpp
index eb7f2f883ab..0582aa5c6b3 100644
--- a/storage/src/tests/persistence/filestorage/operationabortingtest.cpp
+++ b/storage/src/tests/persistence/filestorage/operationabortingtest.cpp
@@ -72,7 +72,7 @@ public:
}
};
-spi::LoadType defaultLoadType(0, "default");
+metrics::LoadType defaultLoadType(0, "default");
}
diff --git a/storage/src/tests/persistence/mergehandlertest.cpp b/storage/src/tests/persistence/mergehandlertest.cpp
index 81f98136575..fd01d1683de 100644
--- a/storage/src/tests/persistence/mergehandlertest.cpp
+++ b/storage/src/tests/persistence/mergehandlertest.cpp
@@ -176,7 +176,7 @@ MergeHandlerTest::HandleApplyBucketDiffReplyInvoker::~HandleApplyBucketDiffReply
void
MergeHandlerTest::SetUp() {
- _context.reset(new spi::Context(documentapi::LoadType::DEFAULT, 0, 0));
+ _context = std::make_unique<spi::Context>(0, 0);
SingleDiskPersistenceTestUtils::SetUp();
_location = 1234;
diff --git a/storage/src/tests/persistence/persistencetestutils.cpp b/storage/src/tests/persistence/persistencetestutils.cpp
index 47e516a1dcc..278cb36b50c 100644
--- a/storage/src/tests/persistence/persistencetestutils.cpp
+++ b/storage/src/tests/persistence/persistencetestutils.cpp
@@ -26,26 +26,25 @@ namespace storage {
namespace {
- spi::LoadType defaultLoadType(0, "default");
-
- vdstestlib::DirConfig initialize(const std::string & rootOfRoot) {
- vdstestlib::DirConfig config(getStandardConfig(true, rootOfRoot));
- std::string rootFolder = getRootFolder(config);
- vespalib::rmdir(rootFolder, true);
- vespalib::mkdir(vespalib::make_string("%s/disks/d0", rootFolder.c_str()), true);
- return config;
- }
+vdstestlib::DirConfig initialize(const std::string & rootOfRoot) {
+ vdstestlib::DirConfig config(getStandardConfig(true, rootOfRoot));
+ std::string rootFolder = getRootFolder(config);
+ vespalib::rmdir(rootFolder, true);
+ vespalib::mkdir(vespalib::make_string("%s/disks/d0", rootFolder.c_str()), true);
+ return config;
+}
+
+template<typename T>
+struct ConfigReader : public T::Subscriber
+{
+ T config;
- template<typename T>
- struct ConfigReader : public T::Subscriber
- {
- T config;
+ ConfigReader(const std::string& configId) {
+ T::subscribe(configId, *this);
+ }
+ void configure(const T& c) { config = c; }
+};
- ConfigReader(const std::string& configId) {
- T::subscribe(configId, *this);
- }
- void configure(const T& c) { config = c; }
- };
}
PersistenceTestEnvironment::PersistenceTestEnvironment(const std::string & rootOfRoot)
@@ -156,7 +155,7 @@ PersistenceTestUtils::doPutOnDisk(
{
document::Document::SP doc(createRandomDocumentAtLocation(location, timestamp, minSize, maxSize));
spi::Bucket b(makeSpiBucket(document::BucketId(16, location)));
- spi::Context context(defaultLoadType, spi::Priority(0), spi::Trace::TraceLevel(0));
+ spi::Context context(spi::Priority(0), spi::Trace::TraceLevel(0));
getPersistenceProvider().createBucket(b, context);
getPersistenceProvider().put(spi::Bucket(b), timestamp, doc, context);
return doc;
@@ -169,7 +168,7 @@ PersistenceTestUtils::doRemoveOnDisk(
spi::Timestamp timestamp,
bool persistRemove)
{
- spi::Context context(defaultLoadType, spi::Priority(0), spi::Trace::TraceLevel(0));
+ spi::Context context(spi::Priority(0), spi::Trace::TraceLevel(0));
if (persistRemove) {
spi::RemoveResult result = getPersistenceProvider().removeIfFound(makeSpiBucket(bucketId),timestamp, docId, context);
return result.wasFound();
@@ -185,7 +184,7 @@ PersistenceTestUtils::doUnrevertableRemoveOnDisk(
const document::DocumentId& docId,
spi::Timestamp timestamp)
{
- spi::Context context(defaultLoadType, spi::Priority(0),spi::Trace::TraceLevel(0));
+ spi::Context context(spi::Priority(0),spi::Trace::TraceLevel(0));
spi::RemoveResult result = getPersistenceProvider().remove(makeSpiBucket(bucketId), timestamp, docId, context);
return result.wasFound();
}
@@ -194,7 +193,7 @@ spi::GetResult
PersistenceTestUtils::doGetOnDisk(const document::BucketId& bucketId, const document::DocumentId& docId)
{
auto fieldSet = std::make_unique<document::AllFields>();
- spi::Context context(defaultLoadType, spi::Priority(0), spi::Trace::TraceLevel(0));
+ spi::Context context(spi::Priority(0), spi::Trace::TraceLevel(0));
return getPersistenceProvider().get(makeSpiBucket(bucketId), *fieldSet, docId, context);
}
@@ -234,7 +233,7 @@ void
PersistenceTestUtils::doPut(const document::Document::SP& doc, document::BucketId bid, spi::Timestamp time)
{
spi::Bucket b(makeSpiBucket(bid));
- spi::Context context(defaultLoadType, spi::Priority(0), spi::Trace::TraceLevel(0));
+ spi::Context context(spi::Priority(0), spi::Trace::TraceLevel(0));
getPersistenceProvider().createBucket(b, context);
getPersistenceProvider().put(b, time, std::move(doc), context);
}
@@ -244,7 +243,7 @@ PersistenceTestUtils::doUpdate(document::BucketId bid,
const document::DocumentUpdate::SP& update,
spi::Timestamp time)
{
- spi::Context context(defaultLoadType, spi::Priority(0), spi::Trace::TraceLevel(0));
+ spi::Context context(spi::Priority(0), spi::Trace::TraceLevel(0));
return getPersistenceProvider().update(makeSpiBucket(bid), time, update, context);
}
@@ -255,7 +254,7 @@ PersistenceTestUtils::doRemove(const document::DocumentId& id, spi::Timestamp ti
document::BucketId bucket(
_env->_component.getBucketIdFactory().getBucketId(id));
bucket.setUsedBits(usedBits);
- spi::Context context(defaultLoadType, spi::Priority(0), spi::Trace::TraceLevel(0));
+ spi::Context context(spi::Priority(0), spi::Trace::TraceLevel(0));
if (unrevertableRemove) {
getPersistenceProvider().remove(
makeSpiBucket(bucket), time, id, context);
diff --git a/storage/src/tests/persistence/persistencethread_splittest.cpp b/storage/src/tests/persistence/persistencethread_splittest.cpp
index 3dd8075176d..45b9f5aeaac 100644
--- a/storage/src/tests/persistence/persistencethread_splittest.cpp
+++ b/storage/src/tests/persistence/persistencethread_splittest.cpp
@@ -11,9 +11,6 @@ using document::test::makeDocumentBucket;
using namespace ::testing;
namespace storage {
-namespace {
-spi::LoadType defaultLoadType(0, "default");
-}
struct PersistenceThreadSplitTest : public SingleDiskPersistenceTestUtils {
enum SplitCase {
@@ -182,8 +179,7 @@ PersistenceThreadSplitTest::doTest(SplitCase splitCase)
uint64_t location = 0;
uint64_t splitMask = 1ULL << (splitLevelToDivide - 1);
- spi::Context context(defaultLoadType, spi::Priority(0),
- spi::Trace::TraceLevel(0));
+ spi::Context context(spi::Priority(0), spi::Trace::TraceLevel(0));
spi::Bucket bucket(makeSpiBucket(document::BucketId(currentSplitLevel, 1)));
spi::PersistenceProvider& spi(getPersistenceProvider());
spi.deleteBucket(bucket, context);
diff --git a/storage/src/tests/persistence/splitbitdetectortest.cpp b/storage/src/tests/persistence/splitbitdetectortest.cpp
index 69f8268ff2c..4982383685a 100644
--- a/storage/src/tests/persistence/splitbitdetectortest.cpp
+++ b/storage/src/tests/persistence/splitbitdetectortest.cpp
@@ -16,10 +16,6 @@ using namespace ::testing;
namespace storage {
-namespace {
-spi::LoadType defaultLoadType(0, "default");
-}
-
struct SplitBitDetectorTest : Test {
document::TestDocMan testDocMan;
spi::dummy::DummyPersistence provider;
@@ -30,8 +26,7 @@ struct SplitBitDetectorTest : Test {
: testDocMan(),
provider(testDocMan.getTypeRepoSP()),
bucket(makeSpiBucket(document::BucketId(1, 1))),
- context(defaultLoadType, spi::Priority(0),
- spi::Trace::TraceLevel(0))
+ context(spi::Priority(0), spi::Trace::TraceLevel(0))
{
provider.initialize();
provider.createBucket(bucket, context);
diff --git a/storage/src/tests/persistence/testandsettest.cpp b/storage/src/tests/persistence/testandsettest.cpp
index a952e227b70..4b509033d2e 100644
--- a/storage/src/tests/persistence/testandsettest.cpp
+++ b/storage/src/tests/persistence/testandsettest.cpp
@@ -41,7 +41,7 @@ struct TestAndSetTest : SingleDiskPersistenceTestUtils {
TestAndSetTest()
: persistenceHandler(),
asyncHandler(nullptr),
- context(spi::LoadType(0, "default"), 0, 0)
+ context(0, 0)
{}
void SetUp() override {
diff --git a/storage/src/vespa/storage/distributor/operations/idealstate/idealstateoperation.cpp b/storage/src/vespa/storage/distributor/operations/idealstate/idealstateoperation.cpp
index 52c8344b820..bc77f4cf88f 100644
--- a/storage/src/vespa/storage/distributor/operations/idealstate/idealstateoperation.cpp
+++ b/storage/src/vespa/storage/distributor/operations/idealstate/idealstateoperation.cpp
@@ -105,7 +105,6 @@ IdealStateOperation::setCommandMeta(api::MaintenanceCommand& cmd) const
{
cmd.setPriority(_priority);
cmd.setReason(_detailedReason);
- cmd.setLoadType((*_manager->getLoadTypes())["maintenance"]);
}
std::string
diff --git a/storage/src/vespa/storage/distributor/operations/operation.cpp b/storage/src/vespa/storage/distributor/operations/operation.cpp
index 9e9e3f8a60a..ee695dae606 100644
--- a/storage/src/vespa/storage/distributor/operations/operation.cpp
+++ b/storage/src/vespa/storage/distributor/operations/operation.cpp
@@ -2,7 +2,6 @@
#include "operation.h"
#include <vespa/storage/common/distributorcomponent.h>
-#include <vespa/storageapi/messageapi/storagemessage.h>
#include <vespa/storageapi/messageapi/storagecommand.h>
#include <vespa/storageapi/messageapi/storagereply.h>
#include <vespa/vespalib/util/stringfmt.h>
@@ -17,9 +16,7 @@ Operation::Operation()
{
}
-Operation::~Operation()
-{
-}
+Operation::~Operation() = default;
std::string
Operation::getStatus() const
@@ -42,7 +39,6 @@ Operation::copyMessageSettings(const api::StorageCommand& source, api::StorageCo
target.getTrace().setLevel(source.getTrace().getLevel());
target.setTimeout(source.getTimeout());
target.setPriority(source.getPriority());
- target.setLoadType(source.getLoadType());
}
}
diff --git a/storage/src/vespa/storage/persistence/filestorage/filestormanager.cpp b/storage/src/vespa/storage/persistence/filestorage/filestormanager.cpp
index 54c1c7606b2..c1c412fefeb 100644
--- a/storage/src/vespa/storage/persistence/filestorage/filestormanager.cpp
+++ b/storage/src/vespa/storage/persistence/filestorage/filestormanager.cpp
@@ -673,7 +673,7 @@ FileStorManager::onInternal(const shared_ptr<api::InternalCommand>& msg)
}
case DestroyIteratorCommand::ID:
{
- spi::Context context(msg->getLoadType(), msg->getPriority(), msg->getTrace().getLevel());
+ spi::Context context(msg->getPriority(), msg->getTrace().getLevel());
shared_ptr<DestroyIteratorCommand> cmd(std::static_pointer_cast<DestroyIteratorCommand>(msg));
_provider->destroyIterator(cmd->getIteratorId(), context);
msg->getTrace().addChild(context.steal_trace());
diff --git a/storage/src/vespa/storage/persistence/filestorage/mergestatus.cpp b/storage/src/vespa/storage/persistence/filestorage/mergestatus.cpp
index 2e390db69be..a42a57f648c 100644
--- a/storage/src/vespa/storage/persistence/filestorage/mergestatus.cpp
+++ b/storage/src/vespa/storage/persistence/filestorage/mergestatus.cpp
@@ -9,12 +9,12 @@ LOG_SETUP(".mergestatus");
namespace storage {
-MergeStatus::MergeStatus(const framework::Clock& clock, const metrics::LoadType& lt,
+MergeStatus::MergeStatus(const framework::Clock& clock, const metrics::LoadType&,
api::StorageMessage::Priority priority,
uint32_t traceLevel)
: reply(), full_node_list(), nodeList(), maxTimestamp(0), diff(), pendingId(0),
pendingGetDiff(), pendingApplyDiff(), timeout(0), startTime(clock),
- context(lt, priority, traceLevel)
+ context(priority, traceLevel)
{}
MergeStatus::~MergeStatus() = default;
diff --git a/storage/src/vespa/storage/persistence/persistenceutil.cpp b/storage/src/vespa/storage/persistence/persistenceutil.cpp
index 9a7107fb583..90845e17b6f 100644
--- a/storage/src/vespa/storage/persistence/persistenceutil.cpp
+++ b/storage/src/vespa/storage/persistence/persistenceutil.cpp
@@ -42,7 +42,7 @@ MessageTracker::MessageTracker(const framework::MilliSecTimer & timer,
_updateBucketInfo(updateBucketInfo && hasBucketInfo(msg->getType().getId())),
_bucketLock(std::move(bucketLock)),
_msg(std::move(msg)),
- _context(_msg->getLoadType(), _msg->getPriority(), _msg->getTrace().getLevel()),
+ _context(_msg->getPriority(), _msg->getTrace().getLevel()),
_env(env),
_replySender(replySender),
_metric(nullptr),