summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2022-10-18 17:35:25 +0200
committerHenning Baldersheim <balder@yahoo-inc.com>2022-10-18 17:35:25 +0200
commita789e80b3f55aaff78b095a091cfcd68668e9c06 (patch)
tree00e1fa2015e20218b4d5ac3a4691b6b885d32261
parent03a634837a34ee12dd13b1f355a8ee69c3302c15 (diff)
Treat empty and null properties the same way.
-rw-r--r--container-core/src/main/java/com/yahoo/metrics/simple/PointBuilder.java10
-rw-r--r--container-core/src/main/java/com/yahoo/metrics/simple/jdisc/SimpleMetricConsumer.java2
2 files changed, 3 insertions, 9 deletions
diff --git a/container-core/src/main/java/com/yahoo/metrics/simple/PointBuilder.java b/container-core/src/main/java/com/yahoo/metrics/simple/PointBuilder.java
index 47061eba10b..a107bea3168 100644
--- a/container-core/src/main/java/com/yahoo/metrics/simple/PointBuilder.java
+++ b/container-core/src/main/java/com/yahoo/metrics/simple/PointBuilder.java
@@ -27,18 +27,12 @@ public final class PointBuilder {
}
PointBuilder(Point p) {
- dimensions = new ArrayList<>();
- location = new ArrayList<>();
if (p != null) {
int size = p.dimensionality();
dimensions = new ArrayList<>(size+2);
location = new ArrayList<>(size+2);
- for (String dimensionName : p.getDimensions()) {
- dimensions.add(dimensionName);
- }
- for (Value dimensionValue : p.getLocation()) {
- location.add(dimensionValue);
- }
+ Collections.addAll(dimensions, p.getDimensions());
+ Collections.addAll(location, p.getLocation());
} else {
dimensions = new ArrayList<>(4);
location = new ArrayList<>(4);
diff --git a/container-core/src/main/java/com/yahoo/metrics/simple/jdisc/SimpleMetricConsumer.java b/container-core/src/main/java/com/yahoo/metrics/simple/jdisc/SimpleMetricConsumer.java
index 3a40958f0b1..0286684c34c 100644
--- a/container-core/src/main/java/com/yahoo/metrics/simple/jdisc/SimpleMetricConsumer.java
+++ b/container-core/src/main/java/com/yahoo/metrics/simple/jdisc/SimpleMetricConsumer.java
@@ -45,7 +45,7 @@ public class SimpleMetricConsumer implements MetricConsumer {
@Override
public Context createContext(Map<String, ?> properties) {
- if (properties == null)
+ if ((properties == null) || properties.isEmpty())
return Point.emptyPoint();
return new Point(properties);
}