summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGeir Storli <geirst@yahooinc.com>2021-11-17 09:09:48 +0100
committerGitHub <noreply@github.com>2021-11-17 09:09:48 +0100
commitc5c86ba137dc2de6b2287e087332d24448203adb (patch)
treede3d4953c2210d7871182825f250626c60af95f8
parent3cc27ac65a5a6601f1405e67ab99c60cb63aa00c (diff)
parenta45d734f47aecfa585aae3c946fa0200e91fdcad (diff)
Merge pull request #20047 from vespa-engine/balder/gc-comment
GC void comments and comments stating the obvious.
-rw-r--r--searchcore/src/vespa/searchcore/proton/server/executorthreadingservice.h10
-rw-r--r--searchcore/src/vespa/searchcore/proton/test/threading_service_observer.h10
2 files changed, 2 insertions, 18 deletions
diff --git a/searchcore/src/vespa/searchcore/proton/server/executorthreadingservice.h b/searchcore/src/vespa/searchcore/proton/server/executorthreadingservice.h
index 611cf64aa9c..e571e205f47 100644
--- a/searchcore/src/vespa/searchcore/proton/server/executorthreadingservice.h
+++ b/searchcore/src/vespa/searchcore/proton/server/executorthreadingservice.h
@@ -17,7 +17,7 @@ class ThreadingServiceConfig;
class ExecutorThreadingService : public searchcorespi::index::IThreadingService
{
private:
- vespalib::ThreadExecutor & _sharedExecutor;
+ vespalib::ThreadExecutor & _sharedExecutor;
vespalib::ThreadStackExecutor _masterExecutor;
std::unique_ptr<vespalib::SyncableThreadExecutor> _indexExecutor;
std::unique_ptr<vespalib::SyncableThreadExecutor> _summaryExecutor;
@@ -46,9 +46,6 @@ public:
ExecutorThreadingService(vespalib::ThreadExecutor &sharedExecutor, uint32_t num_treads = 1);
~ExecutorThreadingService() override;
- /**
- * Implements vespalib::Syncable
- */
void sync_all_executors() override;
void shutdown();
@@ -67,9 +64,6 @@ public:
return *_summaryExecutor;
}
- /**
- * Implements IThreadingService
- */
searchcorespi::index::IThreadService &master() override {
return _masterService;
}
@@ -90,6 +84,6 @@ public:
ExecutorThreadingServiceStats getStats();
};
-} // namespace proton
+}
diff --git a/searchcore/src/vespa/searchcore/proton/test/threading_service_observer.h b/searchcore/src/vespa/searchcore/proton/test/threading_service_observer.h
index f1213d51296..1d379f439fa 100644
--- a/searchcore/src/vespa/searchcore/proton/test/threading_service_observer.h
+++ b/searchcore/src/vespa/searchcore/proton/test/threading_service_observer.h
@@ -32,16 +32,6 @@ public:
const ThreadServiceObserver &summaryObserver() const {
return _summary;
}
- const vespalib::SequencedTaskExecutorObserver &indexFieldInverterObserver() const {
- return _indexFieldInverter;
- }
- const vespalib::SequencedTaskExecutorObserver &indexFieldWriterObserver() const {
- return _indexFieldWriter;
- }
-
- const vespalib::SequencedTaskExecutorObserver &attributeFieldWriterObserver() const {
- return _attributeFieldWriter;
- }
void sync_all_executors() override {
_service.sync_all_executors();