diff options
author | Bjørn Christian Seime <bjorncs@verizonmedia.com> | 2022-10-19 16:13:48 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-10-19 16:13:48 +0200 |
commit | 75927dd0f02f06b873e8f2c6785432dd8d324a10 (patch) | |
tree | 5eee3ad92a1f583357daba47957daac1f8d42bbf | |
parent | dfb918506e63fee9c7c41949bc5fa10b7d98bc93 (diff) | |
parent | 114c33094646b8719449eaeac0be7cc693ab7e26 (diff) |
Merge pull request #24511 from vespa-engine/balder/reuse-already-acquired-contextv8.71.9
Balder/reuse already acquired context
5 files changed, 8 insertions, 6 deletions
diff --git a/container-core/src/main/java/com/yahoo/jdisc/http/server/jetty/JDiscHttpServlet.java b/container-core/src/main/java/com/yahoo/jdisc/http/server/jetty/JDiscHttpServlet.java index dbe2b2ad5d5..4b4aff0a9bd 100644 --- a/container-core/src/main/java/com/yahoo/jdisc/http/server/jetty/JDiscHttpServlet.java +++ b/container-core/src/main/java/com/yahoo/jdisc/http/server/jetty/JDiscHttpServlet.java @@ -97,7 +97,7 @@ class JDiscHttpServlet extends HttpServlet { super.service(request, response); } else if (method.equals(Method.PATCH.name())) { // PATCH method is not handled by the Servlet spec - dispatchHttpRequest(request, response); + dispatchHttpRequest(request, response, metricContext); } else { // Divergence from HTTP / Servlet spec: JDisc returns 405 for both unknown and known (but unsupported) methods. response.sendError(HttpServletResponse.SC_METHOD_NOT_ALLOWED); @@ -105,12 +105,16 @@ class JDiscHttpServlet extends HttpServlet { } private void dispatchHttpRequest(HttpServletRequest request, HttpServletResponse response) throws IOException { + dispatchHttpRequest(request, response, getMetricContext(request)); + } + + private void dispatchHttpRequest(HttpServletRequest request, HttpServletResponse response, Metric.Context metricContext) throws IOException { AccessLogEntry accessLogEntry = new AccessLogEntry(); request.setAttribute(ATTRIBUTE_NAME_ACCESS_LOG_ENTRY, accessLogEntry); try { switch (request.getDispatcherType()) { case REQUEST: - new HttpRequestDispatch(context, accessLogEntry, getMetricContext(request), request, response).dispatchRequest(); + new HttpRequestDispatch(context, accessLogEntry, metricContext, request, response).dispatchRequest(); break; default: if (log.isLoggable(Level.INFO)) { diff --git a/container-core/src/main/java/com/yahoo/metrics/simple/Counter.java b/container-core/src/main/java/com/yahoo/metrics/simple/Counter.java index a119902aac7..20303fab671 100644 --- a/container-core/src/main/java/com/yahoo/metrics/simple/Counter.java +++ b/container-core/src/main/java/com/yahoo/metrics/simple/Counter.java @@ -57,7 +57,7 @@ public class Counter { * the point in the metric space at which to add to the metric */ public void add(long n, Point p) { - metricReceiver.update(new Sample(new Measurement(Long.valueOf(n)), new Identifier(name, p), AssumedType.COUNTER)); + metricReceiver.update(new Sample(new Measurement(n), new Identifier(name, p), AssumedType.COUNTER)); } /** diff --git a/container-core/src/main/java/com/yahoo/metrics/simple/Gauge.java b/container-core/src/main/java/com/yahoo/metrics/simple/Gauge.java index 684bf4b5db1..4d9fd7300e8 100644 --- a/container-core/src/main/java/com/yahoo/metrics/simple/Gauge.java +++ b/container-core/src/main/java/com/yahoo/metrics/simple/Gauge.java @@ -43,7 +43,7 @@ public class Gauge { * position/dimension values for the sample */ public void sample(double x, Point p) { - receiver.update(new Sample(new Measurement(Double.valueOf(x)), new Identifier(name, p), AssumedType.GAUGE)); + receiver.update(new Sample(new Measurement(x), new Identifier(name, p), AssumedType.GAUGE)); } /** diff --git a/container-search/src/main/java/com/yahoo/search/searchers/ContainerLatencySearcher.java b/container-search/src/main/java/com/yahoo/search/searchers/ContainerLatencySearcher.java index 942d9d1530d..742f4b0f889 100644 --- a/container-search/src/main/java/com/yahoo/search/searchers/ContainerLatencySearcher.java +++ b/container-search/src/main/java/com/yahoo/search/searchers/ContainerLatencySearcher.java @@ -4,7 +4,6 @@ package com.yahoo.search.searchers; import com.yahoo.component.chain.dependencies.After; import com.yahoo.metrics.simple.Gauge; import com.yahoo.metrics.simple.Point; -import com.yahoo.metrics.simple.PointBuilder; import com.yahoo.metrics.simple.MetricReceiver; import com.yahoo.search.Query; import com.yahoo.search.Result; diff --git a/container-search/src/main/java/com/yahoo/search/searchers/RateLimitingSearcher.java b/container-search/src/main/java/com/yahoo/search/searchers/RateLimitingSearcher.java index dee00691fb3..cf81f62f64d 100755 --- a/container-search/src/main/java/com/yahoo/search/searchers/RateLimitingSearcher.java +++ b/container-search/src/main/java/com/yahoo/search/searchers/RateLimitingSearcher.java @@ -18,7 +18,6 @@ import com.yahoo.search.searchchain.Execution; import com.yahoo.yolean.chain.Provides; import java.time.Clock; -import java.util.Collections; import java.util.HashMap; import java.util.Map; import java.util.concurrent.ThreadLocalRandom; |