summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJon Marius Venstad <jvenstad@yahoo-inc.com>2019-03-28 09:49:23 +0100
committerJon Marius Venstad <jvenstad@yahoo-inc.com>2019-03-28 10:27:12 +0100
commite12d4f8538e4f9df7c07f3163a549646139b5d49 (patch)
tree5ff162153e13c608c89fd473b48a5275abf846ef
parent8b6b97e50eb89e23ab96514e6f7b73823c7cb05c (diff)
Add some TODOs and fix a path group
-rw-r--r--controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/application/JobControllerApiHandlerHelper.java2
-rw-r--r--controller-server/src/main/java/com/yahoo/vespa/hosted/controller/role/PathGroup.java2
-rw-r--r--controller-server/src/test/java/com/yahoo/vespa/hosted/controller/restapi/application/JobControllerApiHandlerHelperTest.java2
3 files changed, 3 insertions, 3 deletions
diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/application/JobControllerApiHandlerHelper.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/application/JobControllerApiHandlerHelper.java
index 2fb493cad42..73345923369 100644
--- a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/application/JobControllerApiHandlerHelper.java
+++ b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/application/JobControllerApiHandlerHelper.java
@@ -62,7 +62,7 @@ import static java.util.stream.Collectors.toMap;
* @see JobController
* @see ApplicationApiHandler
*/
-class JobControllerApiHandlerHelper {
+class JobControllerApiHandlerHelper { // TODO jvenstad: Integrate into ApplicationApiHandler
/**
* @return Response with all job types that have recorded runs for the application _and_ the status for the last run of that type
diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/role/PathGroup.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/role/PathGroup.java
index ebfde10037b..8bfb60fd1d0 100644
--- a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/role/PathGroup.java
+++ b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/role/PathGroup.java
@@ -47,7 +47,7 @@ public enum PathGroup {
"/application/v4/tenant/{tenant}/application/{application}",
"/application/v4/tenant/{tenant}/application/{application}/deploying/{*}",
"/application/v4/tenant/{tenant}/application/{application}/instance/{*}",
- "/application/v4/tenant/{tenant}/application/{application}/environment/prod/region/{region}/instance/{instance}/global-rotation/override"),
+ "/application/v4/tenant/{tenant}/application/{application}/environment/prod/region/{region}/instance/{instance}/global-rotation/override"),// TODO add restart path?
/** Paths used for direct deployment to development zones. */
development(Matcher.tenant,
diff --git a/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/restapi/application/JobControllerApiHandlerHelperTest.java b/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/restapi/application/JobControllerApiHandlerHelperTest.java
index df1f202a75c..96eecd199cf 100644
--- a/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/restapi/application/JobControllerApiHandlerHelperTest.java
+++ b/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/restapi/application/JobControllerApiHandlerHelperTest.java
@@ -39,7 +39,7 @@ import static org.junit.Assert.assertEquals;
* @author jonmv
* @author freva
*/
-public class JobControllerApiHandlerHelperTest {
+public class JobControllerApiHandlerHelperTest { // TODO jvenstad: Integrate into ApplicationApiTest
@Test
public void testResponses() {