diff options
author | Jon Marius Venstad <jonmv@users.noreply.github.com> | 2021-10-29 10:34:13 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-10-29 10:34:13 +0200 |
commit | b8572b6c6e94a1bc85c4c7786a8bf08c0545926b (patch) | |
tree | ed27dd42ae779d8ffe51de0167e3c4e7899bc067 | |
parent | 52e1e87760b208a3552aadc132c8947f0ee490e5 (diff) | |
parent | d201899936af77c2a6989fdec14524aaa8ba4918 (diff) |
Merge pull request #19785 from vespa-engine/comment-printlns
Comment debug println and add class comment.
-rw-r--r-- | container-core/src/main/java/com/yahoo/container/di/Osgi.java | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/container-core/src/main/java/com/yahoo/container/di/Osgi.java b/container-core/src/main/java/com/yahoo/container/di/Osgi.java index 39565756ac9..a3ebc909a6e 100644 --- a/container-core/src/main/java/com/yahoo/container/di/Osgi.java +++ b/container-core/src/main/java/com/yahoo/container/di/Osgi.java @@ -14,6 +14,9 @@ import java.util.stream.Collectors; import static java.util.Collections.emptySet; /** + * This interface has default implementations of all methods, to allow using it + * for testing, instead of mocking or a test implementation. + * * @author gjoranv * @author Tony Vaagenes * @author ollivir @@ -21,7 +24,7 @@ import static java.util.Collections.emptySet; public interface Osgi { default void installPlatformBundles(Collection<String> bundlePaths) { - System.out.println("installPlatformBundles " + bundlePaths); + //System.out.println("installPlatformBundles " + bundlePaths); } /** @@ -29,12 +32,12 @@ public interface Osgi { * and therefore should be scheduled for uninstalling. */ default Set<Bundle> useApplicationBundles(Collection<FileReference> bundles) { - System.out.println("useBundles " + bundles.stream().map(Object::toString).collect(Collectors.joining(", "))); + //System.out.println("useBundles " + bundles.stream().map(Object::toString).collect(Collectors.joining(", "))); return emptySet(); } default Class<?> resolveClass(BundleInstantiationSpecification spec) { - System.out.println("resolving class " + spec.classId); + //System.out.println("resolving class " + spec.classId); try { return Class.forName(spec.classId.getName()); } catch (ClassNotFoundException e) { @@ -43,7 +46,7 @@ public interface Osgi { } default Bundle getBundle(ComponentSpecification spec) { - System.out.println("resolving bundle " + spec); + //System.out.println("resolving bundle " + spec); return new MockBundle(); } } |