diff options
author | gjoranv <gv@verizonmedia.com> | 2019-05-29 21:46:04 +0200 |
---|---|---|
committer | gjoranv <gv@verizonmedia.com> | 2019-05-29 21:46:04 +0200 |
commit | 5580ff82ed14ba1ea19163d9274371e9689f45e7 (patch) | |
tree | ea3598b0c816aad1d00f9d59990bc8f5065e9099 | |
parent | 95924d44af5f3eb8a622e935e5d701d75a94b344 (diff) |
Bugfix: set sentinel client before updating services.
-rw-r--r-- | metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/VespaServices.java | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/VespaServices.java b/metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/VespaServices.java index 3fbd5e49882..0f95a698393 100644 --- a/metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/VespaServices.java +++ b/metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/VespaServices.java @@ -36,8 +36,9 @@ public class VespaServices { @Inject public VespaServices(VespaServicesConfig config, MonitoringConfig monitoringConfig, ConfigSentinelClient sentinel) { - this.services = createServices(config, monitoringConfig.systemName()); this.sentinel = sentinel; + this.services = createServices(config, monitoringConfig.systemName()); + updateServices(services); } @VisibleForTesting @@ -49,13 +50,12 @@ public class VespaServices { private List<VespaService> createServices(VespaServicesConfig servicesConfig, String monitoringSystemName) { List<VespaService> services = new ArrayList<>(); for (Service s : servicesConfig.service()) { - log.log(DEBUG, "Re-configuring service " + s.name()); + log.log(DEBUG, "Creating service " + s.name()); VespaService vespaService = VespaService.create(s.name(), s.configId(), s.port(), monitoringSystemName, createServiceDimensions(s)); services.add(vespaService); } log.log(DEBUG, "Created new services: " + services.size()); - updateServices(services); return services; } @@ -63,7 +63,7 @@ public class VespaServices { * Sets 'alive=false' for services that are no longer running. * Note that the status is updated in-place for the given services. */ - public void updateServices(List<VespaService> services) { + public final void updateServices(List<VespaService> services) { if (sentinel != null) { log.log(DEBUG, "Updating services "); sentinel.updateServiceStatuses(services); |