summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@oath.com>2018-04-16 15:43:57 +0200
committerHenning Baldersheim <balder@oath.com>2018-04-16 15:43:57 +0200
commit2b139c3df65f53948bf49d9d7bc3ac0ea2e46dea (patch)
tree123039d898c7ae29ec8cfa2ba22a6e16999ec042
parent382951509d1f3b054d9241ef98d1c5a6eac3834c (diff)
Remove no longer needed test
-rw-r--r--storage/src/tests/bucketdb/bucketmanagertest.cpp25
1 files changed, 0 insertions, 25 deletions
diff --git a/storage/src/tests/bucketdb/bucketmanagertest.cpp b/storage/src/tests/bucketdb/bucketmanagertest.cpp
index 0c7122547db..d42330086f0 100644
--- a/storage/src/tests/bucketdb/bucketmanagertest.cpp
+++ b/storage/src/tests/bucketdb/bucketmanagertest.cpp
@@ -82,7 +82,6 @@ public:
CPPUNIT_TEST(testConflictSetOnlyClearedAfterAllBucketRequestsDone);
CPPUNIT_TEST(testRejectRequestWithMismatchingDistributionHash);
CPPUNIT_TEST(testDbNotIteratedWhenAllRequestsRejected);
- CPPUNIT_TEST(testReceivedDistributionHashIsNormalized);
// FIXME(vekterli): test is not deterministic and enjoys failing
// sporadically when running under Valgrind. See bug 5932891.
@@ -1311,28 +1310,4 @@ BucketManagerTest::testDbNotIteratedWhenAllRequestsRejected()
auto replies = fixture.awaitAndGetReplies(1);
}
-/**
- * Accept bucket info requests if their distribution hash is a valid permutation
- * of our own config (i.e. they are set-wise identical even though the
- * ordering of nodes may differ). See VESPA-1980 for context.
- */
-void
-BucketManagerTest::testReceivedDistributionHashIsNormalized()
-{
- ConcurrentOperationFixture fixture(*this);
- document::BucketId bucket(17, 0);
- fixture.setUp(WithBuckets().add(bucket, api::BucketInfo(50, 100, 200)));
-
- // Test is configured with 10 nodes in increasing order. Jumble the order
- // around.
- auto infoCmd = fixture.createFullFetchCommandWithHash(
- "(0;2;1;3;9;6;4;5;8;7;0)");
- _top->sendDown(infoCmd);
- auto replies = fixture.awaitAndGetReplies(1);
- auto& reply = dynamic_cast<api::RequestBucketInfoReply&>(*replies[0]);
- // Should NOT have been rejected despite hash not matching config order
- // verbatim.
- CPPUNIT_ASSERT_EQUAL(api::ReturnCode::OK, reply.getResult().getResult());
-}
-
} // storage