summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2023-12-01 15:54:37 +0100
committerGitHub <noreply@github.com>2023-12-01 15:54:37 +0100
commitab36f0935311ff4ffe524bd5a172585ba16a5a11 (patch)
tree2c64d140464e761b0f2773791a617e0b5c0fd79f
parent0a58a0322841de9313ae56ace08880def3f4a9c3 (diff)
parent64e39db4bdbb9fab7b8b99855b16b51b3ee52ea5 (diff)
Merge pull request #29528 from vespa-engine/balder/add-more-info-when-test-fails
- Show what is mismatch in error message.
-rw-r--r--searchlib/src/tests/ranksetup/verify_feature/verify_feature_test.cpp5
-rw-r--r--searchlib/src/vespa/searchlib/attribute/postinglistsearchcontext.hpp3
2 files changed, 6 insertions, 2 deletions
diff --git a/searchlib/src/tests/ranksetup/verify_feature/verify_feature_test.cpp b/searchlib/src/tests/ranksetup/verify_feature/verify_feature_test.cpp
index feee5128493..4fdcc7f1d8a 100644
--- a/searchlib/src/tests/ranksetup/verify_feature/verify_feature_test.cpp
+++ b/searchlib/src/tests/ranksetup/verify_feature/verify_feature_test.cpp
@@ -28,6 +28,7 @@ std::ostream &operator<<(std::ostream &os, Level level) {
}
bool equal(const vespalib::string & a, const vespalib::string &b) {
+ EXPECT_EQUAL(a, b);
return a == b;
}
@@ -53,6 +54,10 @@ struct RankFixture {
EXPECT_EQUAL(errors[i].first, expected[i].second.first);
EXPECT_TRUE(expected[i].first(errors[i].second, expected[i].second.second));
}
+ for (size_t i(expected.size()); i < errors.size(); i++) {
+ EXPECT_EQUAL(errors[i].first, Level::INFO);
+ EXPECT_EQUAL(errors[i].second, "");
+ }
return ok;
}
};
diff --git a/searchlib/src/vespa/searchlib/attribute/postinglistsearchcontext.hpp b/searchlib/src/vespa/searchlib/attribute/postinglistsearchcontext.hpp
index 4436ea203ce..3ff5c749899 100644
--- a/searchlib/src/vespa/searchlib/attribute/postinglistsearchcontext.hpp
+++ b/searchlib/src/vespa/searchlib/attribute/postinglistsearchcontext.hpp
@@ -73,8 +73,7 @@ void
PostingListSearchContextT<DataT>::fillBitVector()
{
for (auto it(_lowerDictItr); it != _upperDictItr; ++it) {
- _merger.addToBitVector(PostingListTraverser<PostingStore>(_posting_store,
- it.getData().load_acquire()));
+ _merger.addToBitVector(PostingListTraverser<PostingStore>(_posting_store, it.getData().load_acquire()));
}
}